From 3db16ede73c9a6e3a2ca82679f7aba29858c2b5e Mon Sep 17 00:00:00 2001
From: Robert Kloefkorn <robert.kloefkorn@iris.no>
Date: Wed, 31 May 2017 13:01:51 +0200
Subject: [PATCH] [bugfix] Fix invalid read in WellDenseStandard when used with
 2P Model.

---
 opm/autodiff/StandardWellsDense_impl.hpp | 17 ++++++++++++-----
 1 file changed, 12 insertions(+), 5 deletions(-)

diff --git a/opm/autodiff/StandardWellsDense_impl.hpp b/opm/autodiff/StandardWellsDense_impl.hpp
index d1af3d5dd..789879dca 100644
--- a/opm/autodiff/StandardWellsDense_impl.hpp
+++ b/opm/autodiff/StandardWellsDense_impl.hpp
@@ -683,11 +683,18 @@ namespace Opm {
     setWellVariables(const WellState& xw)
     {
         const int nw = wells().number_of_wells;
-        for (int eqIdx = 0; eqIdx < numWellEq; ++eqIdx) {
+        // for two-phase numComp < numEq
+        const int numComp = numComponents();
+        for (int eqIdx = 0; eqIdx < numComp; ++eqIdx) {
             for (int w = 0; w < nw; ++w) {
-                wellVariables_[w + nw*eqIdx] = 0.0;
-                wellVariables_[w + nw*eqIdx].setValue(xw.wellSolutions()[w + nw* eqIdx]);
-                wellVariables_[w + nw*eqIdx].setDerivative(numWellEq + eqIdx, 1.0);
+                const unsigned int idx = nw * eqIdx + w;
+                assert( idx < wellVariables_.size() );
+                assert( idx < xw.wellSolutions().size() );
+                EvalWell& eval = wellVariables_[ idx ];
+
+                eval = 0.0;
+                eval.setValue( xw.wellSolutions()[ idx ] );
+                eval.setDerivative(numWellEq + eqIdx, 1.0);
             }
         }
     }
@@ -997,7 +1004,7 @@ namespace Opm {
         {
             bval/=global_nc_;
         }
-        
+
         auto res = residual();
         const int nw = res.size() / numComp;