OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2024-12-31 11:36:55 -06:00
Code Issues Packages Projects Releases Wiki Activity

Prefer BOOST_CHECK_EQUAL to BOOST_CHECK

Browse Source 
The former is more assertive than the latter and provides better
diagnostics.  Incidentally, switching to *_EQUAL() also fixes an
assignment that was (probably) intended to be an equality test:

   BOOST_CHECK(count = num)

in both test cases.
This commit is contained in:
Bård Skaflestad 2013-05-24 21:59:09 +02:00
parent eee8c27346
commit 2b57104097
1 changed files with 8 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
tests/test_span.cpp
View File

@ -35,16 +35,16 @@ BOOST_AUTO_TEST_CASE(OneArgConstr)
{ {
const int num = 4; const int num = 4;
const Span s(num); const Span s(num);
BOOST_CHECK(s.size() == num); BOOST_CHECK_EQUAL(s.size(), num);
for (int i = 0; i < num; ++i) { for (int i = 0; i < num; ++i) {
BOOST_CHECK(s[i] == i); BOOST_CHECK_EQUAL(s[i], i);
} }
int count = 0; int count = 0;
for (Span::const_iterator it = s.begin(); it != s.end(); ++it) { for (Span::const_iterator it = s.begin(); it != s.end(); ++it) {
BOOST_CHECK(*it == count); BOOST_CHECK_EQUAL(*it, count);
++count; ++count;
} }
BOOST_CHECK(count = num); BOOST_CHECK_EQUAL(count, num);
} }
BOOST_AUTO_TEST_CASE(ThreeArgConstr) BOOST_AUTO_TEST_CASE(ThreeArgConstr)
@ -55,15 +55,14 @@ BOOST_AUTO_TEST_CASE(ThreeArgConstr)
const int seq[num] = { start, start + 1*stride, start + 2*stride }; const int seq[num] = { start, start + 1*stride, start + 2*stride };
const Span s(num, stride, start); const Span s(num, stride, start);
BOOST_CHECK(s.size() == num); BOOST_CHECK_EQUAL(s.size(), num);
for (int i = 0; i < num; ++i) { for (int i = 0; i < num; ++i) {
BOOST_CHECK(s[i] == seq[i]); BOOST_CHECK_EQUAL(s[i], seq[i]);
} }
int count = 0; int count = 0;
for (Span::const_iterator it = s.begin(); it != s.end(); ++it) { for (Span::const_iterator it = s.begin(); it != s.end(); ++it) {
BOOST_CHECK(*it == seq[count]); BOOST_CHECK_EQUAL(*it, seq[count]);
++count; ++count;
} }
BOOST_CHECK(count = num); BOOST_CHECK_EQUAL(count, num);
} }