OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Fix TRANXYZ for problems with less than 3 dimensions.

Browse Source 
Up to now We always assumed that cardDims[i]>1 holds. which it does for most
of the cases. But when e.g. simulating a vertical stack of 5 cells
flow would report the transmissibilities in the Z direction in TRANX
and output TRANZ as zero. Similar problems should be there for 2D grids.

With this commit we actually check whether there can be neighbours in
the X and Z direction to prevent this behavior.
This commit is contained in:
Markus Blatt 2020-06-15 10:40:26 +02:00
parent c57a901e51
commit 2e9cfffea6
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
ebos/ecltransmissibility.hh
View File

@ -530,7 +530,7 @@ private:
int gc1 = std::min(cartMapper.cartesianIndex(c1), cartMapper.cartesianIndex(c2)); int gc1 = std::min(cartMapper.cartesianIndex(c1), cartMapper.cartesianIndex(c2));
int gc2 = std::max(cartMapper.cartesianIndex(c1), cartMapper.cartesianIndex(c2)); int gc2 = std::max(cartMapper.cartesianIndex(c1), cartMapper.cartesianIndex(c2));
if (gc2 - gc1 == 1) { if (gc2 - gc1 == 1 && cartDims[0] > 1) {
if (tranx_deckAssigned) if (tranx_deckAssigned)
// set simulator internal transmissibilities to values from inputTranx // set simulator internal transmissibilities to values from inputTranx
trans_[isId] = inputTranxData[c1]; trans_[isId] = inputTranxData[c1];
@ -538,7 +538,7 @@ private:
// Scale transmissibilities with scale factor from inputTranx // Scale transmissibilities with scale factor from inputTranx
trans_[isId] *= inputTranxData[c1]; trans_[isId] *= inputTranxData[c1];
} }
else if (gc2 - gc1 == cartDims[0]) { else if (gc2 - gc1 == cartDims[0] && cartDims[1] > 1) {
if (trany_deckAssigned) if (trany_deckAssigned)
// set simulator internal transmissibilities to values from inputTrany // set simulator internal transmissibilities to values from inputTrany
trans_[isId] = inputTranyData[c1]; trans_[isId] = inputTranyData[c1];

4
ebos/eclwriter.hh
View File

@ -552,12 +552,12 @@ private:
int gc1 = std::min(cartIdx1, cartIdx2); int gc1 = std::min(cartIdx1, cartIdx2);
int gc2 = std::max(cartIdx1, cartIdx2); int gc2 = std::max(cartIdx1, cartIdx2);
if (gc2 - gc1 == 1) { if (gc2 - gc1 == 1 && cartDims[0] > 1 ) {
tranx.data[gc1] = globalTrans->transmissibility(c1, c2); tranx.data[gc1] = globalTrans->transmissibility(c1, c2);
continue; // skip other if clauses as they are false, last one needs some computation continue; // skip other if clauses as they are false, last one needs some computation
} }
if (gc2 - gc1 == cartDims[0]) { if (gc2 - gc1 == cartDims[0] && cartDims[1] > 1) {
trany.data[gc1] = globalTrans->transmissibility(c1, c2); trany.data[gc1] = globalTrans->transmissibility(c1, c2);
continue; // skipt next if clause as it needs some computation continue; // skipt next if clause as it needs some computation
} }