OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

changed: pass the actual update value to relaxationFactorRate

Browse Source 
this to avoid ussage of BVectorWell in interface. in preparation
for moving BVectorWell out of the well hierarchy.
This commit is contained in:
Arne Morten Kvarving 2022-11-04 14:57:11 +01:00
parent c8813a4dd0
commit 35b66886a9
3 changed files with 3 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
opm/simulators/wells/StandardWellEval.cpp
View File

@ -746,7 +746,7 @@ updatePrimaryVariablesNewton(const BVectorWell& dwells,
processFractions(); processFractions();
// updating the total rates Q_t // updating the total rates Q_t
const double relaxation_factor_rate = this->relaxationFactorRate(old_primary_variables, dwells); const double relaxation_factor_rate = this->relaxationFactorRate(old_primary_variables, dwells[0][WQTotal]);
primary_variables_[WQTotal] = old_primary_variables[WQTotal] - dwells[0][WQTotal] * relaxation_factor_rate; primary_variables_[WQTotal] = old_primary_variables[WQTotal] - dwells[0][WQTotal] * relaxation_factor_rate;
// updating the bottom hole pressure // updating the bottom hole pressure

3
opm/simulators/wells/StandardWellGeneric.cpp
View File

@ -64,14 +64,13 @@ template<class Scalar>
double double
StandardWellGeneric<Scalar>:: StandardWellGeneric<Scalar>::
relaxationFactorRate(const std::vector<double>& primary_variables, relaxationFactorRate(const std::vector<double>& primary_variables,
const BVectorWell& dwells) const double newton_update)
{ {
double relaxation_factor = 1.0; double relaxation_factor = 1.0;
static constexpr int WQTotal = 0; static constexpr int WQTotal = 0;
// For injector, we only check the total rates to avoid sign change of rates // For injector, we only check the total rates to avoid sign change of rates
const double original_total_rate = primary_variables[WQTotal]; const double original_total_rate = primary_variables[WQTotal];
const double newton_update = dwells[0][WQTotal];
const double possible_update_total_rate = primary_variables[WQTotal] - newton_update; const double possible_update_total_rate = primary_variables[WQTotal] - newton_update;
// 0.8 here is a experimental value, which remains to be optimized // 0.8 here is a experimental value, which remains to be optimized

2
opm/simulators/wells/StandardWellGeneric.hpp
View File

@ -74,7 +74,7 @@ protected:
// calculate a relaxation factor to avoid overshoot of total rates // calculate a relaxation factor to avoid overshoot of total rates
static double relaxationFactorRate(const std::vector<double>& primary_variables, static double relaxationFactorRate(const std::vector<double>& primary_variables,
const BVectorWell& dwells); const double newton_update);
// relaxation factor considering only one fraction value // relaxation factor considering only one fraction value
static double relaxationFactorFraction(const double old_value, static double relaxationFactorFraction(const double old_value,