OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #5290 from akva2/constraints_fix_bare_throw

Browse Source 
BlackoilWellModelConstraints: fix throw of bare string
This commit is contained in:
Bård Skaflestad 2024-04-17 11:06:25 +02:00 committed by GitHub
commit 456e149a64
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 28 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

39
opm/simulators/wells/BlackoilWellModelConstraints.cpp
View File

@ -412,15 +412,19 @@ actionOnBrokenConstraints(const Group& group,
{ {
bool changed = false; bool changed = false;
const Group::ProductionCMode oldControl = wellModel_.groupState().production_control(group.name()); const Group::ProductionCMode oldControl =
wellModel_.groupState().production_control(group.name());
std::string ss; std::string ss;
switch(group_limit_action.allRates) { switch(group_limit_action.allRates) {
case Group::ExceedAction::NONE: { case Group::ExceedAction::NONE: {
if (oldControl != newControl && oldControl != Group::ProductionCMode::NONE) { if (oldControl != newControl && oldControl != Group::ProductionCMode::NONE) {
if ((group_limit_action.water == Group::ExceedAction::RATE && newControl == Group::ProductionCMode::WRAT) || if ((group_limit_action.water == Group::ExceedAction::RATE &&
(group_limit_action.gas == Group::ExceedAction::RATE && newControl == Group::ProductionCMode::GRAT) || newControl == Group::ProductionCMode::WRAT) ||
(group_limit_action.liquid == Group::ExceedAction::RATE && newControl == Group::ProductionCMode::LRAT)) { (group_limit_action.gas == Group::ExceedAction::RATE &&
newControl == Group::ProductionCMode::GRAT) ||
(group_limit_action.liquid == Group::ExceedAction::RATE &&
newControl == Group::ProductionCMode::LRAT)) {
group_state.production_control(group.name(), newControl); group_state.production_control(group.name(), newControl);
ss = fmt::format("Switching production control mode for group {} from {} to {}", ss = fmt::format("Switching production control mode for group {} from {} to {}",
group.name(), group.name(),
@ -430,7 +434,8 @@ actionOnBrokenConstraints(const Group& group,
changed = true; changed = true;
} }
else { else {
ss = fmt::format("Procedure on exceeding {} limit is NONE for group {}. Nothing is done.", ss = fmt::format("Procedure on exceeding {} limit is NONE for group {}. "
"Nothing is done.",
Group::ProductionCMode2String(oldControl), Group::ProductionCMode2String(oldControl),
group.name()); group.name());
} }
@ -438,21 +443,32 @@ actionOnBrokenConstraints(const Group& group,
break; break;
} }
case Group::ExceedAction::CON: { case Group::ExceedAction::CON: {
OPM_DEFLOG_THROW(std::runtime_error, "Group " + group.name() + "GroupProductionExceedLimit CON not implemented", deferred_logger); OPM_DEFLOG_THROW(std::runtime_error,
fmt::format("Group {} GroupProductionExceedLimit CON not implemented",
group.name()),
deferred_logger);
break; break;
} }
case Group::ExceedAction::CON_PLUS: { case Group::ExceedAction::CON_PLUS: {
OPM_DEFLOG_THROW(std::runtime_error, "Group " + group.name() + "GroupProductionExceedLimit CON_PLUS not implemented", deferred_logger); OPM_DEFLOG_THROW(std::runtime_error,
fmt::format("Group {} GroupProductionExceedLimit CON_PLUS not implemented",
group.name()),
deferred_logger);
break; break;
} }
case Group::ExceedAction::WELL: { case Group::ExceedAction::WELL: {
std::tie(worst_offending_well, std::ignore) = WellGroupHelpers::worstOffendingWell(group, wellModel_.schedule(), reportStepIdx, std::tie(worst_offending_well, std::ignore) =
newControl, wellModel_.phaseUsage(), wellModel_.comm(), well_state, deferred_logger); WellGroupHelpers::worstOffendingWell(group, wellModel_.schedule(), reportStepIdx,
newControl, wellModel_.phaseUsage(),
wellModel_.comm(), well_state, deferred_logger);
break; break;
} }
case Group::ExceedAction::PLUG: { case Group::ExceedAction::PLUG: {
OPM_DEFLOG_THROW(std::runtime_error, "Group " + group.name() + "GroupProductionExceedLimit PLUG not implemented", deferred_logger); OPM_DEFLOG_THROW(std::runtime_error,
fmt::format("Group {} GroupProductionExceedLimit PLUG not implemented",
group.name()),
deferred_logger);
break; break;
} }
case Group::ExceedAction::RATE: { case Group::ExceedAction::RATE: {
@ -467,7 +483,8 @@ actionOnBrokenConstraints(const Group& group,
break; break;
} }
default: default:
throw("Invalid procedure for maximum rate limit selected for group" + group.name()); OPM_THROW(std::runtime_error,
"Invalid procedure for maximum rate limit selected for group" + group.name());
} }
if (!ss.empty() && wellModel_.comm().rank() == 0) if (!ss.empty() && wellModel_.comm().rank() == 0)