OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Avoid fraction relaxation factors outside [0,1] in the standard well model.

Browse Source
This commit is contained in:
Vegard Kippe
2023-09-12 00:20:02 +02:00
parent 1d33e7caf0
commit 4638b3a9be
1 changed files with 10 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

14
opm/simulators/wells/StandardWellPrimaryVariables.cpp
View File

@@ -44,23 +44,29 @@
namespace { namespace {
constexpr double EPSILON = 1.0e-14;
double safe_fraction(const double fraction) {
return std::min(std::max(fraction, 0.0), 1.0);
}
//! \brief Relaxation factor considering only one fraction value. //! \brief Relaxation factor considering only one fraction value.
template<class Scalar> template<class Scalar>
Scalar relaxationFactorFraction(const Scalar old_value, Scalar relaxationFactorFraction(const Scalar old_value,
const Scalar dx) const Scalar dx)
{ {
assert(old_value >= 0. && old_value <= 1.0); assert(old_value >= -EPSILON && old_value <= (1.0+EPSILON));
const Scalar safe_old_value = safe_fraction(old_value);
Scalar relaxation_factor = 1.; Scalar relaxation_factor = 1.;
// updated values without relaxation factor // updated values without relaxation factor
const Scalar possible_updated_value = old_value - dx; const Scalar possible_updated_value = safe_old_value - dx;
// 0.95 is an experimental value remains to be optimized // 0.95 is an experimental value remains to be optimized
if (possible_updated_value < 0.0) { if (possible_updated_value < 0.0) {
relaxation_factor = std::abs(old_value / dx) * 0.95; relaxation_factor = std::abs(safe_old_value / dx) * 0.95;
} else if (possible_updated_value > 1.0) { } else if (possible_updated_value > 1.0) {
relaxation_factor = std::abs((1. - old_value) / dx) * 0.95; relaxation_factor = std::abs((1. - safe_old_value) / dx) * 0.95;
} }
// if possible_updated_value is between 0. and 1.0, then relaxation_factor // if possible_updated_value is between 0. and 1.0, then relaxation_factor
// remains to be one // remains to be one