OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Don't Apply Regional Multipliers Twice to EDITNNC Connections

Browse Source 
The connections entered in the EDITNNC keyword are already fully
accounted for in the main 'update()' loop followed by the helper
function applyEditNncToGridTrans_().  Therefore, it is wrong to
include those connections when applying MULTREGT to NNCs.  This
commit removes the pertinent connections from the main loop in
helper function applyNncMultreg_().

Commit ddcafa8a91 got this wrong, so pointy hat to [at]bska.
This commit is contained in:
Bård Skaflestad 2023-10-10 11:55:49 +02:00
parent 1cc806cf42
commit 544496d0eb
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
ebos/ecltransmissibility_impl.hh
View File

@ -1044,10 +1044,18 @@ applyNncMultreg_(const std::unordered_map<std::size_t,int>& cartesianToCompresse
return (ixPos == cartesianToCompressed.end()) ? -1 : ixPos->second;
};
// Recall: NNC::input() covers NNC keyword and numerical aquifers
// NNC::edit() covers EDITNNC keyword
// NNC::editr() covers EDITNNCR keyword
for (const auto& nncList : { &NNC::input, &NNC::edit, &NNC::editr }) {
// Apply region-based transmissibility multipliers (i.e., the MULTREGT
// keyword) to those transmissibilities that are directly assigned from
// the input.
//
// * NNC::input() covers the NNC keyword and any numerical aquifers
// * NNC::editr() covers the EDITNNCR keyword
//
// Note: We do not apply MULTREGT to the entries in NNC::edit() since
// those act as regular multipliers and have already been fully
// accounted for in the multiplier part of the main loop of update() and
// the applyEditNncToGridTrans_() member function.
for (const auto& nncList : { &NNC::input, &NNC::editr }) {
for (const auto& nncEntry : (inputNNC.*nncList)()) {
const auto c1 = nncEntry.cell1;
const auto c2 = nncEntry.cell2;