OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Apply the well residuals to cell residuals in SolveJacobianSystem

Browse Source 
This was moved to assemble() some time ago but according to my logic it
belongs in the solve method since this is only a trick to solve the well
equations simultaneously with the reservoir equations.

A buggy side effect of the currect implementation was that the well
residual was considered in the convergence test. I.e. this move changes
the convergence behaviour of the simulator.
This commit is contained in:
Tor Harald Sandve
2017-11-09 08:40:08 +01:00
parent a2a0d32e49
commit 5647485daa
1 changed files with 3 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
opm/autodiff/BlackoilModelEbos.hpp
View File

@@ -355,10 +355,6 @@ namespace Opm {
// assembles the well equations and applies the wells to // assembles the well equations and applies the wells to
// the reservoir equations as a source term. // the reservoir equations as a source term.
wellModel().assemble(iterationIdx, dt); wellModel().assemble(iterationIdx, dt);
// apply well residual to the residual.
auto& ebosResid = ebosSimulator_.model().linearizer().residual();
wellModel().apply(ebosResid);
} }
catch ( const Dune::FMatrixError& e ) catch ( const Dune::FMatrixError& e )
{ {
@@ -468,9 +464,9 @@ namespace Opm {
// The residual is modified similarly. // The residual is modified similarly.
// r = [r, r_well], where r is the residual and r_well the well residual. // r = [r, r_well], where r is the residual and r_well the well residual.
// r -= B^T * D^-1 r_well // r -= B^T * D^-1 r_well
// Note: Currently the residual is modified in the assembleMassBalanceEq call.
// It conceptually belongs here, but moving it changes the solution path for some // apply well residual to the residual.
// unknown reasons. wellModel().apply(ebosResid);
// set initial guess // set initial guess
x = 0.0; x = 0.0;