decoupe the rate and fraction relaxation

the relaxation for these two have different goals and problems, it is
wise to decuple them.
This commit is contained in:
Kai Bao
2018-11-08 13:37:17 +01:00
parent 179a505b83
commit 5e736fc4c7
2 changed files with 25 additions and 27 deletions

View File

@@ -358,13 +358,13 @@ namespace Opm
static double relaxationFactorFraction(const double old_value, static double relaxationFactorFraction(const double old_value,
const double dx); const double dx);
// calculate a relaxation factor to avoid overshoot // calculate a relaxation factor to avoid overshoot of the fractions for producers
// which might result in negative rates // which might result in negative rates
static double determineRelaxationFactorProducer(const std::vector<double>& primary_variables, static double relaxationFactorFractionsProducer(const std::vector<double>& primary_variables,
const BVectorWell& dwells); const BVectorWell& dwells);
// calculate a relaxation factor to avoid overshoot for injectors // calculate a relaxation factor to avoid overshoot of total rates
static double determineRelaxationFactorInjector(const std::vector<double>& primary_variables, static double relaxationFactorRate(const std::vector<double>& primary_variables,
const BVectorWell& dwells); const BVectorWell& dwells);
}; };

View File

@@ -870,34 +870,37 @@ namespace Opm
const std::vector<double> old_primary_variables = primary_variables_; const std::vector<double> old_primary_variables = primary_variables_;
const double relaxation_factor = (well_type_ == PRODUCER) ? // for injectors, very typical one of the fractions will be one, and it is easy to get zero value
determineRelaxationFactorProducer(old_primary_variables, dwells) // fractions. not sure what is the best way to handle it yet, so we just use 1.0 here
: determineRelaxationFactorInjector(old_primary_variables, dwells); const double relaxation_factor_fractions = (well_type_ == PRODUCER) ?
relaxationFactorFractionsProducer(old_primary_variables, dwells)
: 1.0;
// update the second and third well variable (The flux fractions) // update the second and third well variable (The flux fractions)
if (FluidSystem::phaseIsActive(FluidSystem::waterPhaseIdx)) { if (FluidSystem::phaseIsActive(FluidSystem::waterPhaseIdx)) {
const int sign2 = dwells[0][WFrac] > 0 ? 1: -1; const int sign2 = dwells[0][WFrac] > 0 ? 1: -1;
const double dx2_limited = sign2 * std::min(std::abs(dwells[0][WFrac] * relaxation_factor), dFLimit); const double dx2_limited = sign2 * std::min(std::abs(dwells[0][WFrac] * relaxation_factor_fractions), dFLimit);
// primary_variables_[WFrac] = old_primary_variables[WFrac] - dx2_limited; // primary_variables_[WFrac] = old_primary_variables[WFrac] - dx2_limited;
primary_variables_[WFrac] = old_primary_variables[WFrac] - dx2_limited; primary_variables_[WFrac] = old_primary_variables[WFrac] - dx2_limited;
} }
if (FluidSystem::phaseIsActive(FluidSystem::gasPhaseIdx)) { if (FluidSystem::phaseIsActive(FluidSystem::gasPhaseIdx)) {
const int sign3 = dwells[0][GFrac] > 0 ? 1: -1; const int sign3 = dwells[0][GFrac] > 0 ? 1: -1;
const double dx3_limited = sign3 * std::min(std::abs(dwells[0][GFrac] * relaxation_factor), dFLimit); const double dx3_limited = sign3 * std::min(std::abs(dwells[0][GFrac] * relaxation_factor_fractions), dFLimit);
primary_variables_[GFrac] = old_primary_variables[GFrac] - dx3_limited; primary_variables_[GFrac] = old_primary_variables[GFrac] - dx3_limited;
} }
if (has_solvent) { if (has_solvent) {
const int sign4 = dwells[0][SFrac] > 0 ? 1: -1; const int sign4 = dwells[0][SFrac] > 0 ? 1: -1;
const double dx4_limited = sign4 * std::min(std::abs(dwells[0][SFrac]) * relaxation_factor, dFLimit); const double dx4_limited = sign4 * std::min(std::abs(dwells[0][SFrac]) * relaxation_factor_fractions, dFLimit);
primary_variables_[SFrac] = old_primary_variables[SFrac] - dx4_limited; primary_variables_[SFrac] = old_primary_variables[SFrac] - dx4_limited;
} }
processFractions(); processFractions();
// updating the total rates G_t // updating the total rates Q_t
primary_variables_[WQTotal] = old_primary_variables[WQTotal] - dwells[0][WQTotal] * relaxation_factor; const double relaxation_factor_rate = relaxationFactorRate(old_primary_variables, dwells);
primary_variables_[WQTotal] = old_primary_variables[WQTotal] - dwells[0][WQTotal] * relaxation_factor_rate;
// updating the bottom hole pressure // updating the bottom hole pressure
{ {
@@ -2224,6 +2227,7 @@ namespace Opm
template<typename TypeTag> template<typename TypeTag>
double double
StandardWell<TypeTag>:: StandardWell<TypeTag>::
@@ -2258,7 +2262,7 @@ namespace Opm
template<typename TypeTag> template<typename TypeTag>
double double
StandardWell<TypeTag>:: StandardWell<TypeTag>::
determineRelaxationFactorProducer(const std::vector<double>& primary_variables, relaxationFactorFractionsProducer(const std::vector<double>& primary_variables,
const BVectorWell& dwells) const BVectorWell& dwells)
{ {
// TODO: not considering solvent yet // TODO: not considering solvent yet
@@ -2290,17 +2294,7 @@ namespace Opm
} }
} }
// relaxation factor for the total rates assert(relaxation_factor >= 0.0 && relaxation_factor <= 1.0);
{
const double original_total_rate = primary_variables[WQTotal];
const double relaxed_update = dwells[0][WQTotal] * relaxation_factor;
const double possible_update_total_rate = primary_variables[WQTotal] - relaxed_update;
if (original_total_rate * possible_update_total_rate < 0.) { // sign changed
const double further_relaxation_factor = std::abs(original_total_rate / relaxed_update) * 0.95;
relaxation_factor *= further_relaxation_factor;
}
}
return relaxation_factor; return relaxation_factor;
} }
@@ -2312,7 +2306,7 @@ namespace Opm
template<typename TypeTag> template<typename TypeTag>
double double
StandardWell<TypeTag>:: StandardWell<TypeTag>::
determineRelaxationFactorInjector(const std::vector<double>& primary_variables, relaxationFactorRate(const std::vector<double>& primary_variables,
const BVectorWell& dwells) const BVectorWell& dwells)
{ {
double relaxation_factor = 1.0; double relaxation_factor = 1.0;
@@ -2323,10 +2317,14 @@ namespace Opm
const double possible_update_total_rate = primary_variables[WQTotal] - newton_update; const double possible_update_total_rate = primary_variables[WQTotal] - newton_update;
// 0.8 here is a experimental value, which remains to be optimized // 0.8 here is a experimental value, which remains to be optimized
// if the original rate is zero or possible_update_total_rate is zero, relaxation_factor will
// always be 1.0, more thoughts might be needed.
if (original_total_rate * possible_update_total_rate < 0.) { // sign changed if (original_total_rate * possible_update_total_rate < 0.) { // sign changed
relaxation_factor = std::abs(original_total_rate / newton_update) * 0.8; relaxation_factor = std::abs(original_total_rate / newton_update) * 0.8;
} }
assert(relaxation_factor >= 0.0 && relaxation_factor <= 1.0);
return relaxation_factor; return relaxation_factor;
} }
} }