Merge pull request #5355 from multitalentloes/famg_warning_fix

Resolve warning delete-abstract-non-virtual-dtor
This commit is contained in:
Arne Morten Kvarving 2024-05-15 11:00:34 +02:00 committed by GitHub
commit 60defa4fd8
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194

View File

@ -91,6 +91,7 @@ struct GeneralPreconditionerMaker {
virtual std::unique_ptr< virtual std::unique_ptr<
Preconditioner<typename OriginalPreconditioner::domain_type, typename OriginalPreconditioner::range_type>> Preconditioner<typename OriginalPreconditioner::domain_type, typename OriginalPreconditioner::range_type>>
make() = 0; make() = 0;
virtual ~GeneralPreconditionerMaker(){};
}; };
/// @brief Struct implementing a make function which creates a preconditioner /// @brief Struct implementing a make function which creates a preconditioner
@ -114,6 +115,7 @@ struct PreconditionerMaker : public GeneralPreconditionerMaker<OriginalPrecondit
return std::make_unique<OriginalPreconditioner>(std::forward<Args>(args)...); return std::make_unique<OriginalPreconditioner>(std::forward<Args>(args)...);
}, args_); }, args_);
} }
~PreconditionerMaker(){}
std::tuple<Args...> args_; std::tuple<Args...> args_;
}; };