From 0660b62d297de79c16dd5ebd3a62ba999ff4e15b Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=C3=A5rd=20Skaflestad?= Date: Fri, 24 Jan 2025 10:05:25 +0100 Subject: [PATCH 1/2] Add Restart Test for ZUDL Character Limit Uses the example model from PR OPM/opm-tests#1279 in which the defining expression of one UDQ is exactly 128 characters long. This expression will overflow the character limit if we insert any new characters like blanks or quotes. --- restartTests.cmake | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/restartTests.cmake b/restartTests.cmake index a3dcdf567..f7458bba5 100644 --- a/restartTests.cmake +++ b/restartTests.cmake @@ -92,6 +92,19 @@ add_test_compare_restarted_simulation(CASENAME network_01_reroute_restart DIR network TEST_ARGS --enable-tuning=true --local-well-solve-control-switching=true) +# Restart run in which a UDQ defining expression has exactly 128 +# characters. Verifies that we don't overflow the ZUDL character +# limit in restart files. +add_test_compare_restarted_simulation(CASENAME udq_reg_02 + FILENAME UDQ_REG-02 + SIMULATOR flow + ABS_TOL ${abs_tol_restart} + REL_TOL ${rel_tol_restart} + RESTART_STEP 2 + DIR udq_actionx + TEST_ARGS --enable-tuning=true +) + # The dynamic MSW data is not written to /read from the restart file # We therefore accept significant deviation in the results. # Note also that we use --sched-restart=true since some necessary From f0c62ff223d0c37036bda21584b85b2988ce4065 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?B=C3=A5rd=20Skaflestad?= Date: Fri, 24 Jan 2025 11:06:30 +0100 Subject: [PATCH 2/2] Add Regression Test for Group Level UDQ Assignments Uses the example model UDQ_GRP-01 from PR OPM/opm-tests#1174. --- regressionTests.cmake | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/regressionTests.cmake b/regressionTests.cmake index 75e9a4575..63fe7e952 100644 --- a/regressionTests.cmake +++ b/regressionTests.cmake @@ -631,6 +631,16 @@ add_test_compareECLFiles(CASENAME reg_smry_in_fld_udq DIR udq_actionx TEST_ARGS --enable-tuning=true) +# UDQ ASSIGN for subsets of group level UDQs. Updates triggered from +# ACTIONX blocks. +add_test_compareECLFiles(CASENAME group_udq + FILENAME UDQ_GRP-01 + SIMULATOR flow + ABS_TOL ${abs_tol} + REL_TOL ${rel_tol} + DIR udq_actionx + TEST_ARGS --solver-max-time-step-in-days=0.25) + add_test_compareECLFiles(CASENAME udq_undefined_2 FILENAME UDQ-01 SIMULATOR flow