OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Avoid potential segfault due to invalid vector.end() after erase()

Browse Source
This commit is contained in:
Vegard Kippe 2024-11-15 13:52:14 +01:00
parent 3188ac713a
commit 7ece35defe
1 changed files with 8 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
opm/simulators/wells/GasLiftStage2.cpp
View File

@ -504,11 +504,14 @@ recalculateGradientAndUpdateData_(GradPairItr& grad_itr,
updateGradVector_(name, other_grads, grad->grad);
}
else {
for (auto it = other_grads.begin(); it != other_grads.end(); it++) {
if (it->first == name) {
other_grads.erase(it);
deleteGrad_(name, !increase);
}
auto new_end = std::remove_if(other_grads.begin(), other_grads.end(), [&name](const GradPair& pair)
{
return (name==pair.first);
}
);
if (new_end != other_grads.end()) {
this->deleteGrad_(name, !increase);
other_grads.erase(new_end, other_grads.end());
}
}
}