OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Use Rank's Local Cells for Tracer Concentration Restart

Browse Source 
The 'globalIdx' generated by localIdxToGlobalIdx() is in the range
zero to number of active cells in global model, not zero to number
of active cells on rank.  Using 'globalIdx' as an argument to
set*TracerConcentration() therefore ends up indexing out-of-bounds
for the internal arrays in the tracer model object in parallel
restarted simulation runs.

The problem has been present since the restart support for tracers
was added in commit e9c45f4ca (PR #3708).

This commit switches to using the 'elemIdx' instead, as we already
do when calling the output module's setRestart() member function.
Following this, we are able to restart the standard Norne benchmark
case (NORNE_ATW2013.DATA) in parallel.  The numerical results for
the tracer concentrations are, however, a little questionable and
will warrant further investigation.  Nevertheless, the tracer values
are now the same in a parallel restarted run as in a sequential
restarted run.
This commit is contained in:
Bård Skaflestad 2024-10-11 18:05:48 +02:00
parent 822538cc65
commit 7ee7010d5f
1 changed files with 5 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
opm/simulators/flow/EclWriter.hpp
View File

@ -583,8 +583,8 @@ public:
for (auto elemIdx = 0*numElements; elemIdx < numElements; ++elemIdx) {
const auto globalIdx = this->collectOnIORank_.localIdxToGlobalIdx(elemIdx);
tracer_model.setFreeTracerConcentration(tracer_index, globalIdx,
free_tracer_solution[globalIdx]);
tracer_model.setFreeTracerConcentration
(tracer_index, elemIdx, free_tracer_solution[globalIdx]);
}
}
@ -600,16 +600,15 @@ public:
for (auto elemIdx = 0*numElements; elemIdx < numElements; ++elemIdx) {
const auto globalIdx = this->collectOnIORank_.localIdxToGlobalIdx(elemIdx);
tracer_model.setSolTracerConcentration(tracer_index, globalIdx,
sol_tracer_solution[globalIdx]);
tracer_model.setSolTracerConcentration
(tracer_index, elemIdx, sol_tracer_solution[globalIdx]);
}
}
else {
tracer_model.setEnableSolTracers(tracer_index, false);
for (auto elemIdx = 0*numElements; elemIdx < numElements; ++elemIdx) {
const auto globalIdx = this->collectOnIORank_.localIdxToGlobalIdx(elemIdx);
tracer_model.setSolTracerConcentration(tracer_index, globalIdx, 0.0);
tracer_model.setSolTracerConcentration(tracer_index, elemIdx, 0.0);
}
}
}