OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2024-11-22 09:16:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #922 from atgeirr/from_char-workaround

Browse Source 
Add workaround for libc++ incomplete from_chars().
This commit is contained in:
Bård Skaflestad 2024-08-12 18:38:22 +02:00 committed by GitHub
commit 8d382f7dcb
1 changed files with 12 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
opm/models/utils/parametersystem.hh
View File

@ -41,6 +41,7 @@
#include <dune/common/classname.hh> #include <dune/common/classname.hh>
#include <dune/common/parametertree.hh> #include <dune/common/parametertree.hh>
#include <cstdlib>
#include <charconv> #include <charconv>
#include <fstream> #include <fstream>
#include <iostream> #include <iostream>
@ -924,7 +925,18 @@ auto Get(bool errorIfNotRegistered)
defaultValue = defVal == "1"; defaultValue = defVal == "1";
} }
else { else {
#ifdef _LIBCPP_VERSION // If this macro is defined, clang's libc++ is used
// For floating point types, libc++ (the llvm/clang library implementation)
// does not yet (as of clang 15) offer an implementation of std::from_chars().
if constexpr (std::is_integral_v<ParamType>) {
std::from_chars(defVal.data(), defVal.data() + defVal.size(), defaultValue);
} else {
// Floating point workaround.
defaultValue = std::strtod(defVal.c_str(), nullptr);
}
#else
std::from_chars(defVal.data(), defVal.data() + defVal.size(), defaultValue); std::from_chars(defVal.data(), defVal.data() + defVal.size(), defaultValue);
#endif
} }
// prefix the parameter name by the model's GroupName. E.g. If // prefix the parameter name by the model's GroupName. E.g. If