OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

adding comments about function calculateBhpFromThp.

Browse Source
This commit is contained in:
Kai Bao 2017-08-14 14:11:58 +02:00
parent 277d26df8a
commit a29be796e7
3 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
opm/autodiff/StandardWell_impl.hpp
View File

@ -1974,6 +1974,12 @@ namespace Opm
calculateBhpFromThp(const std::vector<ValueType>& rates, calculateBhpFromThp(const std::vector<ValueType>& rates,
const int control_index) const const int control_index) const
{ {
// TODO: when well is under THP control, the BHP is dependent on the rates,
// the well rates is also dependent on the BHP, so it might need to do some iteration.
// However, when group control is involved, change of the rates might impacts other wells
// so iterations on a higher level will be required. Some investigation might be needed when
// we face problems under THP control.
assert(int(rates.size()) == 3); // the vfp related only supports three phases now. assert(int(rates.size()) == 3); // the vfp related only supports three phases now.
const ValueType aqua = rates[Water]; const ValueType aqua = rates[Water];

10
opm/autodiff/StandardWellsDense.hpp
View File

@ -150,11 +150,6 @@ namespace Opm {
const WellState& well_state, const WellState& well_state,
DynamicListEconLimited& list_econ_limited) const; DynamicListEconLimited& list_econ_limited) const;
// TODO: some preparation work, mostly related to group control and RESV,
// at the beginning of each time step (Not report step)
void prepareTimeStep(const Simulator& ebos_simulator,
WellState& well_state);
WellCollection* wellCollection() const; WellCollection* wellCollection() const;
@ -266,6 +261,11 @@ namespace Opm {
const double dt, const double dt,
WellState& well_state, WellState& well_state,
bool only_wells) const; bool only_wells) const;
// some preparation work, mostly related to group control and RESV,
// at the beginning of each time step (Not report step)
void prepareTimeStep(const Simulator& ebos_simulator,
WellState& well_state);
}; };

1
opm/autodiff/StandardWellsDense_impl.hpp
View File

@ -643,7 +643,6 @@ namespace Opm {
if (well_collection_->requireWellPotentials()) { if (well_collection_->requireWellPotentials()) {
// calculate the well potentials // calculate the well potentials
// TODO: for the purpose of group control, not tested yet
setWellSolutions(well_state); setWellSolutions(well_state);
setWellVariables(); setWellVariables();
computeWellConnectionPressures(ebos_simulator, well_state); computeWellConnectionPressures(ebos_simulator, well_state);