bugfix: Detect exception during beginReportStep in parallel a. abort

Previously, exceptions happening at this stage have deadlocked
flow. E.g.  UniformTabulated2DFunction in opm-material throws
a NumericalIssue if the values passed are outside the tabulated
reason. This function is e.g. called in 2-phase CO2-storage cases
during BlackoilModel::initializeWellState

BTW: This is only the first step as it is not very user friendly that
a simulation aborts at this (late) stage.

opm/simulators/utils/DeferredLogger.hpp

@@ -46,6 +46,7 @@ enum ExcEnum {
     INVALID_ARGUMENT = 2,
     LOGIC_ERROR = 3,
     DEFAULT = 4,   // will throw std::logic_error()
+    NUMERICAL_ISSUE = 5
 };
 }
 

opm/simulators/utils/DeferredLoggingErrorHelpers.hpp

@@ -23,6 +23,8 @@
 
 #include <opm/simulators/utils/DeferredLogger.hpp>
 
+#include <opm/material/common/Exceptions.hpp>
+
 #include <dune/common/version.hh>
 #include <dune/common/parallel/mpihelper.hh>
 
@@ -64,6 +66,9 @@ void _throw(Opm::ExceptionType::ExcEnum exc_type, const std::string& message) {
     case Opm::ExceptionType::INVALID_ARGUMENT:
         throw std::invalid_argument(message);
         break;
+    case Opm::ExceptionType::NUMERICAL_ISSUE:
+        throw Opm::NumericalIssue(message);
+        break;
     case Opm::ExceptionType::DEFAULT:
     case Opm::ExceptionType::LOGIC_ERROR:
         throw std::logic_error(message);

opm/simulators/wells/BlackoilWellModel_impl.hpp

@@ -176,6 +176,9 @@ namespace Opm {
     beginReportStep(const int timeStepIdx)
     {
         DeferredLogger local_deferredLogger;
+
+        std::string exc_msg;
+        auto exc_type = ExceptionType::NONE;
         report_step_starts_ = true;
 
         const Grid& grid = ebosSimulator_.vanguard().grid();
@@ -184,6 +187,12 @@ namespace Opm {
         wells_ecl_ = getLocalWells(timeStepIdx);
         local_parallel_well_info_ = createLocalParallelWellInfo(wells_ecl_);
 
+        // at least initializeWellState might be throw
+        // exception in opm-material (UniformTabulated2DFunction.hpp)
+        // playing it safe by extending the scope a bit.
+        try
+        {
+
             // The well state initialize bhp with the cell pressure in the top cell.
             // We must therefore provide it with updated cell pressures
             this->initializeWellPerfData();
@@ -203,7 +212,8 @@ namespace Opm {
             WellGroupHelpers::setCmodeGroup(fieldGroup, schedule(), summaryState, timeStepIdx, this->wellState(), this->groupState());
 
             // Compute reservoir volumes for RESV controls.
-        rateConverter_.reset(new RateConverterType (phase_usage_, std::vector<int>(local_num_cells_, 0)));
+            rateConverter_.reset(new RateConverterType (phase_usage_,
+                                                        std::vector<int>(local_num_cells_, 0)));
             rateConverter_->template defineState<ElementContext>(ebosSimulator_);
 
             // Compute regional average pressures used by gpmaint
@@ -223,7 +233,25 @@ namespace Opm {
                     this->runWellPIScaling(timeStepIdx, local_deferredLogger);
                 }
             }
+        }
+        catch (const Opm::NumericalIssue& e){
+            exc_type = ExceptionType::NUMERICAL_ISSUE;
+            exc_msg = e.what();
+        } catch (const std::runtime_error& e) {
+            exc_type = ExceptionType::RUNTIME_ERROR;
+            exc_msg = e.what();
+        } catch (const std::invalid_argument& e) {
+            exc_type = ExceptionType::INVALID_ARGUMENT;
+            exc_msg = e.what();
+        } catch (const std::logic_error& e) {
+            exc_type = ExceptionType::LOGIC_ERROR;
+            exc_msg = e.what();
+        } catch (const std::exception& e) {
+            exc_type = ExceptionType::DEFAULT;
+            exc_msg = e.what();
+        }
         
+        logAndCheckForExceptionsAndThrow(local_deferredLogger, exc_type, "beginReportStep() failed: " + exc_msg, terminal_output_);
         // Store the current well state, to be able to recover in the case of failed iterations
         this->commitWGState();
     }