OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Bugfix, again: it was correct to take the maximum, reinstating.

Browse Source 
There is a different problem that needs fixing, however:
Flux inaccuracies (for example on boundaries) may tag some
face as inflow face for a cell, even if it should have been
no-flow. This may let the cell avoid limiting, even though it
should have been limited according to the proper inflow faces.
This commit is contained in:
Atgeirr Flø Rasmussen 2013-01-07 15:10:43 +01:00
parent 583c905a43
commit bfa52cc5f2
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
opm/core/transport/reorder/TransportModelTracerTofDiscGal.cpp
View File

@ -404,7 +404,8 @@ namespace Opm
const int dim = grid_.dimensions; const int dim = grid_.dimensions;
const int num_basis = DGBasis::numBasisFunc(dim, degree_); const int num_basis = DGBasis::numBasisFunc(dim, degree_);
double max_slope_mult = 1e100; // double max_slope_mult = 1e100;
double max_slope_mult = 0.0;
int num_upstream_faces = 0; int num_upstream_faces = 0;
// For inflow faces, ensure that cell tof does not dip below // For inflow faces, ensure that cell tof does not dip below
// the minimum value from upstream (for all faces). // the minimum value from upstream (for all faces).
@ -453,7 +454,8 @@ namespace Opm
break; break;
} }
const double face_mult = (tof_c - min_upstream)/(tof_c - min_here); const double face_mult = (tof_c - min_upstream)/(tof_c - min_here);
max_slope_mult = std::min(max_slope_mult, face_mult); // max_slope_mult = std::min(max_slope_mult, face_mult);
max_slope_mult = std::max(max_slope_mult, face_mult);
} }
ASSERT(max_slope_mult >= 0.0); ASSERT(max_slope_mult >= 0.0);