From c219585cf80fcac1b4e5df48bfe8bb6187df757d Mon Sep 17 00:00:00 2001 From: Andreas Lauser Date: Thu, 8 May 2014 16:53:53 +0200 Subject: [PATCH] 1p/2p fluid systems: rename them to more sensfull class names they were totally inconsistent with the remaining fluid systems because their file names stated with a number and "P" was used instead of "Phase"... --- ...FluidSystem.hpp => SinglePhaseFluidSystem.hpp} | 15 +++++++-------- ...stem.hpp => TwoPhaseImmiscibleFluidSystem.hpp} | 14 +++++++------- tests/checkFluidSystem.hpp | 4 ++-- tests/test_fluidmatrixinteractions.cpp | 4 ++-- tests/test_fluidsystems.cpp | 14 +++++++------- 5 files changed, 25 insertions(+), 26 deletions(-) rename opm/material/fluidsystems/{1pFluidSystem.hpp => SinglePhaseFluidSystem.hpp} (96%) rename opm/material/fluidsystems/{2pImmiscibleFluidSystem.hpp => TwoPhaseImmiscibleFluidSystem.hpp} (96%) diff --git a/opm/material/fluidsystems/1pFluidSystem.hpp b/opm/material/fluidsystems/SinglePhaseFluidSystem.hpp similarity index 96% rename from opm/material/fluidsystems/1pFluidSystem.hpp rename to opm/material/fluidsystems/SinglePhaseFluidSystem.hpp index 861477f60..2bb806176 100644 --- a/opm/material/fluidsystems/1pFluidSystem.hpp +++ b/opm/material/fluidsystems/SinglePhaseFluidSystem.hpp @@ -19,10 +19,10 @@ */ /*! * \file - * \copydoc Opm::FluidSystems::OneP + * \copydoc Opm::FluidSystems::SinglePhase */ -#ifndef OPM_1P_FLUIDSYSTEM_HPP -#define OPM_1P_FLUIDSYSTEM_HPP +#ifndef OPM_SINGLE_PHASE_FLUIDSYSTEM_HPP +#define OPM_SINGLE_PHASE_FLUIDSYSTEM_HPP #include "BaseFluidSystem.hpp" #include "NullParameterCache.hpp" @@ -50,10 +50,10 @@ namespace FluidSystems { * Opm::GasPhase may be used. */ template -class OneP - : public BaseFluidSystem > +class SinglePhase + : public BaseFluidSystem > { - typedef OneP ThisType; + typedef SinglePhase ThisType; typedef BaseFluidSystem Base; public: @@ -262,7 +262,6 @@ public: } }; -} // namespace FluidSystems -} // namespace Opm +}} // namespace Opm, FluidSystems #endif diff --git a/opm/material/fluidsystems/2pImmiscibleFluidSystem.hpp b/opm/material/fluidsystems/TwoPhaseImmiscibleFluidSystem.hpp similarity index 96% rename from opm/material/fluidsystems/2pImmiscibleFluidSystem.hpp rename to opm/material/fluidsystems/TwoPhaseImmiscibleFluidSystem.hpp index a54cfbd39..bc331e168 100644 --- a/opm/material/fluidsystems/2pImmiscibleFluidSystem.hpp +++ b/opm/material/fluidsystems/TwoPhaseImmiscibleFluidSystem.hpp @@ -19,10 +19,10 @@ */ /*! * \file - * \copydoc Opm::FluidSystems::TwoPImmiscible + * \copydoc Opm::FluidSystems::TwoPhaseImmiscible */ -#ifndef OPM_2P_IMMISCIBLE_FLUID_SYSTEM_HPP -#define OPM_2P_IMMISCIBLE_FLUID_SYSTEM_HPP +#ifndef OPM_TWO_PHASE_IMMISCIBLE_FLUID_SYSTEM_HPP +#define OPM_TWO_PHASE_IMMISCIBLE_FLUID_SYSTEM_HPP #include #include @@ -51,14 +51,14 @@ namespace FluidSystems { * systems without compositional effects. */ template -class TwoPImmiscible -: public BaseFluidSystem > +class TwoPhaseImmiscible +: public BaseFluidSystem > { // do not try to instanciate this class, it has only static members! - TwoPImmiscible() + TwoPhaseImmiscible() {} - typedef TwoPImmiscible ThisType; + typedef TwoPhaseImmiscible ThisType; typedef BaseFluidSystem Base; public: //! \copydoc BaseFluidSystem::ParameterCache diff --git a/tests/checkFluidSystem.hpp b/tests/checkFluidSystem.hpp index 6ca56721b..b98bb1db9 100644 --- a/tests/checkFluidSystem.hpp +++ b/tests/checkFluidSystem.hpp @@ -24,8 +24,8 @@ #define OPM_CHECK_FLUIDSYSTEM_HPP // include all fluid systems in opm-material -#include -#include +#include +#include #include #include #include diff --git a/tests/test_fluidmatrixinteractions.cpp b/tests/test_fluidmatrixinteractions.cpp index 6da9c52d0..bc4709386 100644 --- a/tests/test_fluidmatrixinteractions.cpp +++ b/tests/test_fluidmatrixinteractions.cpp @@ -46,7 +46,7 @@ #include // include some fluid systems -#include +#include #include // include some components @@ -252,7 +252,7 @@ int main(int argc, char **argv) typedef Opm::LiquidPhase Liquid; typedef Opm::GasPhase Gas; - typedef Opm::FluidSystems::TwoPImmiscible TwoPFluidSystem; + typedef Opm::FluidSystems::TwoPhaseImmiscible TwoPFluidSystem; typedef Opm::FluidSystems::BlackOil ThreePFluidSystem; typedef Opm::TwoPhaseMaterialTraits -#include +#include +#include #include #include #include @@ -172,20 +172,20 @@ int main(int argc, char **argv) checkFluidSystem(); } // 2p-immiscible - { typedef Opm::FluidSystems::TwoPImmiscible FluidSystem; + { typedef Opm::FluidSystems::TwoPhaseImmiscible FluidSystem; checkFluidSystem(); } - { typedef Opm::FluidSystems::TwoPImmiscible FluidSystem; + { typedef Opm::FluidSystems::TwoPhaseImmiscible FluidSystem; checkFluidSystem(); } - { typedef Opm::FluidSystems::TwoPImmiscible FluidSystem; + { typedef Opm::FluidSystems::TwoPhaseImmiscible FluidSystem; checkFluidSystem(); } // 1p - { typedef Opm::FluidSystems::OneP FluidSystem; + { typedef Opm::FluidSystems::SinglePhase FluidSystem; checkFluidSystem(); } - { typedef Opm::FluidSystems::OneP FluidSystem; + { typedef Opm::FluidSystems::SinglePhase FluidSystem; checkFluidSystem(); } return 0;