From d2a2d5074d3bf04962647b3c018be5a0222c2d78 Mon Sep 17 00:00:00 2001
From: Markus Blatt <markus@dr-blatt.de>
Date: Mon, 7 Sep 2020 16:54:14 +0200
Subject: [PATCH] Rely on insideCartElemIdx<outsideCartElemIdx in
 allpyAllZMultipliers_

and simpily code under that assumption.
---
 ebos/ecltransmissibility.hh | 13 ++++++-------
 1 file changed, 6 insertions(+), 7 deletions(-)

diff --git a/ebos/ecltransmissibility.hh b/ebos/ecltransmissibility.hh
index 374434c4f..4ea6d6093 100644
--- a/ebos/ecltransmissibility.hh
+++ b/ebos/ecltransmissibility.hh
@@ -475,14 +475,13 @@ private:
         if (insideFaceIdx > 3) { // top or or bottom
             Scalar mult = 1e20;
             unsigned cartElemIdx = insideCartElemIdx;
-            // pick the smallest multiplier while looking down the pillar untill reaching the other end of the connection
-            // for the inbetween cells we apply it from both sides
+            assert(insideFaceIdx==5); // as insideCartElemIdx < outsideCartElemIdx holds for the Z column
+            // pick the smallest multiplier for Z+ while looking down the pillar untill reaching the other end of the connection
+            // While Z- is not all used here. There is a call after this function that does
+            // applyMultipliers_(trans, outsideFaceIdx, outsideCartElemIdx, transMult)
+            // and hence treats the other direction
             while (cartElemIdx != outsideCartElemIdx) {
-                if (insideFaceIdx == 4 || cartElemIdx !=insideCartElemIdx )
-                    mult = std::min(mult, transMult.getMultiplier(cartElemIdx, Opm::FaceDir::ZMinus));
-                if (insideFaceIdx == 5 || cartElemIdx !=insideCartElemIdx)
-                    mult = std::min(mult, transMult.getMultiplier(cartElemIdx, Opm::FaceDir::ZPlus));
-
+                mult = std::min(mult, transMult.getMultiplier(cartElemIdx, Opm::FaceDir::ZPlus));
                 cartElemIdx += cartDims[0]*cartDims[1];
             }
             trans *= mult;