From edbf224e940cae982a42751907ed77699490bede Mon Sep 17 00:00:00 2001
From: Tobias Meyer Andersen <tobiasmeyer.andersen@sintef.no>
Date: Fri, 30 May 2025 07:58:20 +0200
Subject: [PATCH] resolve copilot feedback

---
 opm/simulators/linalg/gpuistl/GpuDILU.cpp                     | 2 +-
 .../preconditionerKernels/ILU_variants_helper_kernels.cu      | 4 ++--
 .../preconditionerKernels/ILU_variants_helper_kernels.hpp     | 4 ++--
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/opm/simulators/linalg/gpuistl/GpuDILU.cpp b/opm/simulators/linalg/gpuistl/GpuDILU.cpp
index 3cc141787e..cb114d8681 100644
--- a/opm/simulators/linalg/gpuistl/GpuDILU.cpp
+++ b/opm/simulators/linalg/gpuistl/GpuDILU.cpp
@@ -108,7 +108,7 @@ GpuDILU<M, X, Y, l>::GpuDILU(const typename GpuDILU<M, X, Y, l>::GPUMatrix& gpuM
         }
     }
 
-    // Precompute diagaon indices and handle the actual reordering if that is enabled.
+    // Precompute diagaonal block element indices and handle the actual reordering if that is enabled.
     if (m_reorder) {
         detail::computeDiagIndices<field_type>(m_gpuMatrixReordered->getNonZeroValues().data(),
                                                m_gpuMatrixReordered->getRowIndices().data(),
diff --git a/opm/simulators/linalg/gpuistl/detail/preconditionerKernels/ILU_variants_helper_kernels.cu b/opm/simulators/linalg/gpuistl/detail/preconditionerKernels/ILU_variants_helper_kernels.cu
index dc53ddd471..2087f719cc 100644
--- a/opm/simulators/linalg/gpuistl/detail/preconditionerKernels/ILU_variants_helper_kernels.cu
+++ b/opm/simulators/linalg/gpuistl/detail/preconditionerKernels/ILU_variants_helper_kernels.cu
@@ -99,7 +99,7 @@ computeDiagIndicesNoReorder(const T* mat,
 
     // launch kernel
     cuComputeDiagIndicesNoReorder<T>
-        <<<threadBlockSize, nThreadBlocks>>>(mat, rowIndices, colIndices, indexConversion, rows, diagIndices);
+        <<<nThreadBlocks, threadBlockSize>>>(mat, rowIndices, colIndices, indexConversion, rows, diagIndices);
 }
 
 template <class T>
@@ -119,7 +119,7 @@ computeDiagIndices(const T* mat,
 
     // launch kernel
     cuComputeDiagIndices<T>
-        <<<threadBlockSize, nThreadBlocks>>>(mat, rowIndices, colIndices, reorderedToNatural, rows, diagIndices);
+        <<<nThreadBlocks, threadBlockSize>>>(mat, rowIndices, colIndices, reorderedToNatural, rows, diagIndices);
 }
 
 
diff --git a/opm/simulators/linalg/gpuistl/detail/preconditionerKernels/ILU_variants_helper_kernels.hpp b/opm/simulators/linalg/gpuistl/detail/preconditionerKernels/ILU_variants_helper_kernels.hpp
index 0a3aa417a7..1f37217e76 100644
--- a/opm/simulators/linalg/gpuistl/detail/preconditionerKernels/ILU_variants_helper_kernels.hpp
+++ b/opm/simulators/linalg/gpuistl/detail/preconditionerKernels/ILU_variants_helper_kernels.hpp
@@ -33,7 +33,7 @@ namespace Opm::gpuistl::detail
   not recomputing indices during each update kernel.
 */
 /**
- * @brief Computes indices of diagonal elements for reordered GPU preconditioner.
+ * @brief Computes indices of diagonal elements for non-reordered GPU preconditioner.
  *
  * @tparam T Matrix element type
  * @param[in] mat The matrix in BCSR format
@@ -52,7 +52,7 @@ void computeDiagIndicesNoReorder(const T* mat,
                                  size_t* diagIndices);
 
 /**
- * @brief Computes indices of diagonal elements for non-reordered GPU preconditioner.
+ * @brief Computes indices of diagonal elements for reordered GPU preconditioner.
  *
  * @tparam T Matrix element type
  * @param[in] mat The matrix in BCSR format