From 17117e7a0e94986253db3b3faab3bc78c6c9d0fe Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Atgeirr=20Fl=C3=B8=20Rasmussen?= Date: Thu, 5 Mar 2015 16:07:04 +0100 Subject: [PATCH] Avoid storing return value in reference. Normally this is OK for by-value returns, but here the right hand side was changed to call ADB::value(), which returns by reference. --- opm/autodiff/RateConverter.hpp | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/opm/autodiff/RateConverter.hpp b/opm/autodiff/RateConverter.hpp index 12caeca92..33aae0dec 100644 --- a/opm/autodiff/RateConverter.hpp +++ b/opm/autodiff/RateConverter.hpp @@ -342,7 +342,7 @@ namespace Opm { if (Details::PhaseUsed::water(pu)) { // q[w]_r = q[w]_s / bw - const V& bw = props_.bWat(ADB::constant(p), ADB::constant(T), c).value(); + const V bw = props_.bWat(ADB::constant(p), ADB::constant(T), c).value(); coeff[iw] = 1.0 / bw(0); } @@ -355,7 +355,7 @@ namespace Opm { if (Details::PhaseUsed::oil(pu)) { // q[o]_r = 1/(bo * (1 - rs*rv)) * (q[o]_s - rv*q[g]_s) - const V& bo = props_.bOil(ADB::constant(p), ADB::constant(T), ADB::constant(m.rs), m.cond, c).value(); + const V bo = props_.bOil(ADB::constant(p), ADB::constant(T), ADB::constant(m.rs), m.cond, c).value(); const double den = bo(0) * detR; coeff[io] += 1.0 / den; @@ -368,7 +368,7 @@ namespace Opm { if (Details::PhaseUsed::gas(pu)) { // q[g]_r = 1/(bg * (1 - rs*rv)) * (q[g]_s - rs*q[o]_s) - const V& bg = props_.bGas(ADB::constant(p), ADB::constant(T), ADB::constant(m.rv), m.cond, c).value(); + const V bg = props_.bGas(ADB::constant(p), ADB::constant(T), ADB::constant(m.rv), m.cond, c).value(); const double den = bg(0) * detR; coeff[ig] += 1.0 / den;