OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

fixed: EnableDebuggingChecks is a property, not a parameter

Browse Source
This commit is contained in:
Arne Morten Kvarving 2024-08-14 14:05:43 +02:00
parent 9141f2c2d5
commit fdcc9a0fb2
4 changed files with 14 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
opm/simulators/flow/BlackoilModel.hpp
View File

@ -142,15 +142,11 @@ template<class TypeTag>
struct LinearSolverSplice<TypeTag, TTag::FlowProblem> struct LinearSolverSplice<TypeTag, TTag::FlowProblem>
{ using type = TTag::FlowIstlSolver; }; { using type = TTag::FlowIstlSolver; };
} // namespace Opm::Properties
namespace Opm::Parameters {
template<class TypeTag> template<class TypeTag>
struct EnableDebuggingChecks<TypeTag, Properties::TTag::FlowProblem> struct EnableDebuggingChecks<TypeTag, TTag::FlowProblem>
{ static constexpr bool value = false; }; { static constexpr bool value = false; };
} } // namespace Opm::Properties
namespace Opm { namespace Opm {

2
opm/simulators/flow/FlowProblem.hpp
View File

@ -679,7 +679,7 @@ public:
OPM_TIMEBLOCK(endTimeStep); OPM_TIMEBLOCK(endTimeStep);
#ifndef NDEBUG #ifndef NDEBUG
if constexpr (getPropValue<TypeTag, Parameters::EnableDebuggingChecks>()) { if constexpr (getPropValue<TypeTag, Properties::EnableDebuggingChecks>()) {
// in debug mode, we don't care about performance, so we check // in debug mode, we don't care about performance, so we check
// if the model does the right thing (i.e., the mass change // if the model does the right thing (i.e., the mass change
// inside the whole reservoir must be equivalent to the fluxes // inside the whole reservoir must be equivalent to the fluxes

6
opm/simulators/flow/FlowProblemParameters.hpp
View File

@ -32,12 +32,6 @@
namespace Opm::Parameters { namespace Opm::Parameters {
// Enable the additional checks even if compiled in debug mode (i.e., with the NDEBUG
// macro undefined). Next to a slightly better performance, this also eliminates some
// print statements in debug mode.
template<class TypeTag, class MyTypeTag>
struct EnableDebuggingChecks { using type = Properties::UndefinedProperty; };
// Enable partial compensation of systematic mass losses via the source term of the next time // Enable partial compensation of systematic mass losses via the source term of the next time
// step // step
template<class TypeTag, class MyTypeTag> template<class TypeTag, class MyTypeTag>

16
opm/simulators/flow/FlowProblemProperties.hpp
View File

@ -76,6 +76,12 @@ struct AquiferModel { using type = UndefinedProperty; };
template<class TypeTag, class MyTypeTag> template<class TypeTag, class MyTypeTag>
struct EnableApiTracking { using type = UndefinedProperty; }; struct EnableApiTracking { using type = UndefinedProperty; };
// Enable the additional checks even if compiled in debug mode (i.e., with the NDEBUG
// macro undefined). Next to a slightly better performance, this also eliminates some
// print statements in debug mode.
template<class TypeTag, class MyTypeTag>
struct EnableDebuggingChecks { using type = Properties::UndefinedProperty; };
// if thermal flux boundaries are enabled an effort is made to preserve the initial // if thermal flux boundaries are enabled an effort is made to preserve the initial
// thermal gradient specified via the TEMPVD keyword // thermal gradient specified via the TEMPVD keyword
template<class TypeTag, class MyTypeTag> template<class TypeTag, class MyTypeTag>
@ -264,6 +270,11 @@ template<class TypeTag>
struct EnableExperiments<TypeTag, TTag::FlowBaseProblem> struct EnableExperiments<TypeTag, TTag::FlowBaseProblem>
{ static constexpr bool value = false; }; { static constexpr bool value = false; };
// By default, we enable the debugging checks if we're compiled in debug mode
template<class TypeTag>
struct EnableDebuggingChecks<TypeTag, TTag::FlowBaseProblem>
{ static constexpr bool value = true; };
} // namespace Opm::Properties } // namespace Opm::Properties
namespace Opm::Parameters { namespace Opm::Parameters {
@ -278,11 +289,6 @@ template<class TypeTag>
struct EnableAsyncEclOutput<TypeTag, Properties::TTag::FlowBaseProblem> struct EnableAsyncEclOutput<TypeTag, Properties::TTag::FlowBaseProblem>
{ static constexpr bool value = true; }; { static constexpr bool value = true; };
// By default, we enable the debugging checks if we're compiled in debug mode
template<class TypeTag>
struct EnableDebuggingChecks<TypeTag, Properties::TTag::FlowBaseProblem>
{ static constexpr bool value = true; };
// Drift compensation is an experimental feature, i.e., systematic errors in the // Drift compensation is an experimental feature, i.e., systematic errors in the
// conservation quantities are only compensated for // conservation quantities are only compensated for
// as default if experimental mode is enabled. // as default if experimental mode is enabled.