OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity

Improve error message for input grid without any active cells.

Browse Source 
We now give a different (more explanatory) error if the input grid has
no active cells at all. Often this points to a user error and having a
more precise error message might help here.
This commit is contained in:
Markus Blatt 2023-06-30 17:17:54 +02:00
parent 007695e849
commit ff6a54ce7c
1 changed files with 22 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

34
opm/simulators/utils/readDeck.cpp
View File

@ -326,27 +326,39 @@ namespace {
} }
#endif #endif
bool gridHasValidCellGeometry(const Opm::EclipseGrid& inputGrid, std::pair<bool, std::string>
const Opm::UnitSystem& usys) gridHasValidCellGeometry(const Opm::EclipseGrid& inputGrid,
const Opm::UnitSystem& usys)
{ {
const auto numActive = inputGrid.getNumActive(); const auto numActive = inputGrid.getNumActive();
if (numActive == 0)
{
return {false, R"(Input grid has no active cells at all.
Please check geometry keywords and modifications to e.g. pore volume,
especially if grid is imported through GDFILE.)"};
}
for (auto activeCell = 0*numActive; activeCell < numActive; ++activeCell) { for (auto activeCell = 0*numActive; activeCell < numActive; ++activeCell) {
if (inputGrid.isValidCellGeomtry(inputGrid.getGlobalIndex(activeCell), usys)) { if (inputGrid.isValidCellGeomtry(inputGrid.getGlobalIndex(activeCell), usys)) {
return true; return {true, ""};
} }
} }
return false; return {false, R"(No active cell in input grid has valid/finite cell geometry
Please check geometry keywords and modifications to e.g. pore volume,
especially if the grid is imported through GDFILE.)"};
} }
bool gridHasValidCellGeometry(Opm::Parallel::Communication comm, std::pair<bool, std::string>
gridHasValidCellGeometry(Opm::Parallel::Communication comm,
const Opm::EclipseState& eclipseState) const Opm::EclipseState& eclipseState)
{ {
bool hasValidCells = false; bool hasValidCells = false;
std::string message;
if (comm.rank() == 0) { if (comm.rank() == 0) {
hasValidCells = std::tie(hasValidCells, message) =
gridHasValidCellGeometry(eclipseState.getInputGrid(), gridHasValidCellGeometry(eclipseState.getInputGrid(),
eclipseState.getDeckUnitSystem()); eclipseState.getDeckUnitSystem());
} }
@ -361,7 +373,7 @@ namespace {
} }
#endif // HAVE_MPI #endif // HAVE_MPI
return hasValidCells; return {hasValidCells, message};
} }
} }
@ -580,14 +592,12 @@ void Opm::readDeck(Opm::Parallel::Communication comm,
void Opm::verifyValidCellGeometry(Parallel::Communication comm, void Opm::verifyValidCellGeometry(Parallel::Communication comm,
const EclipseState& eclipseState) const EclipseState& eclipseState)
{ {
if (gridHasValidCellGeometry(comm, eclipseState)) { auto [hasValidCells, message] = gridHasValidCellGeometry(comm, eclipseState);
if (hasValidCells) {
return; return;
} }
throw std::invalid_argument { throw std::invalid_argument { message };
R"(No active cell in input grid has valid/finite cell geometry
Please check geometry keywords, especially if grid is imported through GDFILE)"
};
} }
std::unique_ptr<Opm::ParseContext> Opm::setupParseContext(const bool strictParsing) std::unique_ptr<Opm::ParseContext> Opm::setupParseContext(const bool strictParsing)