Arne Morten Kvarving
24777604ae
move gasOilPerfRateProd to RatioCalculator
2024-11-20 10:02:58 +01:00
Arne Morten Kvarving
c25853a871
move gasWaterPerfRateProd to RatioCalculator
2024-11-20 10:02:58 +01:00
Arne Morten Kvarving
f1ab605fbe
move gasWaterPerfRateInj to RatioCalculator
2024-11-20 10:02:58 +01:00
Arne Morten Kvarving
725b95a1ac
move disOilVapWatVolumeRatio to RatioCalculator
2024-11-20 10:02:58 +01:00
Arne Morten Kvarving
a2d5a505b3
added: RatioCalculator
...
will move some of the the ratio calculations from StandardWell into it.
start by moving gasOilVolumeRatio
2024-11-20 10:02:58 +01:00
Tor Harald Sandve
eb89a07831
Dont iterate when computing bhp from thp for computing of the well potentials for gaslift optimization
2024-11-06 14:06:09 +01:00
Atgeirr Flø Rasmussen
bf5f0c864d
Merge pull request #5605 from totto82/issue_stopped_wells
...
Fix issue with stopped injectors in thermal runs
2024-10-22 10:48:44 +02:00
jakobtorben
60bd3f5514
Remove unused num_cells argument from well equations
2024-10-10 20:26:13 +02:00
Atgeirr Flø Rasmussen
a7efc0091d
Merge pull request #5341 from jakobtorben/NLDD_remove_need_for_addWellContrib
...
Remove the need for add well contributions to matrix for NLDD
2024-10-10 16:23:52 +02:00
Vegard Kippe
a2882dc0c8
Resetting WINJMULT dampening factors before fixed BHP calculations
2024-10-10 09:25:28 +02:00
Vegard Kippe
ac5de96ad4
Add dampening to the injectivity multipliers (WINJMULT)
2024-10-08 15:49:10 +02:00
jakobtorben
60ece76adf
Make well equations use only perforated cells
2024-10-07 09:12:59 +02:00
Stein Krogstad
cb22d63cfe
In updateThp always compute thp when vfp is active
2024-09-26 21:06:05 +02:00
Tor Harald Sandve
ee4a6e0e39
WIP fix issue with stopped wells
2024-09-17 13:58:01 +02:00
Arne Morten Kvarving
3a5d527417
Merge pull request #5602 from totto82/fixBHPCO2
...
BUGFIX fix injection bhp pressure for CO2/H2 STORE
2024-09-13 15:48:17 +02:00
Tor Harald Sandve
50a4742c23
Merge pull request #5323 from vkip/energy_efficiency_factor
...
Apply well/group efficiency factors for connection energy rates.
2024-09-13 12:48:36 +02:00
Tor Harald Sandve
d13b4a3956
BUGFIX fix injection bhp pressure for CO2/H2 STORE
2024-09-13 09:17:37 +02:00
Tor Harald Sandve
9eaba103cc
Fix issue with stopped injectors in thermal runs
2024-09-13 08:51:52 +02:00
Bård Skaflestad
93c368cbfa
Revise Mixture Density Method for No-Flow Producers
...
This commit switches the approach introduced in commit eeb1b7e36#3169 ) to using a mobility weighted average of cell level densities
for the connection level mixture densities in no-flow producing
wells. We also use the recent stoppedOrZeroRateTarget() predicate
to identify those no-flow producing wells instead of inspecting the
connection flow rates.
The mobility weighted average gives a more monotone pressure buildup
for the stopped wells and this is usually what the engineer wants.
This revised approach furthermore needs fewer cell-level dynamic
properties so simplify the computeProperties() signature by
introducing a structure for the property callback functions and
update the callers accordingly.
2024-08-22 14:51:00 +02:00
Bård Skaflestad
586d8e2ddc
Generate Property Object Directly
...
This commit switches computePropertiesForPressures() to return a
Properties object directly instead of populating an object
constructed in the caller. There is just a single call site for
this function so there's no benefit to using an out parameter here.
While here, also collect the property callbacks into a structure to
simplify the function signature. This also enables not filling in
the solvent properties unless solvent is active in the run. Update
caller accordingly.
2024-08-22 14:51:00 +02:00
Bård Skaflestad
fa199461b5
Varnish Parts of Well Implementation
...
In particular
* Split some long lines
* Reverse conditions to reduce nesting
* Mark potentially unused arguments as [[maybe_unused]]
* Try to remove redundant calculations
* Mark some objets 'const' where possible
2024-08-22 14:51:00 +02:00
Tor Harald Sandve
f678c082de
Adapt to inj prefix and cleanup
2024-08-01 11:23:00 +02:00
Tor Harald Sandve
5f8916c0c3
Use cell temperature in perforated cell to compute reservoir rates
2024-08-01 11:14:29 +02:00
Stein Krogstad
fd199d2558
Rewrite to properly loop over components
2024-06-25 11:46:53 +02:00
Stein Krogstad
1efcd2c936
Fix potential for solvent + adjust perforation pressures
2024-06-25 11:46:53 +02:00
Stein Krogstad
427351cc12
Include checking for zero targets from groups where required
2024-05-23 14:55:37 +02:00
Stein Krogstad
2db90a92e7
include group controls for zero rate target checking
2024-05-23 14:44:26 +02:00
Arne Morten Kvarving
bac2087b85
WellProdIndexCalculator: template Scalar type
2024-05-22 15:21:37 +02:00
Arne Morten Kvarving
16f5290038
ParallelWellInfo: template Scalar type
2024-05-22 09:48:22 +02:00
Arne Morten Kvarving
81189b89c7
PerforationData: template Scalar type
2024-05-22 09:48:07 +02:00
Arne Morten Kvarving
d2cbf33b62
PerforationRates: template Scalar type
2024-05-22 09:48:06 +02:00
Arne Morten Kvarving
f65b8ef33b
StandardWell: use Scalar type
2024-05-22 09:01:05 +02:00
Arne Morten Kvarving
11b5ba3f18
WellInterfaceGeneric: template Scalar type
2024-05-14 10:26:58 +02:00
Vegard Kippe
91f532c036
Ensure well and accumulated group efficiency factors are applied to the connection energy rates.
2024-04-29 22:52:40 +02:00
Bård Skaflestad
d25c9d035f
Merge pull request #5311 from blattms/fix/uninit-warn
...
Fixes uninitialized variable warning with gcc-12
2024-04-25 10:34:05 +02:00
Markus Blatt
87c4471f96
Fixes uninitialized variable warning with gcc-12
2024-04-25 09:26:31 +02:00
Atgeirr Flø Rasmussen
edf4be5f79
Merge pull request #5227 from akva2/improve_ide_experience
...
Improve IDE experience
2024-04-22 15:31:08 +02:00
Arne Morten Kvarving
67f1811234
GroupState: template Scalar type
2024-04-17 11:12:40 +02:00
Arne Morten Kvarving
be57843296
WellState: template Scalar type
2024-04-17 11:12:40 +02:00
Arne Morten Kvarving
1f4b248564
WellInterfaceIndices: remove unnecessary Scalar template parameter
...
use the Scalar type from the FluidSystem
2024-03-08 15:13:53 +01:00
Arne Morten Kvarving
b2139d2cdf
StandardWellAssemble: remove unnecessary Scalar template parameter
...
use the Scalar type from the FluidSystem
2024-03-08 15:13:52 +01:00
Arne Morten Kvarving
3284ba80e8
StandardWell: rename ebosSimulator to simulator
2024-03-08 12:39:48 +01:00
Kai Bao
cd9a208757
Merge pull request #5166 from akva2/indices_drop_ebos
...
Drop ebos in index functions
2024-03-05 23:31:27 +01:00
Arne Morten Kvarving
d0072727cd
StandardWell: improve IDE experience
2024-02-27 10:43:03 +01:00
Kai Bao
60594a5e1b
Merge pull request #5129 from steink/avoid_reopening_stopped_wells
...
Avoid re-opening previously stopped wells
2024-02-12 14:44:15 +01:00
Arne Morten Kvarving
c4c7d2e4f5
WellInterfaceIndices: rename ebosCompIdxToFlowCompIdx to modelCompIdxToFlowCompIdx
2024-02-07 08:08:30 +01:00
Stein Krogstad
97477ea593
avoid re-opening previously stopped wells
2024-01-26 16:24:09 +01:00
Stein Krogstad
24c4f75ecb
Use stricter tolerance when dynamic thp
2024-01-26 15:02:14 +01:00
Stein Krogstad
051f4d4eab
Remove early-return functionality due to unintended consequences
2023-12-08 00:36:39 +01:00
Stein Krogstad
7c91c015cf
updates according to Atgeirrs comments
2023-12-07 13:09:00 +01:00
