Commit Graph
20698 Commits
Author SHA1 Message Date
Tor Harald Sandve 38be1ac83f add comment on limiting the other rate 2024-11-06 11:06:35 +01:00
Arne Morten Kvarving 15b12eaa3e avoid use of std::is_pod_v
implement it ourself in terms of std::is_trivial and
std::is_standard_layout. std::is_pod_v is deprecated in c++-20
2024-11-06 10:38:50 +01:00
Arne Morten Kvarving d9a3dd6f77 add casts to avoid comparison to / arithmetics with enums 2024-11-06 10:38:50 +01:00
Arne Morten Kvarving 68a727aac8 fixed: mark comparison operator const 2024-11-06 10:38:50 +01:00
Arne Morten Kvarving 13b5e23dec use constexpr instead of anonymous enums
c++-20 warns for arithmetics using enums
2024-11-06 10:38:50 +01:00
Bård Skaflestad ef434a9b59 Chase API Update of UDQConfig's Evaluation Functions
The functions no longer use the 'episeodeIdx' or Schedule
parameters.  Update callers accordingly.

While here, split some long lines and remove unneeded local objects.
2024-11-05 18:18:43 +01:00
Bård Skaflestad 2546d2b181 Merge pull request #5713 from akva2/fmt_fix_runtime_formats
fixed: use constexpr formats and/or mark format strings runtime
2024-11-05 15:59:40 +01:00
Bård Skaflestad d4f3de4fcd Merge pull request #5712 from akva2/janitoring
quell unused private member warning
2024-11-05 15:48:22 +01:00
Arne Morten Kvarving ca6a5521a4 fixed: use constexpr formats and/or mark format strings runtime
fmt wants to do compile time validation of format strings under c++-20.
mark formatting strings constexpr where possible, and mark formats
runtime to disable validation where not possible.
2024-11-05 15:03:17 +01:00
Arne Morten Kvarving 72ac61a0b7 quell unused private member warning 2024-11-05 14:58:06 +01:00
Tor Harald Sandve 8c1e03b9c4 Merge pull request #5695 from totto82/switchGroup
dont switch from GRUP if check_group_constrains_well_iterations=false
2024-11-05 13:56:16 +01:00
Bård Skaflestad 51dcb67ba9 Merge pull request #5710 from akva2/fix_test_suite_name
fixed: test-suites needs a name
2024-11-05 13:37:22 +01:00
Arne Morten Kvarving cdd37b4ed6 fixed: test-suites needs a name 2024-11-05 12:46:18 +01:00
Razvan Nane 3c5414102d rename bda in tests also 2024-11-05 11:17:28 +01:00
Tor Harald Sandve e372bde838 Dont redistribute gaslift on group that are not on group target 2024-11-05 11:09:55 +01:00
Tor Harald Sandve 113f8dfb4c Dont update group rates 2 times 2024-11-05 11:09:13 +01:00
Tor Harald Sandve 577229d38d Fix to sync groupinfo in parallel 2024-11-05 11:08:47 +01:00
Tor Harald Sandve 6a30966500 Limit the other rates when a rate is limited 2024-11-05 10:55:54 +01:00
Svenn Tveit b42537155e Bug fix: nan if liquid rate was zero 2024-11-05 10:55:54 +01:00
Svenn Tveit 4ffee2c359 Do not need inc. grad vector in when removing surplus alq 2024-11-05 10:55:54 +01:00
Svenn Tveit 29cb332f72 Set small alq to zero 2024-11-05 10:55:54 +01:00
Tor Harald Sandve 30259aca87 Keep group rates updated during second stage 2024-11-05 10:55:54 +01:00
Tor Harald Sandve b8a0005e8d FIX. Use rate not group potentials in CheckGroupTargetViolated 2024-11-05 10:55:54 +01:00
Tor Harald Sandve 363e3c2f4a simplify limited liquid group rate calculations 2024-11-05 10:55:54 +01:00
Tor Harald Sandve 85da447f87 Dont restrict top group in group rate computation 2024-11-05 10:55:54 +01:00
Bård Skaflestad ca62524aaf Merge pull request #5708 from blattms/feature/update-manpage
Update flow manpage with help2man.
2024-11-05 10:24:33 +01:00
Markus Blatt b50c19eb17 Update flow manpage with help2man.
Not ideal as it uses our help message. Unfortunately, the description
in there are not the best.
2024-11-04 19:52:05 +01:00
Markus Blatt 6a5e661d71 Make sure all errors from parsing show up in the log files.
Currently, some errors from parsing, like topology errors when
processing sections, are not included in the log files or the final
standard output before aborting. If there are no other errors the user
will only see a line like this without further explanation:
"Error: Unrecoverable errors while loading input:"

With this commit now print the string returned by ErrorGuard::dump to
the logs and standard output. Hence the user might see somthing like
this:

```
Error: Unrecoverable error while loading input: SECTION_TOPOLOGY_ERROR: The GRID section must be followed by EDIT or PROPS instead of GRID at: SPE1CASE2_ERR.DATA, line: 108
```
2024-11-04 16:28:20 +01:00
Razvan Nane baf94f76d2 Rename bda to gpu for classes 2024-11-04 12:31:34 +01:00
Razvan Nane 7c4bafe936 rename bda folder&files 2024-11-04 10:47:34 +01:00
Bård Skaflestad fadc96da44 Merge pull request #5705 from akva2/fix_div_by_zero_no_gpus
fixed: division by zero if no gpu device was found
2024-11-01 13:09:24 +01:00
Bård Skaflestad cdc96ac19e Merge pull request #5704 from bska/guaranteed-actionx-welpi-well-order
Simplify Logic for Exchanging PI/II Values in ACTIONX/WELPI
2024-11-01 11:53:55 +01:00
Arne Morten Kvarving 8b21902f74 fixed: division by zero if no gpu device was found 2024-11-01 10:29:51 +01:00
Bård Skaflestad d155d4b76a Simplify Logic for Exchanging PI/II Values in ACTIONX/WELPI
This commit switches to using the new guarantees provided by
ActionX::wellpi_wells (PR OPM/opm-common#4296), namely that the well
names are returned in sorted order on all ranks, to simplify how we
exchange the PI/II values.  In particular, given this guarantee, we
can calculate the maximum values across all ranks because zero
values correspond to missing entries and non-zero values correspond
to known entries.
2024-11-01 09:10:39 +01:00
Kjetil Olsen Lye e81cf62e79 Merge pull request #5611 from multitalentloes/print_gpu_info_on_startup
Print gpus used on simulator startup
2024-10-31 21:29:08 +01:00
Bård Skaflestad a08d49d3a4 Merge pull request #5701 from akva2/fix_set_active_indices
fixed: set active indices in fieldprops
2024-10-31 08:53:43 +01:00
Bård Skaflestad 9e7c3b9254 Merge pull request #5687 from GitPaean/tyring_ecl_compositional
ecl style output for compositional simulation
2024-10-30 15:49:35 +01:00
Kai Bao 0edb5a462d checking compIdx or phaseIdx when adding entries to SolutionVector
std::vector is used instead of std::array. when compIdx is -1, the
origional code trigger array-bounds warning.
2024-10-30 15:32:39 +01:00
Kai Bao c6201e9b6a addressing reviewing comments 2024-10-30 13:15:38 +01:00
Bård Skaflestad 78226f2819 Merge pull request #5693 from bska/private-fetch-well-pi
Make WELPI Infrastructure for ACTIONX Fully Private
2024-10-30 13:12:49 +01:00
Bård Skaflestad 70e8d25276 Make WELPI Infrastructure for ACTIONX Fully Private
This is in preparation of making the match set for ACTIONX more
general.  Having a fully private WELPI framework means we can change
the types more freely without having to rebuild all users of
ActionHandler.

While here, also add Doxygen-style documentation to the ActionHandler.
2024-10-30 12:48:02 +01:00
Kai Bao 56db6ad3fe cleaning unused headers and declarations in OutputCompositionalModule 2024-10-30 11:23:16 +01:00
Kai Bao cd9009dc75 adding isCompositional_ variable to GenericOutputBlackoilModule
to indicate whether it is a compostional simulation.
2024-10-30 11:23:16 +01:00
Kai Bao 65e858c84c fixing all the warnings related 2024-10-30 11:23:16 +01:00
Kai Bao 51c534e6fb removing Damaris from FlowProblemComp 2024-10-30 11:23:16 +01:00
Kai Bao 8541048f83 fixing the running of co2_ptflash_ecfv 2024-10-30 11:23:16 +01:00
Kai Bao def30fa131 recovering OutputBlackoilModule
there is not change needed for this file.
2024-10-30 11:23:16 +01:00
Kai Bao e4d1311589 adding thresholdPressure() interface to FlowProblemComp
although we do not support it yet.
2024-10-30 11:23:16 +01:00
Kai Bao 3635132d95 making OutputModule template parameter of EclWriter 2024-10-30 11:23:16 +01:00
Kai Bao 197282ccfc cleaing up EclWriter related and DamarisWriter.hpp 2024-10-30 11:23:16 +01:00