Commit Graph

56 Commits

Author SHA1 Message Date
Arne Morten Kvarving
d15cdea9ec FlowProblem: move parameter registration to FlowProblemParameters.cpp 2024-08-16 17:15:53 +02:00
Arne Morten Kvarving
e2b8715b42 move EclTimeStepping parameters to TypeTag-free parameter system 2024-08-16 13:22:17 +02:00
Arne Morten Kvarving
8111d2eaa0 move EclWriter parameters to TypeTag-free parameter system 2024-08-16 13:22:15 +02:00
Arne Morten Kvarving
414f313d2a move FlowProblem parameters to TypeTag-free parameter system 2024-08-16 13:20:06 +02:00
Arne Morten Kvarving
fdcc9a0fb2 fixed: EnableDebuggingChecks is a property, not a parameter 2024-08-16 13:20:06 +02:00
Arne Morten Kvarving
9141f2c2d5 move Damaris parameters to TypeTag-free parameter system 2024-08-16 13:20:06 +02:00
Arne Morten Kvarving
0a662e8b21 EnableGravity moved to TypeTag-free parameter system 2024-08-14 09:16:47 +02:00
Arne Morten Kvarving
0195f8f113 NewtonTolerance moved to TypeTag-free parameter system 2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
08b227f7e3 EnableStorageCache moved to TypeTag-free parameter system 2024-08-13 14:03:02 +02:00
Arne Morten Kvarving
77f0cda5d4 EnableIntensiveQuantityCache moved to TypeTag-free parameter system 2024-08-13 13:38:52 +02:00
Arne Morten Kvarving
fd012efac8 EnableVtkOutput moved to TypeTag-free parameter system 2024-08-13 10:30:50 +02:00
Arne Morten Kvarving
a20cb10572 InitialTimeStepSize moved to TypeTag-free parameter system 2024-08-12 13:56:36 +02:00
Arne Morten Kvarving
3e8929b04f EndTime moved to TypeTag-free parameter system 2024-08-12 13:45:31 +02:00
Bård Skaflestad
27c498f75a
Merge pull request #5511 from akva2/typetag_free_param_system
Support type-tag free parameter system
2024-08-09 18:02:26 +02:00
Arne Morten Kvarving
9204ff95a2
Merge pull request #5499 from daavid00/vtkDryRun
Write vtk (if enabled) for dry runs
2024-08-09 16:57:37 +02:00
David Landa Marban
d4890d18f7 Write vtk (if enabled) for dry runs 2024-08-09 15:29:32 +02:00
Arne Morten Kvarving
e1bcd00a36 adapt to ParameterSystem typetag removal 2024-08-09 10:56:07 +02:00
Tor Harald Sandve
0a63fc8e24 Move modification of density to convectiveMixingModule 2024-08-09 10:53:38 +02:00
Trine Mykkeltvedt
f10c44279f adressed minor comments by reviewer, added enableConvectiveMixing flag to drsdtcon, fixed indentation and bug in lastRs for gas/water 2024-08-09 10:51:19 +02:00
Trine Mykkeltvedt
ab2bd924db extending drsdtcon with regimes, and option for GAS/WATER 2024-08-09 10:48:00 +02:00
Arne Morten Kvarving
b69439aa1f changed: EclWriter parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
917fdbedfd changed: FlowProblem parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
2a52cf8134 changed: Damaris parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
6f7fcb5872 changed: EclTimeStepping parameters moved to Opm::Parameters namespace 2024-08-06 07:05:08 +02:00
Arne Morten Kvarving
f251370a52 changed: EnableGravity parameter moved to Opm::Parameters namespace 2024-08-02 09:04:08 +02:00
Markus Blatt
0caf92c6a6
Merge pull request #5448 from atgeirr/ensure-initialized-members-bdystate
Ensure all members are initialized in FlowProblem::boundaryFluidState().
2024-07-04 16:43:05 +02:00
Arne Morten Kvarving
b4c6a1a240 changed: InitialTimeStepSize parameter moved to Opm::Parameters namespace 2024-07-01 17:52:10 +02:00
Atgeirr Flø Rasmussen
a3839aaeb8 Ensure all members are initialized in boundaryFluidState().
Also restructure to loop over active phases instead of all
canonical phases.
2024-06-27 13:43:46 +02:00
Bård Skaflestad
ac42250b25
Merge pull request #5402 from totto82/output_wetting_hyst
Output maximum/minimum saturations directly for restart hysteresis
2024-06-26 12:15:20 +02:00
Tor Harald Sandve
230656ec31 updateInitialHystParams 2024-06-25 12:55:02 +02:00
Bård Skaflestad
26cd7ab993 Move opm/core/props to opm/simulators/utils
The opm/core directory is no longer meaningful, and it contains only
components which might collectively be described as simulator
utilities.
2024-06-25 12:22:09 +02:00
Tor Harald Sandve
a419390854
Merge pull request #5407 from totto82/fix_drsdt
avoid mass creation with drsdt
2024-06-20 12:14:22 +02:00
Bård Skaflestad
acb124bbdc
Merge pull request #5426 from totto82/output_every_timestep
fix option for output every timestep
2024-06-19 12:09:34 +02:00
Tor Harald Sandve
366f3a2944 fix option for output every timestep 2024-06-14 15:03:43 +02:00
Kai Bao
fd5e9d167f addressing reviewing comments OPM/opm-simulators#5419 2024-06-10 16:08:44 +02:00
Kai Bao
062a98b305 restruct so that we can release the global trans earlier
in the funciton finishInit().
2024-06-10 16:08:44 +02:00
Kai Bao
8f67881809 using enum class to replace boolean onlyTrans for
Transmissibility::update() for better readability, which is suggested by the reviewer.
2024-06-06 20:09:44 +02:00
Kai Bao
303a677a81 only allocate trans_ for globalTrans_
others are not needed for globalTrans_ for now. It will help to flatten
the peak memory usage for rank 0 during a parallel running.
2024-06-05 21:35:46 +02:00
Tor Harald Sandve
8b5fced909 avoid mass creation with drsdt 2024-06-04 15:10:11 +02:00
Bård Skaflestad
6e8da2309b Delay UDQ Assignments Until After Summary Output
Commit 0aaa69c6e (PR #5330) was a little too eager in its effort to
handle UDQ ASSIGN operations after action processing[%].  In
particular, the assignments, which alter the internal structures of
the SummaryState and UDQState objects, would happen prior to writing
summary files.  In turn, this would make it appear as if the
assignment happened too early.  This commit defers UDQ assignments
triggered by action processing until FlowProblem<>::endEpisode() for
two reasons

  1. The problem originally addressed in 0aaa69c6e only presented
     when the assignment was triggered on the final time step of an
     episode (report step), so handling this situation here is a
     more targeted approach.

  2. Member function FlowProblem<>::endEpisode() is called after we
     write the summary file output so any alterations to the
     internal structures of the SummaryState will not be visible in
     the summary output until the next time step.  This is the
     expected behaviour.

[%] Insufficient testing by: [at]bska.
2024-05-28 18:16:30 +02:00
Bård Skaflestad
0aaa69c6e0 Rerun UDQ Assignments After Action Processing
If an action block happens to run a UDQ ASSIGN operation and,
furthermore, happens to run at the last time step of an episode then
the "clear pending assignments" behaviour of the ScheduleState copy
constructor leads to not performing the UDQ assignment at all.  This
commit works around this problem by invoking the action handler's
UDQ assignment function after processing all active action blocks.

The underlying problem has been present since at least Pull Request
OPM/opm-common#3587 which introduced the "clear pending assignments"
behaviour of ScheduleState's copy constructor.
2024-05-21 13:51:06 +02:00
Bård Skaflestad
9731a84cad Adjust Whitespace in FlowProblem File
In particular, be consistent about four-space indent levels and add
braces to a number of single-statement control blocks.  Add a few
blank lines for readability.

While here, also mark a number of objects as 'const'.
2024-05-21 13:51:06 +02:00
Arne Morten Kvarving
f70c7f15f8 ActionHandler: template Scalar type 2024-05-14 16:21:55 +02:00
Kai Bao
b225ec240f removing updateKrnum_
which does not have effects, which was suggested by Håkon Hægland.

And also removing the following member variables from
FlowGenericProblem because they are not in use anymore.

    krnumx_, krnumy_, krnumz_;
    imbnumx_, imbnumy_, imbnumz_;
2024-05-08 09:41:46 +02:00
Tor Harald Sandve
c6c447dc94 initialize the input temperature in restart run without temperature in the restart file 2024-05-06 10:21:42 +02:00
Atgeirr Flø Rasmussen
e767b6145f Avoid getting parameters in hot path. 2024-04-26 16:46:27 +02:00
Arne Morten Kvarving
0aacefeeec adjust to Parameters::isSet change 2024-04-15 08:12:05 +02:00
Arne Morten Kvarving
0161d69660 adjust to removal of EWOMS_GET_PARAM 2024-04-05 14:02:28 +02:00
Arne Morten Kvarving
b8284fea9c adjust to Parameters::hideParam change 2024-04-05 12:56:38 +02:00
Arne Morten Kvarving
6fba1a95c9 adjust to removal of EWOMS_REGISTER_PARAM 2024-04-05 12:24:48 +02:00