Commit Graph

679 Commits

Author SHA1 Message Date
Vegard Kippe
1d2e413d63 Parameterize network sub-iterations and pressure update dampening 2025-01-27 11:44:10 +01:00
Arne Morten Kvarving
b41f512214 BlackoilWellModelGasLift: serialize last_glift_opt_time 2025-01-24 14:37:00 +01:00
Bård Skaflestad
d02ad0f637
Merge pull request #5909 from hnil/add_tracy
added more timing
2025-01-23 12:24:55 +01:00
Halvor M Nilsen
f2bfa1b2ef added more timing 2025-01-23 11:28:20 +01:00
Arne Morten Kvarving
fe3c687eaa remove some duplicate if conditionals 2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
c114def851 mark parameters/variables as const where appropriate 2025-01-23 07:57:44 +01:00
Arne Morten Kvarving
76c947b04c cosmetics 2025-01-22 17:41:47 +01:00
Bård Skaflestad
76f690c869
Merge pull request #5877 from akva2/fix_wcycle_multiple_blocks
Fix WCYCLE for multiple blocks
2025-01-15 10:56:27 +01:00
Arne Morten Kvarving
ecc231a2a2
Merge pull request #5858 from akva2/blackoilwellmodel_temperature_constexpr
BlackoilWellModel::computeWellTemperature: use if constexpr
2025-01-15 10:41:25 +01:00
Arne Morten Kvarving
610788eaa9 fixed: need to grab open times for wells before processing wcycle
this as we need to capture the effect of WELOPEN statements
at current report step
2025-01-14 12:41:12 +01:00
Atgeirr Flø Rasmussen
6952d19a92
Merge pull request #5849 from akva2/rename_haswell
Fix BlackoilWellModel::hasWell mixups
2025-01-13 11:29:19 +01:00
Arne Morten Kvarving
6d003b2f33 BlackoilWellModel::computeWellTemperature: use if constexpr 2025-01-10 09:50:58 +01:00
Arne Morten Kvarving
73ede837bb changed: move WBP BlackoilWellModel code to separate class
model using has-a instead of is-a in BlackoilWellModelGeneric
2025-01-10 09:38:35 +01:00
Arne Morten Kvarving
70e993c0bc BlackoilWellModel: move group switching reporting to separate method
this can be put in the generic TU
2025-01-10 09:18:05 +01:00
Arne Morten Kvarving
983ebedb8a cosmetics: break some long lines 2025-01-09 15:33:44 +01:00
Arne Morten Kvarving
64f9ebb06c move hasOpenLocalWell to BlackoilWellModelGeneric 2025-01-09 15:32:00 +01:00
Arne Morten Kvarving
98949004c6 changed: rename BlackoilWellModel::hasWell to hasOpenLocalWell
this to avoid confusion as there is already a hasWell
in BlackoilWellModelGeneric which checks all wells
2025-01-09 15:29:10 +01:00
Arne Morten Kvarving
2800f35b73 changed: move the auxillary well module from BlackoilModule to WellConnectionAuxillary
this is an adapter for the non-linear solver.
it is still model using is-a but this can now be changed if desired.
2025-01-07 10:38:03 +01:00
Atgeirr Flø Rasmussen
733e24fe78 Fix clang complaints about incorrect constexpr usage.
Also make one more if constexpr.
2025-01-07 10:11:08 +01:00
Arne Morten Kvarving
89dbda4621 changed: move GasLift to separate class
move to has-a instead of is-a for modelling in BlackoilWellModel
2025-01-06 15:15:59 +01:00
Arne Morten Kvarving
7c5f9c59b3 BlackoilWellModel: move initialization of terminal_output_ to the generic class
it is now possible since parameter system does not need typetag
2025-01-06 15:09:56 +01:00
Arne Morten Kvarving
0ee1d2fae5 changed: use standard header guard structure for _impl.hpp clangd helpers 2025-01-03 09:25:49 +01:00
Arne Morten Kvarving
34fa8914f6 cosmetics 2025-01-02 13:26:56 +01:00
Arne Morten Kvarving
f71a92cf63 use std::find_if instead of loop 2025-01-02 13:26:56 +01:00
Arne Morten Kvarving
165d0a953f changed: move implementation of WellOperators out of BlackoilWellModel 2024-12-20 10:41:58 +01:00
Tor Harald Sandve
c0318c8759
Merge pull request #5754 from plgbrts/ac-group-guide-rates
Allow group guide rates in case that a group is an auto choke group
2024-12-20 07:54:57 +01:00
plgbrts
8158ae8abe allow defaulted group guide rates
clean up
2024-12-19 14:49:18 +00:00
Arne Morten Kvarving
4f5c86d72c
Merge pull request #5816 from akva2/fix_wcycle_glob
Allow query for efficiency scaling factor in off-process wells where required
2024-12-19 13:53:30 +01:00
Vegard Kippe
60d738bc1c Allow query for efficiency scaling factor in off-process wells where required 2024-12-19 13:31:52 +01:00
Paul
9d735b8d6e add group target calculation
added temporary output

mainly rebasing

rebasing

some further attempts

fixed target calculations

remove some case specific choices

clean up

some clean up

generalised code for calculating target rate in groupControlledWells

small rebase fix

<double> replaced by <Scalar>

<double> replaced by <Scalar> (2)
2024-12-19 12:11:00 +00:00
Paul
6b2c372f11 allow individual well constraints
before rebasing

moved common thp calculation to updateWellControls

Small fix

clean up and improvements according reviewer comments

clean up and improvements according reviewer comments, part 2

changed assessing safe THP range

rebasing fixes

removed unused argument

rebasing
2024-12-19 12:10:50 +00:00
Arne Morten Kvarving
822fc11a3d cosmetics 2024-12-19 13:10:46 +01:00
Arne Morten Kvarving
44c8b6086b computeWellBlockAveragePressures: move to BlackoilWellModelGeneric 2024-12-19 13:10:46 +01:00
Arne Morten Kvarving
4d998545eb initializeWBPCalculationService: move to BlackoilWellModelGeneric 2024-12-19 13:10:46 +01:00
Paul
32e45489d7 This is a combination of 3 commits.
autochoke producers control mode set to THP

simplyfying code as some logic is moved to the parser

minor repair work
2024-12-19 12:08:59 +00:00
Arne Morten Kvarving
a67e8c44b4 registerOpenWellsForWbpCalculation: move to BlackoilWellModelGeneric 2024-12-19 12:58:50 +01:00
Arne Morten Kvarving
3d10b549e7 setPrimaryVarsDomain: move to BlackoilWellModelGeneric 2024-12-19 12:58:50 +01:00
Arne Morten Kvarving
a36d40957b getPrimaryVarsDomain: move to BlackoilWellModelGeneric 2024-12-19 12:58:50 +01:00
Arne Morten Kvarving
5217e63309 logPrimaryVars: move to BlackoilWellModelGeneric 2024-12-19 12:58:50 +01:00
Arne Morten Kvarving
5897805e5b well_domain_: move to BlackoilWellModelGeneric 2024-12-19 12:58:49 +01:00
Arne Morten Kvarving
58ac8f2553 setPrimaryVarsDomain: take domain index as parameter 2024-12-19 12:58:29 +01:00
Arne Morten Kvarving
75dc66d4d2 getPrimaryVarsDomain: take domain index as parameter 2024-12-19 12:58:29 +01:00
Bård Skaflestad
8f42288d71 Chase WBP Source Requirement Change
The revised depth correction algorithm requires per-cell depth
information (in SourceDataSpan::Item::Depth) for the reservoir
contributions so honour this requirement.

This is potentially a somewhat wasteful approach since the cell
centre depth is constant throughout a simulation, but it's a simple
strategy that does not require large API and synchronisation
changes, so we nevertheless stick to this as a first implementation.
We will reduce the amount of communication if this becomes a
bottleneck.
2024-12-18 16:35:13 +01:00
Arne Morten Kvarving
0470502027 added: support WCYCLE 2024-12-17 08:41:25 +01:00
Arne Morten Kvarving
82a9698d27 added: support a scaling factor for well efficiency 2024-12-17 08:41:25 +01:00
Bård Skaflestad
340855a41d Chase API Update
The WBP result type is now top-level.
2024-12-11 15:34:36 +01:00
Paul
3933166001 Automatic choke 2024-12-10 09:58:25 +00:00
Tor Harald Sandve
1180ad2652 Allow for the third group switch 2024-12-10 09:41:21 +01:00
Tor Harald Sandve
96da980897
Merge pull request #5753 from totto82/maxGroupChange
Alternative way of avoiding group control oscillations
2024-12-09 11:24:21 +01:00
Tor Harald Sandve
095c0457bc Code improvment for the group control switching
Pass the controls as enums not strings
Avoid pair as key in map
2024-12-06 13:56:00 +01:00