Kai Bao
eb83fff9d5
Merge pull request #5435 from steink/updates_in_preparation_for_5157
...
Minor updates in preparation for New defaults #5157 .
2024-06-26 00:24:29 +02:00
Bård Skaflestad
26cd7ab993
Move opm/core/props to opm/simulators/utils
...
The opm/core directory is no longer meaningful, and it contains only
components which might collectively be described as simulator
utilities.
2024-06-25 12:22:09 +02:00
Stein Krogstad
fd199d2558
Rewrite to properly loop over components
2024-06-25 11:46:53 +02:00
Stein Krogstad
1efcd2c936
Fix potential for solvent + adjust perforation pressures
2024-06-25 11:46:53 +02:00
Kai Bao
d7d74d3a3e
Merge pull request #5424 from GitPaean/fixing_wecon
...
WECON RATE limit should not be applied if the well is under zero group rate target
2024-06-24 19:02:53 +02:00
Kai Bao
f99956c452
Merge pull request #5432 from vkip/gconprod_item11to13
...
Allow GCONPROD item 11-13 to actually take effect.
2024-06-24 18:59:29 +02:00
Kai Bao
6ac7f8fdaf
not applying WECON RATE limit
...
when the well is under zero group target.
2024-06-24 14:42:10 +02:00
Markus Blatt
9dbaad2b3e
Merge pull request #5423 from blattms/bugfix/mswell-exceptions-are-problems
...
Only indicate problems for exceptions whem updating well potentials,
2024-06-20 14:33:17 +02:00
Vegard Kippe
ca1331fe08
Allow GCONPROD item 11-13 to actually take effect.
2024-06-19 10:47:43 +02:00
Markus Blatt
58ede5e789
Only indicate problems for exceptions whem updating well potentials,
...
Nearly all exceptions throw when computing well potentoals will not
abort the simulator but result in timestep chops. Hence those should not be
counted as errors (e.g. by calling the OPM_*THROW* macros) and be
reported in the PRT file.
This change will cause at least two more occurences (in
MSWellHelpers) to be treated as problems. For this we added a new
helper function.
2024-06-12 14:25:37 +02:00
Svenn Tveit
adc36d64a5
Output rates to multisegment wells
2024-06-10 14:50:55 +02:00
Svenn Tveit
1645559342
Fix mass exchange term.
...
Additionally, store separate well terms for free and solution tracers
2024-06-10 14:48:45 +02:00
Atgeirr Flø Rasmussen
74fc1d4a67
Ensure the 'injector' member is initialized, compared etc.
2024-06-06 16:31:46 +02:00
Bård Skaflestad
151de07fa7
Collect Well Level Control Limits/Targets for Summary Output
...
This commit adds a new stage to the wellData() report function,
assignWellTargets(), which collects the numerical values of the
currently active limits/targets for summary file output purposes.
It is important that we collect these values strictly before we
start mutating the SummaryState object lest user-defined arguments
in keywords like WCONPROD be evaluated seemingly too soon.
Furthermore, it is faster to collect these values on the simulator
side and send them to the I/O rank for file output than to defer the
full calculation to the I/O rank.
2024-06-06 09:13:57 +02:00
Stein Krogstad
37c771cb5f
fix bug and attempt to make code clearer
2024-05-31 14:11:10 +02:00
Stein Krogstad
d32d4419a9
fix double -> Scalar
2024-05-31 14:11:10 +02:00
Stein Krogstad
aa8516c085
Respect "global" switching logic also in local solves
2024-05-31 14:11:10 +02:00
Stein Krogstad
008fd268c5
fix bug
2024-05-31 14:11:10 +02:00
Stein Krogstad
c5f7d02bf7
Make thp-func constistent with bhp-func and add some damage prevention logic for severe extrapolation
2024-05-31 14:11:10 +02:00
Arne Morten Kvarving
bcbac79486
Merge pull request #5380 from akva2/linalg_template_scalar
...
LinAlg classes: template Scalar type
2024-05-31 08:40:11 +02:00
Kai Bao
e968da28bb
renaming calcRates to calcResvCoeff
...
and calcInjRates to calcInjResvCoeff.
2024-05-29 22:29:12 +02:00
Bård Skaflestad
03e8c7ecdc
Merge pull request #5394 from atgeirr/avoid-memory-leak
...
Avoid memory leak from the *unique_ptr<X>.release() antipattern.
2024-05-28 18:15:01 +02:00
Atgeirr Flø Rasmussen
6a7e1e08c0
Avoid memory leak from the *unique_ptr<X>.release() antipattern.
2024-05-28 16:49:08 +02:00
Bård Skaflestad
a16ef8b1c2
Merge pull request #5393 from atgeirr/avoid-out-of-scope-temporary
...
Bugfix: Avoid possible use of out-of-scope temporary.
2024-05-28 16:31:30 +02:00
Atgeirr Flø Rasmussen
0fe76f6011
Bugfix: Avoid possible use of out-of-scope temporary.
...
Since std::clamp returns a reference we must be careful to not capture
the return value by reference, when there is a temporary among the input
parameters.
For the second change (adding the explicit Scalar return type to a lambda)
this is strictly speaking not necessary, as the lambda's return type is not
a reference, but that is obscure so the change is just done as to clarify.
2024-05-28 16:01:48 +02:00
Arne Morten Kvarving
ff39bc3b03
WellContribution: template Scalar type
2024-05-24 14:09:11 +02:00
Arne Morten Kvarving
c240df73c4
WellBhpThpCalculator: use appropriate Scalar type
2024-05-24 14:03:28 +02:00
Stein Krogstad
427351cc12
Include checking for zero targets from groups where required
2024-05-23 14:55:37 +02:00
Stein Krogstad
2db90a92e7
include group controls for zero rate target checking
2024-05-23 14:44:26 +02:00
Arne Morten Kvarving
5ed5676f32
WellGroupHelpers: use appropriate Scalar type
2024-05-23 09:08:48 +02:00
Arne Morten Kvarving
db2db4bab5
WellFilterCake: use appropriate Scalar type
2024-05-23 09:06:16 +02:00
Arne Morten Kvarving
ca6b73a6f8
VFPProdProperties: use appropriate Scalar type
2024-05-23 09:03:48 +02:00
Arne Morten Kvarving
769489f552
VFPHelpers: use appropriate Scalar type
2024-05-23 09:01:14 +02:00
Arne Morten Kvarving
e9050359db
BlackoilWellModel: use appropriate Scalar type
2024-05-23 08:52:59 +02:00
Arne Morten Kvarving
bac2087b85
WellProdIndexCalculator: template Scalar type
2024-05-22 15:21:37 +02:00
Arne Morten Kvarving
685bca2c2a
WellProdIndexCalculator: drop indent for namespace
2024-05-22 15:21:37 +02:00
Arne Morten Kvarving
b9d03fc358
MultisegmentWell: use Scalar type
2024-05-22 14:33:36 +02:00
Arne Morten Kvarving
791d83b31a
MultisegmentWellSegments: use Scalar type
2024-05-22 14:24:22 +02:00
Arne Morten Kvarving
caf4bc1de2
MultisegmentWellGeneric: use Scalar type
2024-05-22 14:24:22 +02:00
Arne Morten Kvarving
b151cbabac
MultisegmentWellPrimaryVariables: use Scalar type
2024-05-22 14:24:22 +02:00
Arne Morten Kvarving
33ad8e3617
MultisegmentWellEval: use Scalar type
2024-05-22 14:24:22 +02:00
Arne Morten Kvarving
0da7903f8b
MultisegmentWellAssemble: use Scalar type
2024-05-22 13:24:05 +02:00
Arne Morten Kvarving
27d99f78ec
ParallelWBPCalculation: template Scalar type
2024-05-22 10:51:12 +02:00
Arne Morten Kvarving
66a08b9c1a
ParallelPAvgCalculator: template Scalar type
2024-05-22 10:51:07 +02:00
Arne Morten Kvarving
b68a854909
ParallelPAvgDynamicSourceData: template Scalar type
2024-05-22 10:51:07 +02:00
Arne Morten Kvarving
b9ad890ea5
adjust to PAvgCalculatorCollection templating
2024-05-22 10:51:07 +02:00
Arne Morten Kvarving
0481c7c0b2
adjust to PAvgCalculator templating
2024-05-22 10:51:07 +02:00
Arne Morten Kvarving
59e6d4db08
adjust to PAvgDynamicSourceData templating
2024-05-22 10:51:07 +02:00
Arne Morten Kvarving
e0bcb314ea
MSWellHelpers: template Scalar type
2024-05-22 09:57:44 +02:00
Arne Morten Kvarving
16f5290038
ParallelWellInfo: template Scalar type
2024-05-22 09:48:22 +02:00
