Kai Bao
6ab809c69d
Merge pull request #5004 from blattms/control-mode-typo
...
Fixed typo: control model -> control mode.
2023-11-20 09:13:03 +01:00
Markus Blatt
de50fe5702
Fixed typo: control model -> control mode.
2023-11-20 08:29:24 +01:00
Vegard Kippe
abbcb4b148
Check if a well was closed this step before re-opening in history mode
2023-11-17 17:29:30 +01:00
Bård Skaflestad
c559de51cf
Merge pull request #4996 from totto82/fixWDFAC
...
Fix wdfac and d factor in comdat
2023-11-17 09:09:22 +01:00
Tor Harald Sandve
82cb3c3b53
Fix connection and well dfactor
...
The well dfactor is scaled by the well index
If postive the connection dfactor is threated as a well factor
and also scaled. If negative the connection dfactor is not scaled
2023-11-16 14:50:59 +01:00
Kai Bao
e355990ac2
Merge pull request #4999 from vkip/always_open_historic_wells
...
Always check if wells on historic controls can be opened
2023-11-15 20:29:21 +01:00
Vegard Kippe
e0d1ff9c66
Always check if wells on historic controls can be opened
2023-11-15 19:04:48 +01:00
Bård Skaflestad
f195f73949
Extract Binary_Search Out to Helper
...
Mostly for readability.
2023-11-15 13:31:41 +01:00
Bård Skaflestad
0b2c396a01
Merge pull request #4961 from vkip/network_restart_use_node_pressures
...
Use network pressures from restart
2023-11-15 09:46:35 +01:00
Tor Harald Sandve
0f12977b17
only use d factor for gas wells
2023-11-14 12:45:25 +01:00
Tor Harald Sandve
e33d27ca90
Merge pull request #4973 from daavid00/enabledisgaswatvap
...
Enabling disGas and watVap at compile time for gasWaterBrine systems
2023-11-13 15:01:38 +01:00
Kai Bao
bbdad520d6
Merge pull request #4915 from vkip/network_multi_root
...
Support computation of network pressures in networks with multiple roots
2023-11-13 14:39:07 +01:00
Arne Morten Kvarving
ddd0c5629d
GasLiftSingleWellGeneric: avoid dead store
...
all branches below write a new value
2023-11-10 14:32:30 +01:00
Vegard Kippe
4ce9c41a37
Replacing loop by assignment
2023-11-10 09:01:09 +01:00
Bård Skaflestad
16c8184e3f
Merge pull request #4914 from vkip/extra_network_output
...
Allow output of network pressures based on rates at end of time step
2023-11-09 23:19:48 +01:00
Bård Skaflestad
7832c1ba54
Merge pull request #4976 from totto82/fix_rsw
...
Fix rsw computation of wellbore density for StW
2023-11-09 09:37:16 +01:00
Kai Bao
25b007c46e
Merge pull request #4945 from vkip/network_reroute
...
Network reroute - avoid looking up nonexisting nodes
2023-11-08 19:59:40 +01:00
Atgeirr Flø Rasmussen
749ea93e24
Add and use OPM_DEFLOG_PROBLEM macro.
...
This should replace OPM_DEFLOG_THROW in places where the problem
category is more appropriate than the error category.
In this commit, uses of OPM_DEFLOG_THROW have been replaced whenever
the exception class used was NumericalProblem.
2023-11-08 15:16:17 +01:00
David Landa Marban
92de5355b2
Enabling disGas and watVap at compile time for gasWaterBrine
2023-11-07 18:35:30 +01:00
Bård Skaflestad
abfb5c9d82
Update Well Topology if Triggered From ACTIONX
...
This commit adds a new flag data member,
wellStructureChangedDynamically_
to the generic black-oil well model. This flag captures the
well_structure_changed
value from the 'SimulatorUpdate' structure in the updateEclWells()
member function. Then, in BlackoilWellModel::beginTimeStep(), we
key a well structure update off this flag when set. This, in turn,
enables creating or opening wells as a result of an ACTIONX block
updating the structure in the middle of a report step.
2023-11-07 17:02:18 +01:00
Tor Harald Sandve
26247a2aba
Fix rsw computation of wellbore density for StW
2023-11-07 15:53:51 +01:00
Stein Krogstad
0756e2d1c1
Initialize rates/previous rates before well-test
2023-11-06 11:46:44 +01:00
Arne Morten Kvarving
e3cd06c164
avoid uninitialized value static analyzer warning
2023-11-06 08:56:53 +01:00
Arne Morten Kvarving
fa45790bfb
changed: rename variable
...
this indicates that bracketing was successfully found,
not that we are looking for a bracket
2023-11-06 08:56:53 +01:00
Bård Skaflestad
9233e32d81
Merge pull request #4826 from totto82/fixResvRates
...
Compute resv rates based on pressure and temperature in the well for injectors in thermal cases
2023-11-01 16:24:10 +01:00
Vegard Kippe
14b7f926da
Avoid looking up nonexisting nodes..
2023-11-01 13:36:21 +01:00
Tor Harald Sandve
d7401e3b6b
Merge pull request #4919 from daavid00/saltprecPermFac
...
Multiply well trans due to perm reduction in salt prec
2023-11-01 13:29:57 +01:00
Bård Skaflestad
17886f934c
Merge pull request #4924 from GitPaean/fixing_gecon_welopen
...
use the WELL_SET_TO_OPEN event to open closed wells
2023-11-01 10:24:18 +01:00
David Landa Marban
c93d46c1be
Mult well trans due to perm reduction in salt prec
2023-10-31 22:11:55 +01:00
Bård Skaflestad
bf72698310
Merge pull request #4832 from totto82/wdaccor_refactor
...
Implement Forchheimer term in wellIndex
2023-10-31 17:46:49 +01:00
Vegard Kippe
c9cc261891
Use network pressures from restart
2023-10-30 23:26:35 +01:00
Vegard Kippe
429b312bc0
Re-introducing check for negative reportStepIdx and adding forgotten hasGroup check.
2023-10-27 20:30:48 +02:00
Vegard Kippe
f137565bb6
Avoid exception for non-group nodes
2023-10-26 19:35:56 +02:00
Vegard Kippe
5fbf981af8
Output of network pressures based on rates at end of time step
2023-10-26 19:35:56 +02:00
Tor Harald Sandve
a40ede9957
Compute reservoir injection rates from well temperature and pressure for thermal cases
2023-10-26 15:57:41 +02:00
Kai Bao
3e03ebbb58
making a few assertion to throw in StandardWellPrimaryVariables
...
to get more outputting information and also avoid harsh termination due
to assert.
They are technically numerical problem instead of programming mistakes.
2023-10-26 11:36:25 +02:00
Bård Skaflestad
95bc3822fb
Merge pull request #4948 from GitPaean/glo_active_enter_glift
...
checking LIFTOPT active before gliftBeginTimeStepWellTestUpdateALQ and before attempting to optimize alq in gliftBeginTimeStepWellTestIterateWellEquations
2023-10-26 09:06:23 +02:00
Kai Bao
beda7a0b35
checking LIFTOPT active before trying to optimizing alq
...
in gliftBeginTimeStepWellTestIterateWellEquations.
otherwise, if the increment is 0 (inactive), the function
gliftBeginTimeStepWellTestIterateWellEquations
might return undesired results or enter endless loop.
2023-10-25 23:00:54 +02:00
Kai Bao
2b97c3fe1d
checking LIFTOPT active before gliftBeginTimeStepWellTestUpdateALQ
...
to avoid meaningless message output related to GLIFT and WTEST
2023-10-25 21:45:19 +02:00
Tor Harald Sandve
90e791877c
Implement Forchheimer term in wellIndex
...
Add output of CDFAC
Add effect of compaction on CTFAC
2023-10-23 08:55:21 +02:00
Kai Bao
83ed0f01e5
use the REQUEST_OPEN_WELL event to open closed wells
2023-10-20 13:08:07 +02:00
Stein Krogstad
57c960d7c5
default value of option for extra derivatives
2023-10-19 15:12:00 +02:00
Stein Krogstad
dd6d195a6b
Add missing reverse flow derivatives for valve/icd/aicd
2023-10-19 15:12:00 +02:00
Bård Skaflestad
b60eb25285
Merge pull request #4918 from GitPaean/remove_white_spaces_wells_folder
...
removing white spaces in the wells folder
2023-10-19 09:08:03 +02:00
Bård Skaflestad
d98de155de
Merge pull request #4930 from GitPaean/not_reset_thp_value_well_state
...
not setting THP to be zero based whether having THP constraint from the Deck input in the WellState
2023-10-16 22:02:43 +02:00
Kai Bao
e1018e2815
if there is no VFP table associated with the well
...
we set the thp to be zero in the WellState. The previous logic related
this to THP constraints does not hold in multiple situations:
1. VFP table is specified, we need the THP value for output purpose
2. network is involved, we need the THP value for constraint check.
2023-10-16 21:43:18 +02:00
Kai Bao
b975ebff65
Merge pull request #4881 from vkip/no_network_solve_in_history
...
Avoid iterating network if no network wells are in prediciton mode
2023-10-16 14:54:36 +02:00
Vegard Kippe
5bb0942a02
Reverting unintended change.
2023-10-16 10:38:08 +02:00
Kai Bao
f5d3489d23
distinguishing report step and time step
...
for the funcitons related to createWellContainer() and
runWellPIScaling().
So it is not exhaustive, but we should do it gradually.
2023-10-11 11:33:02 +02:00
Kai Bao
a525f0865f
removing white spaces in the wells folder
2023-10-09 11:14:48 +02:00