Commit Graph

21231 Commits

Author SHA1 Message Date
Bård Skaflestad
ab380d5dfe
Merge pull request #5904 from akva2/primaryvars_scalar_assignment
xxxPrimaryVariables: remove ctor from Scalar
2025-01-22 16:59:16 +01:00
Arne Morten Kvarving
6cdb905ed7 fixed: condition on MPI_FOUND, not USE_MPI 2025-01-22 15:37:15 +01:00
Arne Morten Kvarving
078249503f changed: move NLDD BlackoilWellModel code to separate class 2025-01-22 15:33:28 +01:00
Arne Morten Kvarving
74cfde89e0 xxxPrimaryVariables: remove ctor from Scalar
these were only in use for assignments to a constant.
Instead of detouring all of these assignments through a temporary,
use the base field vector assignment operator to do inplace
assignments.
2025-01-22 15:28:49 +01:00
Arne Morten Kvarving
64df3c25f4 header cleanups 2025-01-22 15:28:49 +01:00
Bård Skaflestad
e288a61c59
Merge pull request #5894 from totto82/gsatprod
Implement gsatprod
2025-01-22 14:17:22 +01:00
Bård Skaflestad
6813f3ab54
Merge pull request #5901 from GitPaean/fixing_logical_and
using logical AND instead of bit-wise AND
2025-01-22 13:34:51 +01:00
Tor Harald Sandve
7b4894b600 cleanup based on review 2025-01-22 13:15:47 +01:00
Kai Bao
8b5ce37780 using logical AND instead of bit-wise AND
overlooking when reviewing PR#5861
2025-01-22 13:12:48 +01:00
Kai Bao
939e6f3a6c
Merge pull request #5861 from vkip/bugfix_restart_with_inactive_wells
Bugfix: Upon restart, do not try to restore segment info for inactive wells
2025-01-22 12:59:20 +01:00
Tor Harald Sandve
5c8a9eca5b adapt to changes in common 2025-01-22 12:55:44 +01:00
Tor Harald Sandve
7ae7ff6ee0 Mark GSATPROD supported 2025-01-22 12:55:44 +01:00
Tor Harald Sandve
f9d6644197 add gsatprod to group rates 2025-01-22 12:55:44 +01:00
Tor Harald Sandve
fef6cfcf38 Fix parallel gsatprod 2025-01-22 12:55:44 +01:00
Tor Harald Sandve
ecc3c5557d Dont reset subtimestep from tuning/wcycle if time step is chopped due to convergence issues 2025-01-22 12:54:24 +01:00
Bård Skaflestad
4d91d687eb
Merge pull request #5679 from vkip/skip_empty_pos_args
Skip empty positional arguments
2025-01-21 17:01:17 +01:00
Bård Skaflestad
bf4a6a1814
Merge pull request #5898 from akva2/janitoring_sca
janitoring: quell static analyzer issues
2025-01-21 15:33:38 +01:00
Arne Morten Kvarving
67d39d8d7e header scrub 2025-01-21 14:41:58 +01:00
Arne Morten Kvarving
1c537632fc mark methods override 2025-01-21 14:41:57 +01:00
Arne Morten Kvarving
6b53f5b4e8 remove unnecessary (empty) dtors 2025-01-21 14:41:18 +01:00
Arne Morten Kvarving
4119b66866 tabs to spaces 2025-01-21 14:41:18 +01:00
Arne Morten Kvarving
6d964c1370 mark constructors explicit 2025-01-21 14:41:17 +01:00
Markus Blatt
990c3f0248
Merge pull request #5620 from hakonhagland/timestepping2
Reservoir coupling: Implement time stepping
2025-01-21 14:38:24 +01:00
Kai Bao
c1e65aa044
Merge pull request #5886 from svenn-t/general_cubic_eos
Compositional simulations with more cubic EOS formulations
2025-01-21 10:06:01 +01:00
Bård Skaflestad
afd2bf7829
Merge pull request #5897 from akva2/only_smry
added: option to only compare summary files in regression tests
2025-01-21 08:55:15 +01:00
Arne Morten Kvarving
8755413c72 added: option to only compare summary files in regression tests 2025-01-21 06:20:45 +01:00
Håkon Hægland
18d35cb820 Explain the timestepping
Adds developer documentation about the timestepping procedure.
2025-01-20 23:07:10 +01:00
Håkon Hægland
b4192b06c3 Fix rebase problem 2025-01-20 15:28:05 +01:00
Svenn Tveit
b0dcf0feb3 Fix indentation 2025-01-20 14:57:24 +01:00
Bård Skaflestad
2f75635d21
Merge pull request #5892 from lisajulia/feature/pyAction-insert-kw-WELPI-WPIMULT-alternative
Feature/py action insert kw welpi wpimult alternative
2025-01-20 13:14:00 +01:00
Lisa Julia Nebel
885b714e82 Add test to insert WPIMULT keyword to pyactionActionXComparisons.cmake 2025-01-20 12:45:58 +01:00
Lisa Julia Nebel
b9e1db4f81 Add test to insert WELPI keyword to pyactionActionXComparisons.cmake 2025-01-20 12:45:58 +01:00
Lisa Julia Nebel
f40f67023d Retrieve welpi map for Pyaction calls as well and hand it over to the runPyAction function of the Schedule 2025-01-20 12:45:49 +01:00
Arne Morten Kvarving
6d9e2d0487
Merge pull request #5895 from akva2/transmissibility_janitoring
Transmissibility: some janitoring
2025-01-20 09:52:01 +01:00
Arne Morten Kvarving
5c142d1c4d only do cartesian cell index lookup once 2025-01-20 09:28:11 +01:00
Håkon Hægland
93eda52576 Fix typo 2025-01-17 22:06:22 +01:00
Håkon Hægland
f867f9a977 Cleanup after rebase on master
After rebasing on master some changes to AdaptiveTimeStepping.hpp and
AdaptiveTimeStepping_impl.hpp were missed
2025-01-17 22:06:22 +01:00
Håkon Hægland
ac7e77bedb Remove duplicate headers 2025-01-17 22:06:22 +01:00
Håkon Hægland
18a03da1a8 Add doxygen comments
Convert comment blocks into doxygen type comments
2025-01-17 22:06:22 +01:00
Håkon Hægland
dfbafd9b23 Clearify that errhandler is a handle
It is safe to free the error handler after MPI_Comm_set_errhandler()
has been called
2025-01-17 22:06:22 +01:00
Håkon Hægland
46406a24d6 Use Dune::MPITraits to determine MPI datatype
Determine size of std::size_t correctly for all platforms using
Dune::MPITraits<std::size_t>::getType()
2025-01-17 22:06:22 +01:00
Håkon Hægland
89dc1930ef Mark GRUPSLAV and GRUPMAST as unsupported
Don't remove these entries from the map before reservoir coupling is
completely supported.
2025-01-17 22:06:22 +01:00
Håkon Hægland
407424544e Fix typo in Equinor ASA 2025-01-17 22:06:22 +01:00
Håkon Hægland
8da3c203f3 Do not check return values for MPI calls
The custom error handlers for each slave-master communicator will
handle errors in MPI_Recv() and MPI_Send() and eventually call
MPI_Abort(). So there is no need to check return values for these
MPI calls.
2025-01-17 22:06:22 +01:00
Håkon Hægland
afab98a5a4 Clarify how the timestep is selected
Clarify how the master timestep is computed based on the slaves next
report date or the slaves start date.
2025-01-17 22:06:22 +01:00
Håkon Hægland
00be5ed47e Conversion of std::time_t to double
Clarify the limits for conversion of std::time_t to double
2025-01-17 22:06:22 +01:00
Håkon Hægland
879fa72ce8 Eliminate TimePoint class
Make fuzzy comparison between two dates explicit.
2025-01-17 22:06:22 +01:00
Håkon Hægland
5ae50c90e1 Simplify storage of communicators
We don't need unique ptrs for the communicators. These are just simple
integers that can be copied into a std::vector.
2025-01-17 22:06:22 +01:00
Håkon Hægland
402bb85103 Enable building without MPI 2025-01-17 22:06:19 +01:00
Håkon Hægland
943d7fc2ce Enable start at any report step
Enable master and slaves to start at any report step. In the previous
commits, only first report step was supported.
2025-01-17 22:05:12 +01:00