Commit Graph

10475 Commits

Author SHA1 Message Date
Kai Bao
83bbe89342 LocalWellSolveControlSwitching default to be false 2023-09-29 10:55:19 +02:00
Kai Bao
e38e557bbc cleaning up to preapre for pull request 2023-09-29 10:55:19 +02:00
Stein Krogstad
035d216641 adding function iterateWellEqWithSwitching
when we do the local solve for well equations, control/status will be
updated during the iteration process, such that the converged well gets
correct control/status regarding to the current reservoir state.

various change in the other parts of the code were made to make the
function work as intended.
2023-09-29 10:51:04 +02:00
Bård Skaflestad
85bb525067 Match Region Sets by Unique Prefix
This commit switches the region set tag matching algorithm to using
unique prefixes.  This enables the simulator to recognise that the
region set name

    FIPUNI

should match up with the user defined region set 'FIPUNIT'.  In the
current master sources, the above summary vector would produce a
diagnostic message saying that the region set 'FIPUNI' (without the
final 'T') does not exist.

To this end, we instruct the ParallelEclipseState to always pass the
six character substring beginning with 'FIP' for FIP-like region
arrays and defer to the rank-0 EclipseState/FieldProps mechanism to
match this prefix with its canonical region set.
2023-09-28 17:54:27 +02:00
Bård Skaflestad
1e8441e8a9
Merge pull request #4528 from svenn-t/h2store
Enable WSF/GSF for H2STORE
2023-09-28 16:59:49 +02:00
Bård Skaflestad
09626f2e3a
Merge pull request #4525 from goncalvesmachadoc/co2store
keywords co2store + gaswat
2023-09-28 16:56:25 +02:00
Arne Morten Kvarving
eedfafe423 fixed: quell unused variable warning without OpenCL 2023-09-26 09:11:48 +02:00
Atgeirr Flø Rasmussen
8705cd16ad
Merge pull request #4884 from atgeirr/fix-typo-in-macro
Fix typo in macro usage.
2023-09-25 12:38:50 +02:00
Atgeirr Flø Rasmussen
e4e32defc4 Fix various errors and clean up the ISTLSolvers.
Much of this went undiscovered because the ISTLSolverEbosBda class
was not really used before due to the typo disabling it.
2023-09-25 09:03:59 +02:00
Markus Blatt
2721b9fa2d Fixes computation of temperature for distributed wells.
Previously, we did a global summation of the size of the
well_perf_data vector to determine the number of perforations
of a well. In the case of distributed wells this will try to access
more perforations than stored for the well in well_perf_data and hence
might use data from cells that actually are not perforated by this
cell. Note that for well not distributed the code worked as the
summation has no effect.

This commit changes this to only query peforations on the
local process. This should be enough to fix this problem.

In addition it removes the computation of connpos which is never used.
2023-09-22 18:56:27 +02:00
goncalvesmachadoc
7b6f813aae rebase 2023-09-21 16:50:41 +02:00
Atgeirr Flø Rasmussen
ad35b2a72f Adapt to changes made to ISTLSolverEbos. 2023-09-21 12:41:03 +02:00
Atgeirr Flø Rasmussen
7aa33058c4 Fix typo in macro usage. 2023-09-21 11:39:14 +02:00
Bård Skaflestad
cfd502c0f2
Merge pull request #4871 from svenn-t/cskin
Activate CSKIN and regression test
2023-09-21 11:24:19 +02:00
Atgeirr Flø Rasmussen
18f0d8fd27
Merge pull request #4859 from jcbowden/damariswriter-for-sim-fields-v4
Damaris - Moving Damaris functionality to it's own class
2023-09-20 09:06:48 +02:00
josh bowden
1e2d9360d7 Move Damaris functionality to it's own class.
Step one for moving Damaris calls out of EclWriter class and into its own DamarisWriter class;
EclProblem now calls both writeOutput methods and passes in the data::Solution object;

Add fix for first writeOutput() call not having PRESSURE data available;

data::Solution is now passed by rvalue ref into eclWriter::writeOutput();

guard added to prevent inclusion of damariswriter.hh
2023-09-19 21:20:08 +02:00
Bård Skaflestad
40927cb173
Merge pull request #4877 from GitPaean/bhp_lower_limit_below_1bar
reducing the bhp lower limit slightly to handle 1 bar bhp limit
2023-09-19 18:44:37 +02:00
Kai Bao
9d642fd7ce only outputting some network info to the rank 0 process 2023-09-19 16:17:19 +02:00
Kai Bao
f4a420d2f9 reducing the bhp lower limit slightly to handle 1 bar bhp limit
it turns out that 1bar is the default bhp constraint for some keywords,
   and some cases are depending on it.
2023-09-19 15:30:42 +02:00
Vegard Kippe
cc39e04180 Addresing review comments 2023-09-18 13:05:12 +02:00
Atgeirr Flø Rasmussen
a59920cee2
Merge pull request #4870 from blattms/print-missing-restart-file
Include name of missing OPM restart file in error.
2023-09-15 15:29:50 +02:00
Markus Blatt
b209f6af77
Merge pull request #4778 from aritorto/cellCentroid
Refactor element centroids lookup
2023-09-15 10:02:15 +02:00
Markus Blatt
81c9594f5d Include name of missing OPM restart file in error.
Otherwise it is hard to tell for the (newbie?) user what went wrong.
2023-09-14 16:10:42 +02:00
Svenn Tveit
7217201f18 Enable WSF/GSF for H2STORE 2023-09-14 12:42:47 +02:00
Alf Birger Rustad
91a670d796 PARAOPTS and SOLVDIRS should only give warning 2023-09-14 09:22:36 +02:00
Tor Harald Sandve
b55270defe
Merge pull request #4854 from vkip/gecon_closure_reason_group
Set GECON closure reason to GROUP, to not open with WTEST option 'E'.
2023-09-14 08:58:32 +02:00
Svenn Tveit
913ba450a7 Activate CSKIN 2023-09-14 08:52:05 +02:00
Bård Skaflestad
6f27ffa68d
Merge pull request #4862 from vkip/avoid_negative_relaxation_factor_fraction
Avoid fraction relaxation factors outside [0,1] (standard wells)
2023-09-13 16:45:11 +02:00
Bård Skaflestad
69e9bf624a
Merge pull request #4860 from GitPaean/not_relaxing_rate_update
removing rate relaxation during updateNewton for StandardWellPrimaryVariables
2023-09-13 15:31:44 +02:00
Atgeirr Flø Rasmussen
9206e8b3db
Merge pull request #4863 from bska/interior-cell-grid-view
Implement Interior Cell Counts for Grid Views
2023-09-13 12:24:00 +02:00
Kai Bao
b79e3a7de2 removing rate relaxation during updateNewton in StandardWellPrimaryVariables
it was introduced back then for some purpose. The purpose might not
apply anymore due to other development. And also, some issues were
reported for some situtation with the approach.
2023-09-13 12:16:58 +02:00
Atgeirr Flø Rasmussen
708401ca14
Merge pull request #4861 from hnil/fixed_msw_addwellcontricutions
fixed add-well-contributions for multisegement wells
2023-09-13 11:40:40 +02:00
Atgeirr Flø Rasmussen
3673c05242
Merge pull request #4848 from vkip/gconsump_mpi_fix
Avoid adding/substracting GCONSUMP values per MPI process..
2023-09-13 11:00:04 +02:00
Vegard Kippe
2b45785097 Using std::clamp 2023-09-12 12:52:41 +02:00
Bård Skaflestad
a2d43cd0f5 Implement Interior Cell Counts for Grid Views
This is mostly to prepare for implementing partitionCells() for
grid views instead of grids.
2023-09-12 12:37:10 +02:00
hnil
29e968c232 fixed add-well-contributions for multisegement wells 2023-09-12 09:49:15 +02:00
Vegard Kippe
4638b3a9be Avoid fraction relaxation factors outside [0,1] in the standard well model. 2023-09-12 00:20:02 +02:00
Vegard Kippe
a12f0aaa13 Set GECON closure reason to GROUP, to not open with WTEST option 'E'. 2023-09-08 11:16:11 +02:00
Vegard Kippe
dbd1d343e8 Avoid adding/substracting GCONSUMP values per MPI process.. 2023-09-07 14:14:56 +02:00
Bård Skaflestad
1d33e7caf0
Merge pull request #4806 from totto82/initBHPinj
initialize all injectors with a rate to avoid singularities
2023-09-07 14:06:23 +02:00
Bård Skaflestad
bb04054d2c
Merge pull request #4842 from totto82/wellPressGW
use gas pressure for gas-water system in the well model
2023-09-07 12:47:05 +02:00
Bård Skaflestad
467671b946
Merge pull request #4840 from totto82/solvent_well_fix
Solvent well fix
2023-09-07 12:45:56 +02:00
Tor Harald Sandve
79e0b7256a initialize all injectors with a rate to avoid singularities 2023-09-07 12:03:04 +02:00
Kai Bao
529af98ce9 setting uninitialized bhp to be bhp_limit in updateWellStateWithTarget
to avoid uninitialized bhp 0. to be used.
2023-09-07 08:50:37 +02:00
Bård Skaflestad
f32b8e17ed
Merge pull request #4815 from plgbrts/std-netw-gaslift
Add FLO as supported option of item 6 of GRUPNET
2023-09-06 14:51:51 +02:00
Tor Harald Sandve
8796fa1ccc use gas pressure for gas-water system in the well model 2023-09-06 13:46:18 +02:00
Tor Harald Sandve
e31b2f3492 don't use relaxation factor fraction in combination with solvent 2023-09-06 13:24:31 +02:00
Tor Harald Sandve
c239427233 add solvent contribution to the gas potential 2023-09-06 13:23:55 +02:00
Bård Skaflestad
27466bae66
Merge pull request #4834 from steink/assure_non_negative_oil_fraction
Prevent negative oil fractions in well segments
2023-09-06 12:44:21 +02:00
Atgeirr Flø Rasmussen
87b9dd3ec2
Merge pull request #4837 from bska/remove-unused-code
Remove Unused Functions
2023-09-06 09:09:54 +02:00
Bård Skaflestad
e6c2413d05 Remove Unused Functions
These functions became unused in commits 952ccf8338 and f027262ec4,
but their definitions remained in place.  We no longer need them.
2023-09-05 19:03:43 +02:00
Atgeirr Flø Rasmussen
8900962fd5
Merge pull request #4827 from jcbowden/damaris-fix-for-deadlock
Damaris fix for deadlock at end of simulation when run with Damaris
2023-09-05 14:28:32 +02:00
Stein Krogstad
7981253f39 prevent negative oil fractions 2023-09-05 11:18:16 +02:00
Atgeirr Flø Rasmussen
7327a6b429
Merge pull request #4260 from atgeirr/dynamic-linear-solver-choice
Support for multiple linear solvers.
2023-09-04 13:53:43 +02:00
Atgeirr Flø Rasmussen
cede2b4add Improving generality and output of hybrid approach. 2023-09-04 13:13:52 +02:00
Paul
1912faf47c Add FLO as supported option of item 6 of GRUPNET 2023-09-04 11:21:59 +02:00
Bård Skaflestad
9c58585538
Merge pull request #4823 from akva2/ecltimestepping_separate
changed: put ecl time stepping parameters in separate struct
2023-09-04 10:54:46 +02:00
Josh Bowden
6e4f3bd37e added changes as discussed in PR 4827 2023-09-01 18:28:03 +02:00
Tor Harald Sandve
80cbfe7fda
Merge pull request #4819 from hakonhagland/gecon3
Implement support for GECON keyword
2023-09-01 15:06:48 +02:00
Atgeirr Flø Rasmussen
079bf9323a
Merge pull request #4830 from jcbowden/damaris-hdf5-select-keyword
Damaris internal XML file update to support HDF5 local to global write.
2023-09-01 15:01:50 +02:00
Atgeirr Flø Rasmussen
efa50c3640 Check for multiple solvers before trying to use them. 2023-09-01 13:18:09 +02:00
Atgeirr Flø Rasmussen
758b4bbdb6 Use "hybrid" linear solver choice to get multi-option. 2023-09-01 13:18:09 +02:00
Franz Georg Fuchs
6ee90b3f8f Support for multiple linear solvers. 2023-09-01 13:18:06 +02:00
Josh Bowden
89d13e479c Update to the opm-flow internal Damaris XML to support the HDF5 select writing option so that local variable data is written to global variable position in HDF5 output 2023-09-01 12:02:04 +02:00
Håkon Hægland
b1274096e9 Added to partially supported keywords
Added GECON to the list of partially supported keywords
2023-09-01 11:29:18 +02:00
Atgeirr Flø Rasmussen
91c2e12a25 Document new input parameter. 2023-09-01 11:19:36 +02:00
Atgeirr Flø Rasmussen
583fb902d2 Guards communication parts inside HAVE_MPI. 2023-09-01 11:19:16 +02:00
Bård Skaflestad
c6e30fbf3c
Merge pull request #4820 from atgeirr/parallel-nldd-fixes
Fixes to enable using the NLDD nonlinear solver option in MPI parallel runs
2023-09-01 09:51:06 +02:00
Atgeirr Flø Rasmussen
99fca58dca Improvements from review. 2023-09-01 08:48:11 +02:00
Vegard Kippe
a75f58f19a Moved two lines 2023-08-31 16:11:29 +02:00
Vegard Kippe
deeecfcd1f Fixing indent 2023-08-31 16:11:28 +02:00
Vegard Kippe
edd421ac93 Adding hydrostatic and acceleration pressure losses to icd segments 2023-08-31 16:11:28 +02:00
Josh Bowden
84d3530fd9 fix for deadlock at end of simulation when run with Damaris and test for whether Damaris can be run as Damaris requires at least 2 MPI ranks (one for simulation and the other as to run Damaris i/o) 2023-08-31 15:51:34 +02:00
Atgeirr Flø Rasmussen
06c706e7d6 Also copy flags, and helper function with test. 2023-08-31 13:01:50 +02:00
Atgeirr Flø Rasmussen
151eac9110 Copy overlap data after local solve.
Also update intensive quantities in overlap afterwards.
2023-08-31 13:01:50 +02:00
Atgeirr Flø Rasmussen
961a5fa482 Avoid collective copyParValues() call in serial run. 2023-08-31 13:01:50 +02:00
Atgeirr Flø Rasmussen
e1dd2bf148 Add forceSerial parameter to ISTLSolverEbos.
Used for single-domain solves.
2023-08-31 13:01:50 +02:00
Atgeirr Flø Rasmussen
622103a367 Avoid collective operation in single-domain context. 2023-08-31 13:01:50 +02:00
Atgeirr Flø Rasmussen
609dfd6051 Only owned cells should be part of NLDD partitions. 2023-08-31 13:01:28 +02:00
Arne Morten Kvarving
3c525aefae changed: put ecl time stepping parameters in separate struct
this to allow reuse in ebos simulators
2023-08-30 11:22:22 +02:00
Kai Bao
f7bd386402 adding the support for filtration_summary_keywords 2023-08-29 21:31:24 +02:00
Stein Krogstad
e7a0dbacf2 don't do rate-init for stopped/zero target 2023-08-29 14:52:09 +02:00
Håkon Hægland
a5899f6f2f Added missing header file 2023-08-29 09:02:12 +02:00
Antonella Ritorto
5d9f8a88b4 LookUpCellCentroid used to search cell centroids in eclbasevanguard 2023-08-29 08:45:59 +02:00
Håkon Hægland
2f9b136bb1 Implement support for GECON keyword
Implement support for item 2 and 3 of the GECON keyword
2023-08-29 01:07:21 +02:00
Vegard Kippe
f5c31588cb Quick fix.. 2023-08-25 14:01:51 +02:00
Paul
d4743ed4a5 item 7 added to partially supported keywords 2023-08-23 16:24:35 +02:00
Paul
5780aa8d38 add regression test 2023-08-23 16:24:35 +02:00
Paul
dcba4d9496 Add GRUPNET to partially suppported keywords 2023-08-23 16:24:35 +02:00
Paul
893568fd64 removed GRUPNET from unsupported keyword list 2023-08-23 16:24:35 +02:00
Bård Skaflestad
b772d685d3
Merge pull request #4781 from totto82/addToEvent
Include production/injection update as timestepping event
2023-08-23 15:40:38 +02:00
Kai Bao
6d011131cd UDQ for the injection concentration for WINJFCNC 2023-08-23 11:44:50 +02:00
Vegard Kippe
f762711111 Addressing review comment (removed blank line and updated SaveStep docstring) 2023-08-22 17:11:54 +02:00
Vegard Kippe
ac27c5fc86 Extended serialization to have negative stride mean 'only save last' + allow loading from different file than saving to. 2023-08-22 14:16:20 +02:00
Atgeirr Flø Rasmussen
ecfe98dd3d
Merge pull request #4758 from hnil/subdomain_updates
moved fully implicit calls to opm-simulators
2023-08-18 08:18:58 +02:00
Markus Blatt
b4e7a4fc85
Merge pull request #4770 from akva2/eclproblem_cleanup_timestepping
EclProblem: cleanup time stepping related members
2023-08-17 11:19:55 +02:00
Arne Morten Kvarving
290c783f83 SimulatorFullyImplicitBlackoilEbos: remove unused member 2023-08-16 08:58:08 +02:00
Arne Morten Kvarving
13b0e14f18 EclGenericProblem: remove unused time steppping parameters
and remove some hidden duplicates
2023-08-15 14:02:55 +02:00
Bård Skaflestad
ba6fc03fa3
Merge pull request #4797 from akva2/eclinterregflows_move
changed: move EclInterRegFlows to opm/simulators/flow
2023-08-15 13:53:19 +02:00
Bård Skaflestad
118acff2ed
Merge pull request #4796 from akva2/janitoring
Bda: mark some more parameters maybe_unused
2023-08-15 13:44:15 +02:00