Arne Morten Kvarving
48fa0f3c59
drop macro EWOMS_REGISTER_PARAM
2024-04-05 10:05:30 +02:00
Arne Morten Kvarving
22a5aab10e
Parameters::registerParam: grab name from struct
...
optionally allow a member to override
2024-04-05 10:03:36 +02:00
Arne Morten Kvarving
069161bd84
Parameters::registerParam: pass Property struct and use parameter type from its definition
2024-04-05 10:03:36 +02:00
Bård Skaflestad
2066977c8f
Merge pull request #889 from akva2/fix_inconsistent_params
...
fixed: inconsistent parameter setups
2024-04-04 17:50:26 +02:00
Arne Morten Kvarving
6103383c1a
fixed: inconsistent parameter setups
...
registered as int and obtained as unsigned, or registered
as Scalar and obtained as int
2024-04-04 14:34:37 +02:00
Arne Morten Kvarving
8b02ba2efc
Parameters::registerParam: remove propertyName
...
it is always the same as paramName
2024-04-04 12:51:07 +02:00
Bård Skaflestad
2fea434f9a
Merge pull request #887 from akva2/remove_hide_param_macro
...
remove EWOMS_HIDE_PARAM macro
2024-04-04 09:21:03 +02:00
Arne Morten Kvarving
b3090888b5
remove EWOMS_HIDE_PARAM macro
...
it adds no simplicity and only obfuscates
2024-04-04 08:17:16 +02:00
Arne Morten Kvarving
f22f51a833
Parameters::hideParam: remove unused parameter
2024-04-04 08:17:16 +02:00
Bård Skaflestad
8370e90f44
Merge pull request #886 from akva2/remove_macro_ewoms_get_param_lists
...
remove EWOMS_GET_PARAM_LISTS macro
2024-04-03 23:42:19 +02:00
Arne Morten Kvarving
399e39b31b
remove EWOMS_GET_PARAM_LISTS macro
...
it adds no simplicity and only obfuscates
2024-04-03 22:35:40 +02:00
Bård Skaflestad
a2ff5e98ee
Merge pull request #885 from akva2/remove_ewoms_param_is_set_macro
...
remove macro EWOMS_PARAM_IS_SET macro
2024-04-03 21:46:25 +02:00
Bård Skaflestad
8044bd3136
Merge pull request #884 from akva2/remove_end_param_macro
...
remove EWOMS_END_PARAM_REGISTRATION macro
2024-04-03 21:45:24 +02:00
Arne Morten Kvarving
4f6bc9280d
remove macro EWOMS_PARAM_IS_SET macro
...
it simplifies nothing, only obscures.
remove unused different propTagName and use paramName.
2024-04-03 19:54:10 +02:00
Arne Morten Kvarving
783eaa2882
remove EWOMS_END_PARAM_REGISTRATION macro
...
it adds no simplicity and only obfuscates
2024-04-03 16:23:21 +02:00
Bård Skaflestad
81c62e18f2
Merge pull request #883 from akva2/remove_reset_params
...
Remove unused EWOMS_RESET_PARAMS macro
2024-04-03 16:21:43 +02:00
Arne Morten Kvarving
0da838faa3
remove unused macro EWOMS_RESET_PARAMS_
2024-04-03 13:39:46 +02:00
Arne Morten Kvarving
967738ee91
use OPM, not EWOMS in header guard
2024-04-03 13:39:46 +02:00
Bård Skaflestad
6fd995caab
Merge pull request #882 from akva2/remove_propsystem_macros
...
remove last remnants of property system macros
2024-03-22 13:09:38 +01:00
Arne Morten Kvarving
0d9312b5ee
remove last remnants of property system macros
...
these have been deactivated for years
2024-03-22 12:11:55 +01:00
Bård Skaflestad
45dd41185f
Merge pull request #881 from GitPaean/changing_include_guard_name_diffusion
...
changing including guard name for two diffusionmodule
2024-03-21 16:44:24 +01:00
Kai Bao
1898a1681b
changing including guard name for two diffusionmodule
...
they used to use the same EWOMS_DIFFUSION_MODULE_HH
2024-03-21 15:11:42 +01:00
Arne Morten Kvarving
99ac834401
fixed: initialize meaning variables
...
in particular the solventMeaning can lead to
out-of-bounds dereferences in updatePrimaryVariables
2024-03-11 14:40:22 +01:00
Kai Bao
6f9ab6189f
Merge pull request #875 from akva2/adjust_outputmodule
...
adjust to output module accessor change
2024-03-05 23:31:34 +01:00
Arne Morten Kvarving
866a1f43b6
Merge pull request #878 from bska/maybe-unused-parameters
...
Tag Certain Parameters As Maybe-Unused
2024-03-01 15:01:45 +01:00
Bård Skaflestad
2b0d9a7d55
Tag Certain Parameters As Maybe-Unused
...
These parameters get referenced only in certain configurations.
2024-03-01 12:03:11 +01:00
Atgeirr Flø Rasmussen
cdc86b46df
Merge pull request #874 from totto82/fixNNCFlows
...
Fix Flows/Flores for NNCs
2024-02-12 20:45:37 +01:00
Tor Harald Sandve
e6c8eedeb8
Fix Flows/Flores for NNCs
2024-02-12 15:57:50 +01:00
Arne Morten Kvarving
c76c3b8fc6
adjust to output module accessor change
2024-02-12 12:05:33 +01:00
Atgeirr Flø Rasmussen
edbe1a113a
Merge pull request #873 from blattms/nnc-fix-flows-flores
...
[bugfix] Do not try to save FLOWS or FLOWRES values for NNCs.
2024-02-07 11:50:40 +01:00
Markus Blatt
57da17b591
[bugfix] Do not try to save FLOWS or FLOWRES values for NNCs.
...
If we would try that then we would index vectors with index -1 and
possibly overwriting other system information. This was the case for
some models resulting in cryptic errror " corrupted size vs. prev_size"
Now we simply do nothing for NNCs.
2024-02-06 16:06:11 +01:00
Tor Harald Sandve
d0951e83ff
Merge pull request #869 from totto82/vapwatdiff
...
Enables diffusion of water in gas phase
2024-02-06 14:57:31 +01:00
Bård Skaflestad
e503d2f2dc
Merge pull request #872 from akva2/janitoring
...
add missing include
2024-02-06 13:01:56 +01:00
Arne Morten Kvarving
feec519be8
add missing include
2024-02-06 10:40:35 +01:00
Tor Harald Sandve
2d697eb240
Enables diffusion for vapporized water
2024-02-05 09:09:57 +01:00
Tor Harald Sandve
4c8d6b5a22
Merge pull request #868 from totto82/massFractionDiffusion
...
Add mass fraction diffusion coefficients
2024-02-05 08:48:40 +01:00
Tor Harald Sandve
521de7a6e5
Add mass fraction diffusion coeficients
2024-02-02 16:02:24 +01:00
Tor Harald Sandve
5f7180b1f8
Merge pull request #870 from totto82/fixOutputDisp
...
Only output warning if dispersion is activated
2024-02-01 11:54:21 +01:00
Tor Harald Sandve
fe1a488e77
Only output warning if dispersion is activated
2024-02-01 09:28:33 +01:00
Markus Blatt
3aa2e0969f
Merge pull request #864 from lisajulia/feature/deterministic-indicesSyncer
...
Construct the matrices in the AMG hierarchy with deterministic indices if possible.
2024-01-29 13:59:44 +01:00
Tor Harald Sandve
d5d7ad2d20
Merge pull request #866 from totto82/fixSolventRs
...
BUGFIX allow for solvent flux when disgasw
2024-01-26 12:08:08 +01:00
Tor Harald Sandve
14786bcba5
BUGFIX allow for solvent flux when disgasw
2024-01-26 10:35:05 +01:00
Tor Harald Sandve
d1e8be32c1
Merge pull request #865 from daavid00/fixthermalbc
...
Thermal BC for spe11bc
2024-01-26 10:26:33 +01:00
David Landa Marban
e513e3deb6
Thermal BC for spe11bc
2024-01-26 09:08:16 +01:00
Lisa Julia Nebel
5d8fefca33
Add comment on trailing return type with decltype that is used for detecting existence of setUseFixedOrder member function
2024-01-25 16:04:41 +01:00
Lisa Julia Nebel
b99252e2b8
Construct the matrices in the AMG hierarchy with deterministic indices if possible.
...
The function 'setUseFixedOrder' is called if it is defined and the matrices in the AMG hierarchy are constructed with deterministic indices.
If its not defined yet, it is not called and the matrices in the AMG hierarchy are constructed with non-deterministic indices.
2024-01-25 11:32:51 +01:00
Atgeirr Flø Rasmussen
ec8f84429e
Merge pull request #859 from totto82/nodispgas
...
ignore dispersion in gas phase
2024-01-23 09:25:33 +01:00
Atgeirr Flø Rasmussen
2ca9dc5526
Merge pull request #786 from hnil/scaled_blackoil_new
...
- based on earlier pullrequest which is outdated reintroduced pressur…
2024-01-19 10:43:53 +01:00
Halvor Møll Nilsen
f858b65602
Merge pull request #5 from atgeirr/hnil-scaled_blackoil_new
...
Fix compile errors for non-blackoil models.
2024-01-19 09:27:51 +01:00
Atgeirr Flø Rasmussen
073fe7594a
Fix compile errors for non-blackoil models.
...
Also fix minor nitpicks.
2024-01-19 09:08:17 +01:00