Bård Skaflestad
61ac76fe90
Make ARGV[ARGC] Into a Nullpointer
...
This is strictly speaking required by POSIX.
2021-10-09 00:17:32 +02:00
Bård Skaflestad
ad74de2e1a
Use Algorithm to Locate '--version' Option
2021-10-09 00:17:32 +02:00
Bård Skaflestad
fca167acfd
Split Individual Cases Out to Helper Functions
...
This commit moves the bodies of the various 'dynamicDispatch_<>()'
cases out to separate helper functions. Not only does this reduce
the number of nested conditionals, it also helps reasoning about
each case in isolation and aids future maintenance.
2021-10-09 00:17:32 +02:00
Bård Skaflestad
3455dbdac9
Main.hpp: Adjust Whitespace
...
In preparation of refactoring 'dispatchDynamic_<>()'
2021-10-09 00:17:32 +02:00
Markus Blatt
ed73f1b326
Merge pull request #3592 from blattms/fix-3574
...
remove assert for isfinite and correctly handle exceptions
2021-10-08 21:18:18 +02:00
Joakim Hove
4da52424c7
Add const
2021-10-08 20:58:49 +02:00
Markus Blatt
fc7609bfd2
[bugfix] Make sure all ranks participate in collective communication.
...
No need an early return if there are no local wells, anyway. The
algorithms can handle empty containers like a charm.
2021-10-08 16:01:18 +02:00
Markus Blatt
1520f9c85f
[bugfix] handle exception when linearizing the wells.
...
As multisegment wells may throw in applyUMFPack this is now needed and
the exception needs to communicated to all processes. We do this in
the linearize method of the well model.
Before this change this is what could happen:
- The process with the exception would have chopped the time step
- The others would have successfully setup the systems and entered the
linear solve
This poduced a deadlock. One processes was waiting in
OPM_END_PARALLEL_TRY during the setup of the shorter time step and in
collective communication during the setup of the linear solver for the
unchopped time step.
2021-10-08 16:01:07 +02:00
Tor Harald Sandve
d07aed204f
Catch numerial issues due to problems with inner iterations wells
2021-10-08 15:26:53 +02:00
Tor Harald Sandve
fdf6ce9c54
change assert with throw for isfinite primary variable
2021-10-08 15:26:52 +02:00
Joakim Hove
0ca1f7a8b2
WellTestState::updateWells -> WellTestState::test_wells
2021-10-08 15:23:03 +02:00
Joakim Hove
0e9d634397
Do not pass ecl wells to WellTestState::updateWells()
2021-10-08 15:17:43 +02:00
Joakim Hove
c599402318
Merge pull request #3591 from joakim-hove/welltest-state-rename
...
Welltest state rename
2021-10-08 14:07:04 +02:00
Bård Skaflestad
bfdf158e23
Merge pull request #3589 from bska/remove-unused-parameter
...
Remove Unused 'Comm' Parameter
2021-10-08 13:02:13 +02:00
Bård Skaflestad
d028937925
Remove Unused 'Comm' Parameter
...
Remnant from ealier refactoring work.
2021-10-08 12:44:27 +02:00
Joakim Hove
0e365abe36
WellTestState::dropCompletion -> WellTestState::open_completion
2021-10-08 10:40:38 +02:00
Joakim Hove
0648d6bf5d
WellTestState::openWell -> WellTestState::open_well
2021-10-08 10:17:14 +02:00
Joakim Hove
d806762f7a
WellTestState::hasWellClosed -> WellTestState::well_is_closed
2021-10-08 10:17:14 +02:00
Joakim Hove
52b2c096a2
WellTestState::closeWell -> WellTestState::close_well
2021-10-08 10:17:14 +02:00
Tor Harald Sandve
40e94268cf
Merge pull request #3578 from bska/reset-actnum-eclipsestate
...
Reset ACTNUM at EclipseState Level
2021-10-08 09:51:54 +02:00
Joakim Hove
e194223631
Merge pull request #3582 from bska/refactor-readDeck
...
Extract Helper Functions From readDeck
2021-10-08 09:49:57 +02:00
Joakim Hove
feaaebf3fc
WellTestState::hasCompletion -> WellTestState::completion_is_closed
2021-10-08 09:06:21 +02:00
Bård Skaflestad
1feab761d6
Extract Helper Functions From readDeck
...
Mostly to reduce the number of nested conditionals and long lines.
2021-10-07 22:01:47 +02:00
Bård Skaflestad
c7d7fa1146
Reset ACTNUM at EclipseState Level
...
This method avoids resorting to const_cast tricks.
2021-10-07 21:58:09 +02:00
Markus Blatt
d4ab9ea4b1
[refactor] Use well_container and PerforationData for tracers
...
This saves some (expensive?) lookups that already have been done
in the well model. We had to make the well_container accessible from
the well model for this.
Using the perforation data will automatically make sure that the
perforations are not shut and reside on this process in a parallel run.
2021-10-07 21:55:41 +02:00
Bård Skaflestad
9cde5ec9e7
Merge pull request #3572 from bska/prune-deactivated-anconn
...
Prune Analytic Aquifer Connections to Deactivated Cells
2021-10-07 21:02:53 +02:00
Bård Skaflestad
c329d9cd00
Prune Deactivated Cells on All Ranks
...
This commit broadcasts the 'removed_cells' to all ranks and uses
that array to delete any analytic aquifer connections that might
have been previously formed to those deactivated cells. This is
needed to have a consistent view of which cells are connected to
analytic aquifers.
2021-10-07 17:26:26 +02:00
Bård Skaflestad
f01777610f
Adjust Whitespace and Rewrap Comments
...
In preparation of distributing the 'removed_cells' to all ranks.
2021-10-07 17:26:26 +02:00
Markus Blatt
f2ce097b4b
Merge pull request #3575 from Tongdongq/fix-ilu-decomp-gpu
...
Create and use scale kernel for relaxation of ILU
2021-10-07 15:55:17 +02:00
Joakim Hove
e0ea090960
WellTestState::addClosedCompletion - WellTestState::close_completion
2021-10-07 14:56:20 +02:00
Joakim Hove
ce78326ac1
WellTestState::openAllCompletions -> WellTestState::open_completions
2021-10-07 14:53:06 +02:00
Joakim Hove
0c40771c7a
Merge pull request #3579 from joakim-hove/template-on-content-type
...
WTEST: only count actually closed wells.
2021-10-07 09:27:41 +02:00
Markus Blatt
011fb1034e
Merge pull request #3571 from atgeirr/allow-non-world-comm
...
Replacing use of MPI_COMM_WORLD with a variable communicator.
2021-10-06 15:52:17 +02:00
Joakim Hove
4816762b66
Well testing: only count actually closed wells. Change in opm-common
2021-10-06 15:32:17 +02:00
Joakim Hove
eb2ca4798c
Templatize over content type instead of full argument type
2021-10-06 12:11:44 +02:00
Atgeirr Flø Rasmussen
7e5cd73254
Set communication object before constructing vanguard.
2021-10-06 08:52:19 +02:00
Atgeirr Flø Rasmussen
09a5320e21
Silence unused variable warning.
2021-10-06 08:52:06 +02:00
Atgeirr Flø Rasmussen
e519bb32ec
Use correct communicator in EclGenericVanguard::init().
2021-10-06 08:51:31 +02:00
Joakim Hove
be787b8e14
Merge pull request #3577 from joakim-hove/wtest-state-refactor
...
Use plain WellTestState::hasWellClosed() without reason
2021-10-05 17:47:10 +02:00
Joakim Hove
f27a82ebc3
Use plain WellTestState::hasWellClosed() without reason
2021-10-05 16:52:16 +02:00
Atgeirr Flø Rasmussen
d1391de639
Minor whitespace fixes.
2021-10-05 13:59:16 +02:00
Elyes Ahmed
65f0e4e7f0
Replacing calling Communication with a header
2021-10-05 13:07:52 +02:00
Elyes Ahmed
0202b00d59
clean up after review
2021-10-05 13:07:52 +02:00
Elyes Ahmed
f53c597f90
Replacing use of MPI_COMM_WORLD with a variable communicator.
2021-10-05 13:07:52 +02:00
Tor Harald Sandve
033995ab8f
Merge pull request #3565 from blattms/centroids-vanguard
...
[refactor] Move cell centroid lookup magic to vanguard for reuse.
2021-10-05 11:38:19 +02:00
Tong Dong Qiu
68adf85f52
Create and use scale kernel for relaxation of ILU
2021-10-05 10:49:21 +02:00
Alf Birger Rustad
61ef539bf5
Merge pull request #3473 from akva2/regression_restart_tests
...
Add support for regression restart tests
2021-10-05 09:07:19 +02:00
Joakim Hove
b0fbc1a6dc
Merge pull request #3570 from joakim-hove/add-wtest-state-arguments
...
2: Add wtest state arguments
2021-10-05 07:31:39 +02:00
Joakim Hove
dcd5fc76a0
Add WellTestState argument when calling IO routines
2021-10-04 21:30:27 +02:00
Joakim Hove
9a9ff39908
Merge pull request #3566 from joakim-hove/collect-wtest
...
1: Pack and unpack WellTestState in CollectIO class
2021-10-04 20:40:36 +02:00