Bård Skaflestad
9344423d04
Varnish EclWriter::beginRestart() Implementation
...
In particular,
- Split some long lines
- Mark objects 'const' where possible
- Reduce scope of objects
- Add braces to single statement control structures
- Prefer pre-increment
- Prefer type deduction for induction variables
2024-10-10 11:35:21 +02:00
Vegard Kippe
a2882dc0c8
Resetting WINJMULT dampening factors before fixed BHP calculations
2024-10-10 09:25:28 +02:00
Vegard Kippe
5d1b29ac72
Account for param_ move to parent class
2024-10-08 15:49:11 +02:00
Vegard Kippe
ac5de96ad4
Add dampening to the injectivity multipliers (WINJMULT)
2024-10-08 15:49:10 +02:00
Kai Bao
cfac494507
Merge pull request #5627 from vkip/fc_clean
...
Handle cleaning of filter cake in a more intuitive way
2024-10-08 13:54:14 +02:00
Vegard Kippe
a62a326cfa
Removing unnessary arrays and eliminate some code duplication
2024-10-08 11:47:47 +02:00
Bård Skaflestad
6a7efcbcaa
Merge pull request #5645 from kjetilly/flowexp_components
...
Support for 2 to 7 components in flowexp_comp
2024-10-08 09:25:08 +02:00
Vegard Kippe
ca9cad3f07
Properly update multipliers after cleaning, and ensure that the cleaning occurs before the multipliers are applied to the well.
2024-10-07 19:35:10 +02:00
Vegard Kippe
136bd93fd6
Fix linear case
2024-10-07 19:35:10 +02:00
Vegard Kippe
e19063d957
Fix 'off-by-a-step' error in filter cake cleaning + refactor slightly
2024-10-07 19:35:10 +02:00
Vegard Kippe
60d622fa12
Handle cleaning of filter cake in a more intuitive way, also report actual thickness for radial case
2024-10-07 19:35:10 +02:00
Bård Skaflestad
779522fff1
Enable EQUALREG for Array Operations
...
The keyword's implementation has reached a point where we can
justify its addition to the simulator's feature set.
2024-10-06 15:22:37 +02:00
Markus Blatt
ed0e37e31d
Merge pull request #5577 from blattms/feature/full-pinch-option-4-all
...
Correctly treat transmissibilities for PINCH option(4) ALL.
2024-10-04 16:45:46 +02:00
Arne Morten Kvarving
55c42d7b83
one translation unit per instance
2024-10-04 14:45:34 +02:00
Bård Skaflestad
0b94f11b5c
Merge pull request #5625 from GitPaean/zmf_supporet
...
supporting ZMF explicit solution
2024-10-04 09:16:25 +02:00
Markus Blatt
a04b73d554
Merge pull request #5646 from vkip/actually_USE_fixed_order
...
Actually use fixed ordering (to get reproducible results in parallel)
2024-10-04 08:22:58 +02:00
Atgeirr Flø Rasmussen
9654215223
Merge pull request #5590 from jakobtorben/convergence_monitors
...
Convergence monitors
2024-10-04 08:21:03 +02:00
Vegard Kippe
099dabd8a9
Actually update the criterion to use fixed ordering..
2024-10-04 00:09:04 +02:00
jakobtorben
b830208573
PR review changes
2024-10-03 18:05:06 +02:00
Kai Bao
29deffda26
addressing reviewing comments for PR OPM/opm-simulators#5625
2024-10-03 16:06:23 +02:00
Stein Krogstad
5713c68992
Add option to check group constraints during local well solve - set default to true
2024-10-03 11:36:17 +02:00
jakobtorben
ff20c1f809
Fix calculation of distance
2024-10-03 08:56:39 +02:00
jakobtorben
6ff83e19ae
Write penalty count to infoiter file
2024-10-03 08:56:39 +02:00
jakobtorben
71a64fbd13
Ensure correct propagation of failed report
2024-10-03 08:56:39 +02:00
jakobtorben
6d53daaa42
Store report of failed step before cutting from convergence monitoring
2024-10-03 08:56:39 +02:00
jakobtorben
eef0ba50bf
Change non-convergence monitor to checking if number of non-converged has increased
2024-10-03 08:56:39 +02:00
jakobtorben
cda47a6387
Register convergence monitoring parameters
2024-10-03 08:56:39 +02:00
jakobtorben
5f17c9de6a
Cut timestep if penlaty exceeds limit
2024-10-03 08:56:39 +02:00
jakobtorben
d476a328de
Add distance decay penalty
2024-10-03 08:56:39 +02:00
jakobtorben
3e6f9c52bb
Reset the total penalty card after each nonlinear iteration
2024-10-03 08:56:39 +02:00
jakobtorben
e1e577fab1
Add penalty for unconverged well
2024-10-03 08:56:39 +02:00
jakobtorben
56da84517b
Add well convergence metric
2024-10-03 08:56:39 +02:00
jakobtorben
861cfeec49
Add penalty card for increase in convergence metrics
2024-10-03 08:56:39 +02:00
jakobtorben
988ca3aa60
Add object to keep track of penalty cards for convergence monitoring
2024-10-03 08:56:39 +02:00
Kai Bao
562da9ef70
support ZMF explicit initialization
2024-10-02 22:08:19 +02:00
Bård Skaflestad
120b39a8f9
Fix Lower Bound Conditions for Three Point Checks
...
These are supposed to verify that the displacing saturation is
strictly between the critical and the maximum saturation values.
2024-10-02 12:33:22 +02:00
Kai Bao
69c6294978
set newton tolerance to be 1.e-7 for compositional running
2024-10-01 15:54:25 +02:00
Bård Skaflestad
919f30029f
Merge pull request #5635 from akva2/dont_store_sched_deck
...
changed: don't store schedule keywords unless required in simulators
2024-10-01 13:12:21 +02:00
Markus Blatt
e743f2aa1e
Skip bogus warning about missing cells for PINCH NNCs
...
Cells are only missing if both are in the ghost overlap layer.
In this case we do not have a connection here to keep the matrix
more sparse.
2024-10-01 11:15:11 +02:00
Markus Blatt
9e31831917
[Cleanup] Adapt to changed return values from PINCH processing.
2024-10-01 11:15:11 +02:00
Markus Blatt
4b3808fa93
[Refactor] Adapt to PINCH NNC separated from the normal ones.
...
This is also a preparation for correct MULTZ processing.
2024-10-01 11:15:11 +02:00
Markus Blatt
a56526607c
Remove unneeded parameter from applyAllZMultipliers_
2024-10-01 11:15:11 +02:00
Markus Blatt
e816ae4df3
Correctly treat transmissibilities for PINCH option(4) ALL.
...
In that case processEclipseFormat will create NNCs over the pinched
out cells with correct transmissibilities. Those NNCs are marked as
being created in PINCH and used to overwrite calculated
transmissibilties for the horizontal intersections (transmissibilities
of normal NNCs are usually added).
Note that the trnasmissibilities (without the multipliers) do not
change later. Only the multipliers can change them in the schedule and
that will still happen.
2024-10-01 11:15:11 +02:00
Atgeirr Flø Rasmussen
47e7c7c5a3
Merge pull request #5630 from ElyesAhmed/fix_sfc_order_alugrid
...
add changes to fix the order
2024-10-01 10:06:17 +02:00
Arne Morten Kvarving
2353ba56a6
changed: don't store schedule keywords unless required in simulators
...
in the python simulator we cannot make this decision up front
since the schedule can be modified from python code so we have
to do the safe thing
2024-09-27 11:24:20 +02:00
Stein Krogstad
cb22d63cfe
In updateThp always compute thp when vfp is active
2024-09-26 21:06:05 +02:00
Elyes Ahmed
265c7b8520
cleanup and removing wrong instructions
2024-09-26 10:27:13 +02:00
Bård Skaflestad
fc578bad7f
Merge pull request #5632 from atgeirr/speed-up-numerical-aquifers
...
AquiferNumerical: speed up calculations.
2024-09-25 21:11:32 +02:00
Atgeirr Flø Rasmussen
6bb3331774
AquiferNumerical: speed up calculations.
...
There is no need to update the stencil if we are skipping the cell.
Also, the extensive quantities will not change while iterating over
the neighbours, so that update can be moved out of the loop.
2024-09-25 20:10:23 +02:00
Elyes Ahmed
6c2e957df0
add changes to fix the order
...
enabling reordering as default
2024-09-25 10:26:02 +02:00
