In particular, we now need to pass a flag that says whether or not
any of the run's well lists have changed since the previous report
step. If so, the well specification report will emit a sheet
detailing the contents of all of the run's current well lists.
In particular, favour calling member functions on
ScheduleState::wells to retrieve references to individual well
objects given a name instead of using Schedule::getWells() or
Schedule::getWellsAtEnd(). While convenient, these functions
introduce needless copies of all well objects stored in the Schedule
object. This commit instead, where possible, uses the somewhat less
convenient ScheduleState::well_order() accessor and then accesses
individual wells by name.
To this end, change BlackoilWellModelGeneric::not_on_process_ from a
function taking a well and returning a bool into a function taking a
well name and returning a bool.
This achieves two goals
1. It ensures proper sequencing with respect to other PRT file
reports.
2. It simplifies generating WELSPECS reports in restarted
simulation runs.
If rate that is the nominator is zero just store zero instead of
dividing it by another rater that might also be zero.
Makes searching for other nans more easy.
In particular, switch to get_group_var() and get_well_var() instead
of the lower-level 'get()' function as the way to retrieve summary
values and replace lambdas called once with the actual logic.
Finally, switch to using named indices into the 'values' vector to
make the expressions (slightly) more readable.
We accomplish that by passing the module version as a string to the
constructors of LogOutputHelper and EclGenericOutputBlackoilModel
instead of calling moduleVersionName() in LogOutputHelper. That way
moduleVersionName is not needed by libopmsimulators anymore and
compilation works again for people requesting shared libraries via
CMake's BUILD_SHARED_LIBS variable.
There is no need to restrict PRT file flow reports to those wells
which are active on the current rank since the SummaryState object
holds information for all wells active at the current report step.
This commit splits the production, injection, and cumulative
*Report_() functions into three logically distinct parts, one for
outputting the report header (begin*Report_()), one for outputting a
single report record (output*ReportRecord_()), and one for ending
the report (end*Report_()). This simplifies the logic of the
*Record_() member functions since they no longer need to infer the
context which is already available in the caller and can perform a
more narrow task than before.
With this separation we're also able to remove the dashed lines
which would previously separate each report record, thereby creating
PRT file report sheets which have a more expected layout.
Moreover, as an aid to future maintenance, we also factor out common
code for the well and group cases in each *Record_() function.
Finally, fix a unit conversion problem in the report values for
cumulative gas quantities. The sheet header states that we should
be outputting values in 'MM' prefixed units, but we were only
scaling the gas values by a factor of 1000 instead of 1000*1000. In
other words, the injection and production gas values in the
cumulative sheet were off by a factor of 1000.
The StreamLog::addMessageUnconditionally() member function will end
each message with a newline (std::endl) so we should not add such
newlines ourselves. The extra newline characters produce spurious
blank lines in the report sheets, e.g., for the "PRODUCTION REPORT".
This commit removes the last newline character from each report
request, thus deferring that responsibility to OpmLog::note()
instead. Doing so, however, means we have take a little more care
with the first line of each report lest we create report sheets
which are smushed together.
Bård Skaflestad
tskille
David Landa Marban
Lisa Julia Nebel
Arne Morten Kvarving
Markus Blatt
Tor Harald Sandve
Torbjørn Skille