OilfieldToolsNet/opm-simulators
4
0
Fork 0
mirror of https://github.com/OPM/opm-simulators.git synced 2025-02-25 18:55:30 -06:00
Code Issues Packages Projects Releases Wiki Activity
20,972 Commits 24 Branches 102 Tags 90 MiB
c06d89b068
Commit Graph

1272 Commits

Author SHA1 Message Date
Arne Morten Kvarving
a51e13c244 blackoilbrineparams: introduce translation unit 
move code for loading parameters from eclipse state into it
 2024-09-04 09:02:17 +02:00
Bård Skaflestad
a73cb6ee93 Fix DRVDT Initialisation Conditional 
It does not make sense to pass

    episodeIdx && maxDRv_.empty()

as an argument to drvdtActive().
 2024-08-30 15:16:46 +02:00
Atgeirr Flø Rasmussen
58ce7cbc7c
Merge pull request #5556 from akva2/float_support5 
Float support in simulators: Batch 5
 2024-08-30 15:06:35 +02:00
Atgeirr Flø Rasmussen
9dd54fb11a Avoid capturing structured bindings. 
This is an error before C++20, and clang refuses it.
 2024-08-30 13:17:07 +02:00
Kai Bao
f47d00c9d7
Merge pull request #5236 from hnil/no_early_exit_zero_flux 
Avoid deleting derivative i.e. getting "wrong" matrix in case of zero…
 2024-08-29 14:46:09 +02:00
Vegard Kippe
eb869f211f Avoid time step dependent jump in RS after restart 2024-08-28 16:28:51 +02:00
Vegard Kippe
0b6dd93903 Avoid negative time step size after restart (trouble for DRSDT init) 2024-08-28 15:04:15 +02:00
Vegard Kippe
0485bfb47f Set correct episode before initial call to invalidateAndUpdateIntensiveQuantities 2024-08-28 15:04:15 +02:00
Vegard Kippe
8f45cbe4c4 Properly initialize mixing controls after restart. 2024-08-28 15:04:15 +02:00
Vegard Kippe
cc08df226e Update after merging #5527 2024-08-28 15:04:15 +02:00
Bård Skaflestad
9dca8256f3 Split Request Writing Into Stages 
This commit introduces helper functions for each individual part of
a convergence report record in the INFOITER file.  In particular, we
create helpers for

  - Time related columns (report step, time step, time &c)
  - CNV pore-volume histogram columns
  - Reservoir convergence metrics (CNV and MB values per phase)
  - Well convergence metrics

This makes the body of the main loop in writeConvergenceRequest()
slightly easier to read and means that we can apply some additional
logic to the CNV pore-volume histograms if the number of values does
not match the expected 3 per type.  In that case we output sentinel
values (e.g., NaN and -1) to signify that the corresponding pieces
of information are unavailable.
 2024-08-27 10:50:06 +02:00
Bård Skaflestad
68cc5d917e Output CNV Histogram to INFOITER File 
This commit tracks the number of cells and their associate fraction
of the model's "eligible" pore volume (total pore volume in
numerical aquifers subtracted from the model's total pore volume) in
three distinct categories as a function of the non-linear iteration
number:

  - 0: MAX_p { CNV_p } <= strict CNV tolerance
  - 1: MAX_p { CNV_p } \in (strict, relaxed]
  - 2: MAX_p { CNV_p } > relaxed CNV tolerance

We then output these cell counts and pore volume fractions as new
items in the INFOITER file to enable more targeted analysis of the
non-linear convergence behaviour.

To this end, introduce a type alias CnvPvSplit in the
ConvergenceReport and aggregate these across the MPI ranks before we
collect them in the ConvergenceReport objects.

While here, also reduce the amount of repeated logic in
gatherConvergenceReport.cpp through a few local lambdas.
 2024-08-27 10:50:06 +02:00
Kjetil Olsen Lye
f97389d1b5
Merge pull request #5554 from multitalentloes/refactor_cuistl 
refactor cuistl to gpuistl
 2024-08-26 09:55:13 +02:00
Markus Blatt
7ebb6e7034
Merge pull request #5547 from lisajulia/feature/action-parsing-strictness 
Add action-parsing-strictness command line parameter
 2024-08-26 09:06:25 +02:00
Arne Morten Kvarving
b5bd290887 BlackoilModel: use appropriate Scalar type 2024-08-23 11:15:03 +02:00
Arne Morten Kvarving
fda7298374 FlowGenericVanguard: optionally instantiate for float 2024-08-23 11:15:03 +02:00
Bård Skaflestad
3dbeed2199
Merge pull request #5550 from akva2/float_support3 
Float support in simulators: Batch 3
 2024-08-23 10:29:14 +02:00
Tobias Meyer Andersen
85a9ad2b61 refactor cuistl folder names 2024-08-22 15:32:21 +02:00
Tor Harald Sandve
66fd1dfcf3
Merge pull request #5527 from totto82/pvtnum_drdsdtcon 
Support deactivation of individual DRSDT/DRVDT/DRSDTCON regions
 2024-08-22 14:30:03 +02:00
Tobias Meyer Andersen
3f4ae4ddf4 refactor cuistl namespace 2024-08-22 13:52:50 +02:00
hnil
ec11bbaac3 Avoid deleting derivative i.e. getting "wrong" matrix in case of zero flux 2024-08-22 11:47:14 +02:00
Atgeirr Flø Rasmussen
9b4c51de7e
Merge pull request #5553 from jakobtorben/add_support_for_changing_local_solver_in_NLDD 
Make local solver in NLDD a runtime specified ISTLSolver
 2024-08-22 09:45:32 +02:00
Tor Harald Sandve
b0bfe9f1c1 Adapt to mixControl moving from genericProblem 2024-08-21 16:03:59 +02:00
jakobtorben
1f285ae0d5 Make local solver in NLDD a runtime specified ISTLSolver 2024-08-21 14:24:23 +02:00
Arne Morten Kvarving
267d282d1d NonlinearSolver: optionally instantiate for float 2024-08-21 10:12:25 +02:00
Arne Morten Kvarving
d938d821ad EclGenericWriter: optionally instantiate for float 2024-08-21 10:05:04 +02:00
Arne Morten Kvarving
6a364ea961 GenericOutputBlackoilModule: optionally instantiate for float 2024-08-21 09:56:01 +02:00
Arne Morten Kvarving
aadc5cb69c GenericOutputBlackoilModule: obtain data using appropriate overload 2024-08-21 09:49:22 +02:00
Arne Morten Kvarving
05d37bfbf6 InitStateEquil: optionally instantiate for float 2024-08-21 09:45:11 +02:00
Arne Morten Kvarving
b16fd2f724 EquilibrationHelpers: optionally instantiate for float 2024-08-21 09:43:25 +02:00
Arne Morten Kvarving
bff3dae230 GenericTracerModel: optionally instantiate for float 2024-08-21 09:41:56 +02:00
Arne Morten Kvarving
d28b751742 BlackoilModelParameters: optionally instantiate for float 2024-08-21 09:23:31 +02:00
Bård Skaflestad
5fd5027ebd
Merge pull request #5549 from akva2/actionhandler_float 
ActionHandler: instance for float
 2024-08-21 09:22:13 +02:00
Tor Harald Sandve
fffa19e757 Only resize drsdt related vectors when needed 2024-08-21 09:17:25 +02:00
Tor Harald Sandve
914f0b8644 Support deactivation of individual DRSDT/DRVDT/DRSDTCON regions 2024-08-21 09:17:25 +02:00
Arne Morten Kvarving
d762f2b29c ActionHandler: optionally instantiate for float 2024-08-20 12:31:10 +02:00
Kai Bao
5866e9af84
Merge pull request #5535 from GitPaean/relocate_mixing_control 
relocating mixControls_ form FlowGenericProblem to FlowProblem
 2024-08-20 11:50:39 +02:00
Lisa Julia Nebel
d02f84afb7 Add action-parsing-strictness 2024-08-20 10:50:56 +02:00
Atgeirr Flø Rasmussen
1615719993
Merge pull request #5110 from totto82/fixDrift 
Remove check for active wells for drift compensation
 2024-08-20 09:53:25 +02:00
Arne Morten Kvarving
352beaf2ae FlowUtils: optionally instantiate for float 2024-08-19 13:19:39 +02:00
Arne Morten Kvarving
e0f9fefbc7 FlowProblemParameters: optionally instantiate for float 2024-08-19 13:18:03 +02:00
Arne Morten Kvarving
122aeba4d3 RSTConv: optionally instantiate for float 2024-08-19 13:09:41 +02:00
Arne Morten Kvarving
e0deff8b1e Transmissibility: optionally instantiate for float 2024-08-19 13:09:41 +02:00
Arne Morten Kvarving
174b73ebd1 GenericThresholdPressure: optionally instantiate for float 2024-08-19 13:09:41 +02:00
Arne Morten Kvarving
c29d60640c GenericThresholdPressure: convert data to appropriate Scalar 2024-08-19 13:09:41 +02:00
Arne Morten Kvarving
1113746b7d FlowGenericProblem: optionally instantiate for float 2024-08-19 13:09:41 +02:00
Arne Morten Kvarving
6ad616bd98 FlowGenericProblem: convert data to appropriate Scalar type 2024-08-19 13:09:41 +02:00
Arne Morten Kvarving
ae38896b1c MixingRateControls: optionally instantiate for float 2024-08-19 13:09:41 +02:00
Arne Morten Kvarving
5a935ccfb5 SolutionContainers: optionally instantiate for float 2024-08-19 13:09:41 +02:00
Arne Morten Kvarving
58a930507a LogOutputHelper: optionally instantiate for float 2024-08-19 13:09:41 +02:00
Arne Morten Kvarving
e267c377e6 GenericCpGridVanguard: optionally instantiate for float 2024-08-19 13:09:41 +02:00
Tor Harald Sandve
8fe55dba4e Remove check for active wells for drift compensation 2024-08-19 12:37:22 +02:00
Arne Morten Kvarving
5cf468e48a fixed: do not try to hide parameters that are not registered without MPI 2024-08-19 09:14:10 +02:00
Kai Bao
6f2073908c relocating mixControls_ form FlowGenericProblem to FlowProblem 
so FlowGenericProblem can be used for non-blackoil setting
 2024-08-17 00:41:28 +02:00
Arne Morten Kvarving
d15cdea9ec FlowProblem: move parameter registration to FlowProblemParameters.cpp 2024-08-16 17:15:53 +02:00
Arne Morten Kvarving
19c77bdaa1 FlowBaseVanguard: move parameter registration to FlowGenericVanguard 2024-08-16 17:15:53 +02:00
Arne Morten Kvarving
9a9d4e0974 FlowMain: move hiding of parameters to utility function in FlowUtils 2024-08-16 17:15:53 +02:00
Arne Morten Kvarving
b902f83fa6 BlackoilModelParameters: introduce translation unit 2024-08-16 17:15:53 +02:00
Arne Morten Kvarving
a0ec0fca72 NonlinearSolver: move parameter registration to translation unit 2024-08-16 16:59:51 +02:00
Arne Morten Kvarving
f6cc23aa4e DamarisParameters: introduce translation unit 2024-08-16 16:59:51 +02:00
Arne Morten Kvarving
3751ca6be4 move FlowLinearSolver parameters to TypeTag-free parameter system 2024-08-16 13:23:16 +02:00
Arne Morten Kvarving
280704e2e0 move AdaptiveTimeStepping parameters to TypeTag-free parameter system 2024-08-16 13:22:17 +02:00
Arne Morten Kvarving
e2b8715b42 move EclTimeStepping parameters to TypeTag-free parameter system 2024-08-16 13:22:17 +02:00
Arne Morten Kvarving
707afc79eb move SimulatorFullyImplicitBlackoil parameters to TypeTag-free parameter system 2024-08-16 13:22:17 +02:00
Arne Morten Kvarving
8111d2eaa0 move EclWriter parameters to TypeTag-free parameter system 2024-08-16 13:22:15 +02:00
Arne Morten Kvarving
414f313d2a move FlowProblem parameters to TypeTag-free parameter system 2024-08-16 13:20:06 +02:00
Arne Morten Kvarving
fdcc9a0fb2 fixed: EnableDebuggingChecks is a property, not a parameter 2024-08-16 13:20:06 +02:00
Arne Morten Kvarving
9141f2c2d5 move Damaris parameters to TypeTag-free parameter system 2024-08-16 13:20:06 +02:00
Arne Morten Kvarving
94c30a74b8 move NonLinearSolver parameters to TypeTag-free parameter system 2024-08-16 13:20:06 +02:00
Arne Morten Kvarving
dd1bc8d75b move FlowBaseVanguard parameters to TypeTag-free parameter system 2024-08-16 13:20:06 +02:00
Arne Morten Kvarving
bfe6f47d58 move FlowMain parameters to TypeTag-free parameter system 2024-08-16 13:20:06 +02:00
Arne Morten Kvarving
3716ee664d move BlackoilModel parameters to TypeTag-free parameter system 2024-08-16 13:20:04 +02:00
Arne Morten Kvarving
febb359951 move VtkTracerModule parameters to TypeTag-free parameter system 2024-08-16 13:17:56 +02:00
Arne Morten Kvarving
aab40a32e2 move EnableTerminalOutput parameter to TypeTag-free parameter system 2024-08-16 13:17:56 +02:00
Tor Harald Sandve
0371cd5342 Change defaults 
Use implicit IPR as default
Allow for switching of control during local well solves as default
 2024-08-16 10:16:04 +02:00
Tor Harald Sandve
d7331ca3ae use -1 as defult min-strict-iter 2024-08-16 10:16:04 +02:00
Tor Harald Sandve
36a58445b4 use 10-7 as default mass balance tolerance 2024-08-16 10:16:04 +02:00
Bård Skaflestad
9c1239a63f
Merge pull request #5529 from akva2/typetag_free_params2 
Move parameters to typetag free parameter system: Batch 3
 2024-08-14 14:44:27 +02:00
Bård Skaflestad
366a9de26f
Merge pull request #5530 from totto82/renameMIMtoMTR 
rename GMIM to GMTR
 2024-08-14 13:57:43 +02:00
Markus Blatt
ac232197dc
Merge pull request #5510 from lisajulia/fix/COMPDAT-NLDD-parallel 
Fix/compdat nldd parallel
 2024-08-14 11:18:28 +02:00
Tor Harald Sandve
42500f41bb rename GMIM to GMTR 2024-08-14 09:48:25 +02:00
Arne Morten Kvarving
0a662e8b21 EnableGravity moved to TypeTag-free parameter system 2024-08-14 09:16:47 +02:00
Arne Morten Kvarving
8fb6fb8aa3 VtkBlackoilModule parameters moved to TypeTag-free parameter system 2024-08-14 08:58:16 +02:00
Arne Morten Kvarving
73a559312d VtkTemperatureModule parameters moved to TypeTag-free parameter system 2024-08-14 08:52:00 +02:00
Arne Morten Kvarving
0d59aeef6e VtkPrimaryVars parameters moved to TypeTag-free parameter system 2024-08-14 08:40:45 +02:00
Lisa Julia Nebel
87a46d7b01 Fix NLDD solver for parallel runs with the COMPDAT keyword inside an ACTIONX 2024-08-14 08:31:37 +02:00
Arne Morten Kvarving
84e6b0183b VtkCompositionModule parameters moved to TypeTag-free parameter system 2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
48321e857e VtkDiffusionModule parameters moved to TypeTag-free parameter system 2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
eb37499b17 VtkMultiphaseModule parameters moved to TypeTag-free parameter system 2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
64557a136d NewtonMaxIterations moved to TypeTag-free parameter system 2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
643efb7108 NewtonTargetIterations moved to TypeTag-free parameter system 2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
0bbcb09480 NewtonMaxError moved to TypeTag-free parameter system 2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
0195f8f113 NewtonTolerance moved to TypeTag-free parameter system 2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
6280602201 NewtonWriteConvergence moved to TypeTag-free parameter system 2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
b81c00292b NewtonVerbose moved to TypeTag-free parameter system 2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
53730ce5cf EnableThermodynamicHints moved to TypeTag-free parameter system 2024-08-13 14:30:50 +02:00
Arne Morten Kvarving
08b227f7e3 EnableStorageCache moved to TypeTag-free parameter system 2024-08-13 14:03:02 +02:00
Arne Morten Kvarving
77f0cda5d4 EnableIntensiveQuantityCache moved to TypeTag-free parameter system 2024-08-13 13:38:52 +02:00
Arne Morten Kvarving
d5d9bca291 MaxTimeStepDivisions moved to TypeTag-free parameter system 2024-08-13 12:31:02 +02:00
Arne Morten Kvarving
3e53ba2d42 MinTimeStepSize moved to TypeTag-free parameter system 2024-08-13 12:02:42 +02:00
Arne Morten Kvarving
bff4774f84 MaxTimeStepSize moved to TypeTag-free parameter system 2024-08-13 11:38:05 +02:00
Arne Morten Kvarving
fd012efac8 EnableVtkOutput moved to TypeTag-free parameter system 2024-08-13 10:30:50 +02:00
Arne Morten Kvarving
18a18a64c7 OutputDir moved to TypeTag-free parameter system 2024-08-12 15:51:19 +02:00
Arne Morten Kvarving
e5bedd3b47 EnableGridAdaptation moved to TypeTag-free parameter system 2024-08-12 15:28:58 +02:00
Arne Morten Kvarving
9e11888ccb ThreadsPerProcess moved to TypeTag-free parameter system 2024-08-12 14:48:56 +02:00
Arne Morten Kvarving
a20cb10572 InitialTimeStepSize moved to TypeTag-free parameter system 2024-08-12 13:56:36 +02:00
Arne Morten Kvarving
3e8929b04f EndTime moved to TypeTag-free parameter system 2024-08-12 13:45:31 +02:00
Arne Morten Kvarving
91a0fd79a9 RestartTime moved to TypeTag-free parameter system 2024-08-12 13:32:22 +02:00
Arne Morten Kvarving
2f8c91222f PrintParameters moved to TypeTag-free parameter system 2024-08-12 13:24:44 +02:00
Arne Morten Kvarving
c80219c85f PredeterminedTimeStepsFile moved to TypeTag-free parameter system 2024-08-12 13:14:46 +02:00
Bård Skaflestad
27c498f75a
Merge pull request #5511 from akva2/typetag_free_param_system 
Support type-tag free parameter system
 2024-08-09 18:02:26 +02:00
Arne Morten Kvarving
9204ff95a2
Merge pull request #5499 from daavid00/vtkDryRun 
Write vtk (if enabled) for dry runs
 2024-08-09 16:57:37 +02:00
David Landa Marban
d4890d18f7 Write vtk (if enabled) for dry runs 2024-08-09 15:29:32 +02:00
Arne Morten Kvarving
554a261c7f adapt to ParameterSystem printValues change 2024-08-09 10:56:08 +02:00
Arne Morten Kvarving
139e64ea2e adapt to ParameterSystem printUnused change 2024-08-09 10:56:08 +02:00
Arne Morten Kvarving
bb83dea71c adapt to ParameterSystem endRegistration change 2024-08-09 10:56:08 +02:00
Arne Morten Kvarving
e1bcd00a36 adapt to ParameterSystem typetag removal 2024-08-09 10:56:07 +02:00
Tor Harald Sandve
0a63fc8e24 Move modification of density to convectiveMixingModule 2024-08-09 10:53:38 +02:00
Trine Mykkeltvedt
f10c44279f adressed minor comments by reviewer, added enableConvectiveMixing flag to drsdtcon, fixed indentation and bug in lastRs for gas/water 2024-08-09 10:51:19 +02:00
Trine Mykkeltvedt
ab2bd924db extending drsdtcon with regimes, and option for GAS/WATER 2024-08-09 10:48:00 +02:00
Bård Skaflestad
ad595fed5e
Merge pull request #5506 from akva2/move_params_to_parameters 
Move parameters to Opm::Parameters namespace
 2024-08-09 09:16:10 +02:00
Kai Bao
3d794d2d80 using std::from_chars instead of std::stoi 2024-08-08 16:12:17 +02:00
Kai Bao
52da2c9dfe avoiding unnecessary exception from std::stoi("") 
in FlowMain.hpp
 2024-08-08 15:46:31 +02:00
Markus Blatt
a6006b0c93
Merge pull request #5505 from lisajulia/fix/COMPDAT-NLDD 
Fix the usage of the COMPDAT keyword in an ACTIONX for the NLDD solver for sequential runs
 2024-08-08 15:35:00 +02:00
Bård Skaflestad
a336f0df90
Merge pull request #5514 from akva2/remove_print_properties 
Remove support for the print-properties parameter
 2024-08-08 10:14:48 +02:00
Lisa Julia Nebel
f6a06f2639 Change the type of the argument possibleFutureConnections from a pointer to a const reference 2024-08-08 09:19:32 +02:00
Arne Morten Kvarving
60e69fc5ff print-properties parameter has been removed 2024-08-07 11:47:20 +02:00
Kai Bao
2cb471356e
Merge pull request #5504 from GitPaean/avoiding_unnecessary_exception 
avoiding exception from std::stoi("")
 2024-08-07 10:36:45 +02:00
Lisa Julia Nebel
9a97a8d658 Make test on one process pass by taking the possible future connections into account when creating the sparsity pattern of the jacobian and when creating the partitions for the solver 2024-08-06 16:07:01 +02:00
Tobias Meyer Andersen
b905b5ec33 correct comment 2024-08-06 15:26:25 +02:00
Arne Morten Kvarving
a65ddff8f6 changed: BlackoilModel parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
b69439aa1f changed: EclWriter parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
917fdbedfd changed: FlowProblem parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
2a52cf8134 changed: Damaris parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
d75b91aaba changed: SimulatorFullyImplicitBlackoil parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
466e26d330 changed: FlowMain parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
4fc1487a9d changed: FlowBaseVanguard parameters moved to Opm::Parameters namespace 2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
7aeaf6f216 changed: VtkTracerModule parameters moved to Opm::Parameters namespace 2024-08-06 07:38:14 +02:00
Arne Morten Kvarving
f9016b02ef changed: NonlinearSolver parameters moved to Opm::Parameters namespace 2024-08-06 07:31:57 +02:00
Arne Morten Kvarving
00d902d79f changed: OutputBlackoilModule parameters moved to Opm::Parameters namespace 2024-08-06 07:25:35 +02:00
Arne Morten Kvarving
6f7fcb5872 changed: EclTimeStepping parameters moved to Opm::Parameters namespace 2024-08-06 07:05:08 +02:00
Lisa Julia Nebel
8cd53ecea7 Change type of possibleFutureConnections to std::unordered_map<std::string, std::set<int>> 
Now it contains the global ids of the perforated cells for each well instead of the coordinates ijk
 2024-08-05 19:31:54 +02:00
Kai Bao
7803c55a88 avoiding exception from std::stoi("") 
when not setting OMP_NUM_THREADS in the environment.
 2024-08-05 11:48:54 +02:00
Arne Morten Kvarving
f251370a52 changed: EnableGravity parameter moved to Opm::Parameters namespace 2024-08-02 09:04:08 +02:00
Atgeirr Flø Rasmussen
c26271f774
Merge pull request #5493 from akva2/move_vtk_params_to_params 
Move vtk parameters to Opm::Parameters namespace
 2024-08-01 13:01:51 +02:00
Arne Morten Kvarving
c8a3729199 changed: VtkWriteTemperature parameter moved to Opm::Parameters namespace 2024-07-30 13:29:31 +02:00
Arne Morten Kvarving
ec01d7694b changed: VtkPrimaryVarsModule parameters moved to Opm::Parameters namespace 2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
825540691c changed: VtkCompositionModule parameters moved to Opm::Parameters namespace 2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
1759d37f89 changed: VtkBlackoilModule parameters moved to Opm::Parameters namespace 2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
22794f83d1 changed: VtkDiffusionModule parameters moved to Opm::Parameters namespace 2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
58bb7da544 changed: VtkMultiPhaseModule parameters moved to Opm::Parameters namespace 2024-07-30 13:12:54 +02:00
Lisa Julia Nebel
efb18d0027 Add possible future connections to the grid methods that handle the well connections 2024-07-29 09:59:52 +02:00
David Landa Marban
8320a9abdf Output support for RSWSAT and RVWSAT 2024-07-17 13:00:38 +02:00
Markus Blatt
6e74fea547
Merge pull request #5477 from lisajulia/feature/metis-support 
Add the metis partitioner as a command line option as well
 2024-07-17 07:32:39 +02:00
Lisa Julia Nebel
653cb28bc2 Add the metis partitioner as a command line option as well 2024-07-16 17:39:28 +02:00
Lisa Julia Nebel
e2126ae817 Use the failure flag of the tasklet runner to detect a failure while writing output and throw an error if that happens 2024-07-15 08:51:25 +02:00
Vegard Kippe
a078eaacd3 Removing trailing 'p' 2024-07-11 18:15:16 +02:00
Vegard Kippe
dd08952967 Update after move of ThreadsPerProcess from Properties to Parameters 2024-07-11 15:55:34 +02:00
Vegard Kippe
14818028f0 Handle empty or invalied OMP_NUM_THREADS by Flow default and warn if a valid value overrides --threads-per-process 2024-07-11 15:52:20 +02:00
Bård Skaflestad
758a5f0dfd
Merge pull request #5450 from blattms/feature/remove-axisCentroid-copy 
[refactor] Remove unnecessary copy in axisCentroid and simply code.
 2024-07-04 23:04:21 +02:00
Markus Blatt
0caf92c6a6
Merge pull request #5448 from atgeirr/ensure-initialized-members-bdystate 
Ensure all members are initialized in FlowProblem::boundaryFluidState().
 2024-07-04 16:43:05 +02:00
Markus Blatt
3ee2830d28 Change distanceVector_ to take the element index instead of centroid 2024-07-04 14:40:28 +02:00
Arne Morten Kvarving
fb6286d795 changed: PredeterminedTimeStepsFile parameter moved to Opm::Parameters namespace 2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
dfcf2358fe changed: RestartTime parameter moved to Opm::Parameters namespace 2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
b4c6a1a240 changed: InitialTimeStepSize parameter moved to Opm::Parameters namespace 2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
1f967940f1 changed: EndTime parameter moved to Opm::Parameters namespace 2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
1e0f2b61b6 changed: PrintParameters parameter moved to Opm::Parameters namespace 2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
0db393fc07 changed: PrintProperties parameter moved to Opm::Parameters namespace 2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
82cd3a2e01 changed: NewtonMaxIterations parameter moved to Opm::Parameters namespace 2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
8def6b722b changed: NewtonTargetIterations parameter moved to Opm::Parameters namespace 2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
0342566fd6 changed: NewtonMaxError parameter moved to Opm::Parameters namespace 2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
514eddc950 changed: NewtonTolerance parameter moved to Opm::Parameters namespace 2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
389ea1ef8b changed: NewtonWriteConvergence parameter moved to Opm::Parameters namespace 2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
1a63dcdf8b changed: NewtonVerbose parameter moved to Opm::Parameters namespace 2024-07-01 14:13:48 +02:00
Bård Skaflestad
9f8075e8a0
Merge pull request #5455 from akva2/fvbasediscretization_param_split 
Adjust to to changes in fvbaseproperties.hh (moving of parameters to Opm::Parmeters namespace)
 2024-07-01 13:22:26 +02:00
Arne Morten Kvarving
74a4ab7823 changed: EnableThermodynamicHints parameter moved to Opm::Parameters namespace 2024-06-28 15:26:30 +02:00
Arne Morten Kvarving
1f6ddb052d changed: EnableStorageCache parameter moved to Opm::Parameters namespace 2024-06-28 15:13:13 +02:00
Arne Morten Kvarving
02f1c6c230 changed: EnableIntensiveQuantitiesCache parameter moved to Opm::Parameters namespace 2024-06-28 14:59:38 +02:00
Arne Morten Kvarving
f95ec4daa1 changed: MaxTimeStepDivisions parameter moved to Opm::Parameters namespace 2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
325b841771 changed: MinTimeStepSize parameter moved to Opm::Parameters namespace 2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
e08b6b1163 changed: MaxTimeStepSize parameter moved to Opm::Parameters namespace 2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
6a03394d5b changed: EnableVtkOutput parameter moved to Opm::Parameters namespace 2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
b3fae7f0f9 changed: OutputDir parameter moved to Opm::Parameters namespace 2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
da4471acfa changed: EnableGridAdaptation parameter moved to Opm::Parameters namespace 2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
afa62ee428 changed: ThreadsPerProcess parameter moved to Opm::Parameters namespace 2024-06-28 14:43:11 +02:00
Bård Skaflestad
ce7d415e4d
Merge pull request #5447 from blattms/feature/hide-comp-by-dune 
[refactor] Use DUNE's dot product to hide code complexity.
 2024-06-27 15:28:55 +02:00
Markus Blatt
d7c869d01a [refactor] Remove unnecessary copy in axisCentroid and simply code. 
We stored 3 copies of each cell centroid in axisCentroid. This seemed
to be a waste of memory and also made the function distanceVector_ hard
to understand.

With this change we omit this copy of information and simplify distanceVector_
 2024-06-27 15:15:33 +02:00
Atgeirr Flø Rasmussen
a3839aaeb8 Ensure all members are initialized in boundaryFluidState(). 
Also restructure to loop over active phases instead of all
canonical phases.
 2024-06-27 13:43:46 +02:00
Markus Blatt
f6a4d7b076 [refactor] Use DUNE's do product to hide code complexity. 
this removes some explicit loops.
 2024-06-27 13:29:55 +02:00
Bård Skaflestad
ac42250b25
Merge pull request #5402 from totto82/output_wetting_hyst 
Output maximum/minimum saturations directly for restart hysteresis
 2024-06-26 12:15:20 +02:00
Tor Harald Sandve
230656ec31 updateInitialHystParams 2024-06-25 12:55:02 +02:00
Bård Skaflestad
26cd7ab993 Move opm/core/props to opm/simulators/utils 
The opm/core directory is no longer meaningful, and it contains only
components which might collectively be described as simulator
utilities.
 2024-06-25 12:22:09 +02:00
Arne Morten Kvarving
981a5f8a14 clean up some comments 
- simulator note was copied from the typetag dependent class (EclWriter)
- opm-output is no longer a separate module
 2024-06-25 10:59:57 +02:00
Markus Blatt
363eaaa57b
Merge pull request #5434 from blattms/bugfix/do-not-count-nan-as-errors 
[fix] Do not count experiencing nans as error in PRT file.
 2024-06-20 16:18:49 +02:00
Tor Harald Sandve
a419390854
Merge pull request #5407 from totto82/fix_drsdt 
avoid mass creation with drsdt
 2024-06-20 12:14:22 +02:00
Markus Blatt
238b7b2980 [fix] Do not count experiencing nans as error in PRT file. 
The simulation will just chop the time step and continue.
Note, that the error count in the PRT file is used by engineers to
decide whether a simulation was successfull. Hence the error count
should not be increased here.
 2024-06-20 10:40:37 +02:00
Bård Skaflestad
acb124bbdc
Merge pull request #5426 from totto82/output_every_timestep 
fix option for output every timestep
 2024-06-19 12:09:34 +02:00
Bård Skaflestad
46523e7cd9
Merge pull request #5430 from atgeirr/fix-damaris-logging-parallel 
Add and use DamarisOutput::handleError() helper.
 2024-06-19 11:30:08 +02:00
Atgeirr Flø Rasmussen
2c99a84c87 Add and use DamarisOutput::handleError() helper. 
This should improve error handling in parallel, and ensure
Damaris problems are logged properly.
 2024-06-19 10:30:38 +02:00
Tor Harald Sandve
4f2311d1b2 Output maximum/minimum saturations directly for restart hysteresis 2024-06-18 10:39:19 +02:00
Tor Harald Sandve
366f3a2944 fix option for output every timestep 2024-06-14 15:03:43 +02:00
Tor Harald Sandve
151bba43a7
Merge pull request #5268 from svenn-t/tracer_dis_vap 
Partitioning tracers
 2024-06-14 09:08:12 +02:00
Svenn Tveit
87362d5037 Accumulate segment rates and minor fixes 2024-06-12 14:18:32 +02:00
David Landa Marban
80e00f4516 Fix to error in Clang: use 'template' keyword to treat 'data' ... 2024-06-11 09:31:48 +02:00
Bård Skaflestad
b0ee6b9c94
Merge pull request #5419 from GitPaean/only_trans_2 
trying to release global transmissibility earlier to flatten the peak memory usage in the function finishInit()
 2024-06-10 18:13:53 +02:00
Kai Bao
fd5e9d167f addressing reviewing comments OPM/opm-simulators#5419 2024-06-10 16:08:44 +02:00
Kai Bao
062a98b305 restruct so that we can release the global trans earlier 
in the funciton finishInit().
 2024-06-10 16:08:44 +02:00
Svenn Tveit
84cdef1135 Fix solution tracers and well output. 
-Only output or restart solution tracers for gas/oil tracers with DISGAS/VAPOIL enabled (no solution tracers in water phase!).
-Initial tracers (free/solution) will be set to zero initially if TBLK/TVDP is not given.
- Do not calculate mass transfer between free and solution tracers if it is not necessary.
-Calculate well rates using updated tracer concentrations
 2024-06-10 14:50:56 +02:00
Markus Blatt
6921db4282 omit unnescessary function parameter for EDINCC 2024-06-10 14:50:55 +02:00
Svenn Tveit
adc36d64a5 Output rates to multisegment wells 2024-06-10 14:50:55 +02:00
Markus Blatt
fc67eaeeda Prevent spurious warnings about NNCs when applying EDITNNC in parallel. 
If we use transmissibilities for loadbalancing, then we calculate
transmissibilities twice. First on the global grid before
loadbalancing and then on the local grid after that. This is the
default. In this case all warnings will be shown correctly when
calculating the global transmissibilities.

If the user requests the same weights for all faces (command line
parameter --edge-weights-method=0) then the transmissibilities are only
calculated on the loadbalanced grid. Unfortunately, in this case only
rank 0 will issue warnings for his part including the false positives
mentioned below.

Due to load balancing many NNCs might be stored on another process,
but we still use all EDITNNC entries when computing transmissibilties
locally. Hence when applying EDITNNC on the loadbalanced grid we
will issue warnings for cases where there are no problems (e.g. NNC
between two overlap cells.

With this PR we will only warn when computing the transmissibilities
for the first time. For the default settings this will remove spurious
and duplicate warnings.

Not that for --edge-weights-method=0 nothing changes and we will still
see only warnings for the first rank including spurious one.
 2024-06-10 14:50:55 +02:00
Svenn Tveit
db970d58d2 Changed to Scalar type. 
Following commit 61bfea46c7.
 2024-06-10 14:48:49 +02:00
Svenn Tveit
1645559342 Fix mass exchange term. 
Additionally, store separate well terms for free and solution tracers
 2024-06-10 14:48:45 +02:00
Svenn Tveit
050ce2de3b Fixes after rebase 2024-06-10 14:41:21 +02:00
Svenn Tveit
b00cc2c1a5 Extend tracer model to solution tracers. 
Solve an extended linear system with free and solution tracers with mass transfer coupling term.
 2024-06-10 14:41:21 +02:00
Bård Skaflestad
58edb5b9aa
Merge pull request #5417 from blattms/feature-correct-comment-parallel 
Update wrong comment about storage of transmissibilities
 2024-06-07 16:50:38 +02:00
Atgeirr Flø Rasmussen
fc906842ad
Merge pull request #5352 from jcbowden/damaris-limit-variables-v1 
Add ability to pass multiple variables to Damaris using DamarisWriter class.
 2024-06-07 15:54:59 +02:00
Markus Blatt
d80b8411b7 Fixed spelling of comments. 2024-06-07 14:58:47 +02:00
Markus Blatt
2f3c1b7310 Update wrong comment about storage of transmissibilities 
This is a follow up of the fix in #5414.

The comment said that the ordering of the compressed index of cells is
coherent with the cartesian index. THis is not the case in parallel
where cells in the overlap/ghost region might be ordered last (default).
 2024-06-07 06:46:18 +02:00
Markus Blatt
302503e172
Merge pull request #5414 from totto82/fix_mpi_edit_trans 
Fix modifications of TRANX/Y/Z in parallel (e.g. MULTIPLY of TRANX in EDIT)
 2024-06-07 06:28:35 +02:00
Bård Skaflestad
e3bf48541f
Merge pull request #5406 from GitPaean/only_trans 
only allocate trans_ for globalTrans_
 2024-06-06 21:50:11 +02:00
Kai Bao
8f67881809 using enum class to replace boolean onlyTrans for 
Transmissibility::update() for better readability, which is suggested by the reviewer.
 2024-06-06 20:09:44 +02:00
Atgeirr Flø Rasmussen
ab4d9cb36e Initialize double member for serialization test. 2024-06-06 15:24:20 +02:00
Tor Harald Sandve
42702e1d50 Fix mpi for MULTIPLY TRANX in EDIT 2024-06-06 12:59:41 +02:00
Atgeirr Flø Rasmussen
f06c238753 Add damping treatment to subdomain Newton iterations. 2024-06-06 12:59:22 +02:00
josh bowden
6fcec07bab cast to remove: comparison of integer expressions of different signedness warning. 2024-06-06 10:36:25 +02:00
Kai Bao
303a677a81 only allocate trans_ for globalTrans_ 
others are not needed for globalTrans_ for now. It will help to flatten
the peak memory usage for rank 0 during a parallel running.
 2024-06-05 21:35:46 +02:00
josh bowden
7fc6cc0430 Other small additions from github comments and removal of compile time logic that checks for ParaView and Python - makes code more readable and alows use of Damaris libraries with differing compiled in backends to be swapped without need for recompiling opm-simulators 2024-06-05 17:26:34 +02:00
Bård Skaflestad
4cf8a50b26
Merge pull request #5398 from atgeirr/minor-oscillation-handling-fix 
Detect oscillation in just one phase.
 2024-06-05 13:56:35 +02:00
Atgeirr Flø Rasmussen
558d888d90 Allow oscillation detection with less that two phases. 
We should not require two phases to have oscillating residuals to
start handling it.
 2024-06-05 11:50:01 +02:00
Tor Harald Sandve
8b5fced909 avoid mass creation with drsdt 2024-06-04 15:10:11 +02:00
Vegard Kippe
78cc10f620 Fix typo 2024-06-03 15:26:16 +02:00
Bård Skaflestad
a3a2b7a978 Make SummaryState Objects Aware of Undefined UDQ Value 
This PR switches to calling the SummaryState constructor which is
aware of the value of undefined UDQs (OPM/opm-common#4052) directly.

While here, also sort headers, split some long lines, and prefer
initialisation lists to constructor body assignments.
 2024-05-29 09:16:56 +02:00
Bård Skaflestad
6e8da2309b Delay UDQ Assignments Until After Summary Output 
Commit 0aaa69c6e (PR #5330) was a little too eager in its effort to
handle UDQ ASSIGN operations after action processing[%].  In
particular, the assignments, which alter the internal structures of
the SummaryState and UDQState objects, would happen prior to writing
summary files.  In turn, this would make it appear as if the
assignment happened too early.  This commit defers UDQ assignments
triggered by action processing until FlowProblem<>::endEpisode() for
two reasons

  1. The problem originally addressed in 0aaa69c6e only presented
     when the assignment was triggered on the final time step of an
     episode (report step), so handling this situation here is a
     more targeted approach.

  2. Member function FlowProblem<>::endEpisode() is called after we
     write the summary file output so any alterations to the
     internal structures of the SummaryState will not be visible in
     the summary output until the next time step.  This is the
     expected behaviour.

[%] Insufficient testing by: [at]bska.
 2024-05-28 18:16:30 +02:00
Atgeirr Flø Rasmussen
6a7e1e08c0 Avoid memory leak from the *unique_ptr<X>.release() antipattern. 2024-05-28 16:49:08 +02:00
Bård Skaflestad
9841c5d21c
Merge pull request #5377 from akva2/equil_template_scalar 
InitStateEquil: template Scalar type
 2024-05-23 10:48:04 +02:00
Arne Morten Kvarving
4bef925974 InitStateEquil: use Scalar type from FluidSystem 2024-05-23 09:39:49 +02:00
Arne Morten Kvarving
4cfb7a8566 EquilibrationHelpers: template Scalar type 2024-05-23 09:38:27 +02:00
Arne Morten Kvarving
600e7ea2f7 Transmissibility: consistently use Scalar type 2024-05-23 08:42:51 +02:00
Arne Morten Kvarving
27ca3ab5f7 OutputBlackoilModule: consistently use Scalar type 2024-05-23 08:34:09 +02:00
Arne Morten Kvarving
39554ab7dd NonLinearSolver: use Scalar type 2024-05-23 08:25:37 +02:00
Arne Morten Kvarving
cdf227bcbd BlackoilModelParameters: consistently use Scalar 
parameters are registered as Scalar not double
 2024-05-23 08:17:45 +02:00
Arne Morten Kvarving
2205c68f0d BlackoilModel: use Scalar type 2024-05-23 08:09:53 +02:00
Arne Morten Kvarving
aa4758ff07 BlackoilModelNldd: use Scalar type 2024-05-22 15:52:13 +02:00
Arne Morten Kvarving
61bfea46c7 GenericTracerModel: use Scalar type 2024-05-22 15:46:50 +02:00
Bård Skaflestad
0aaa69c6e0 Rerun UDQ Assignments After Action Processing 
If an action block happens to run a UDQ ASSIGN operation and,
furthermore, happens to run at the last time step of an episode then
the "clear pending assignments" behaviour of the ScheduleState copy
constructor leads to not performing the UDQ assignment at all.  This
commit works around this problem by invoking the action handler's
UDQ assignment function after processing all active action blocks.

The underlying problem has been present since at least Pull Request
OPM/opm-common#3587 which introduced the "clear pending assignments"
behaviour of ScheduleState's copy constructor.
 2024-05-21 13:51:06 +02:00
Bård Skaflestad
9731a84cad Adjust Whitespace in FlowProblem File 
In particular, be consistent about four-space indent levels and add
braces to a number of single-statement control blocks.  Add a few
blank lines for readability.

While here, also mark a number of objects as 'const'.
 2024-05-21 13:51:06 +02:00
Bård Skaflestad
8a4e78e7c4
Merge pull request #5354 from akva2/various_well_helpers_template_scalar 
Various well helpers: template Scalar type
 2024-05-21 13:14:50 +02:00
josh bowden
2744614f9c update after pull request comments; addition of OUTPUTDIR variable to Damaris XML configuration 2024-05-17 17:36:18 +02:00
Arne Morten Kvarving
b74b170d5b fixed: build with dune-fem 2.9 2024-05-16 10:58:08 +02:00