Commit Graph

21245 Commits

Author SHA1 Message Date
Bård Skaflestad
9fb46ab420
Merge pull request #5925 from akva2/janitoring
janitoring: use string concat instead of operator+
2025-01-29 13:39:22 +01:00
Bård Skaflestad
b102ecd00f
Merge pull request #5921 from bska/document-and-test-property-tree
Document and Test PropertyTree Class
2025-01-29 13:38:19 +01:00
Arne Morten Kvarving
aa3226a71f janitoring: use string concat instead of operator+
and avoid unnecessary temporary
2025-01-29 13:23:25 +01:00
Bård Skaflestad
efede0a253 Document and Test PropertyTree Class
In particular, add Doxygen-style documentation to the header file
and add a simple unit test for the PropertyTree class interface.

While here, also add missing headers and prefer template argument
deduction over explicit template arguments.
2025-01-29 12:58:29 +01:00
Atgeirr Flø Rasmussen
d2b272b5f5
Merge pull request #5923 from michal-toth/bugfix/log-message
Correct a keyword in a message
2025-01-29 09:23:43 +01:00
Michal Tóth
f9af91abfc Correct the keyword in the message 2025-01-28 16:04:12 +01:00
Atgeirr Flø Rasmussen
270018cfbb
Merge pull request #5900 from totto82/improve_well_shutting
Improve well shutting logic
2025-01-28 10:46:10 +01:00
Kai Bao
536ad41987
Merge pull request #5918 from vkip/nwparam
Parameterize network sub-iterations and pressure update dampening
2025-01-28 10:44:37 +01:00
Atgeirr Flø Rasmussen
2fedd5c29e
Merge pull request #5912 from atgeirr/use-element-chunks
Switch property evaluation to using ElementChunks.
2025-01-28 10:39:15 +01:00
Kai Bao
ff29f04cdb
Merge pull request #5919 from vkip/network_empty_leaf_nodes
Allow empty leaf nodes that do not exist in GRUPTREE
2025-01-28 10:05:04 +01:00
Tor Harald Sandve
eabb2de362
Merge pull request #5902 from totto82/wcycle_chop
Dont reset subtimestep from tuning/wcycle if time step is chopped due  to convergence issues
2025-01-28 10:00:58 +01:00
Atgeirr Flø Rasmussen
57fb01ad57 Switch property evaluation to using ElementChunks. 2025-01-28 09:59:16 +01:00
Tor Harald Sandve
cfc2b03b5a Improve well shutting logic
In particular allow for failed wells to shut even though they haven't failed consitatantly in the last 3 attempts
if the timestep is reduce enhough already.
2025-01-28 09:55:36 +01:00
Atgeirr Flø Rasmussen
e912d3b3de
Merge pull request #5890 from akva2/multithread_tran_calc
Add multi-threading to transmissibility calculation
2025-01-28 09:22:23 +01:00
Vegard Kippe
7b1d8d1df6 Allow empty leaf nodes that do not exist in GRUPTREE 2025-01-27 13:11:49 +01:00
Vegard Kippe
1d2e413d63 Parameterize network sub-iterations and pressure update dampening 2025-01-27 11:44:10 +01:00
Atgeirr Flø Rasmussen
6bfb60ded0
Merge pull request #5915 from akva2/serialize_glift_last_opt
BlackoilWellModelGasLift: serialize last_glift_opt_time
2025-01-27 10:17:44 +01:00
Arne Morten Kvarving
b41f512214 BlackoilWellModelGasLift: serialize last_glift_opt_time 2025-01-24 14:37:00 +01:00
Arne Morten Kvarving
da22efb623 BlackoilWellModelGeneric: move operator== to translation unit 2025-01-24 14:35:52 +01:00
Arne Morten Kvarving
2b930ca51c SimulatorSerializer: add LoadFile to ignore list 2025-01-24 14:33:58 +01:00
Bård Skaflestad
6b5097ce63
Merge pull request #5913 from bska/udq-regression-tests
Add Regression/Restart Tests for Recent UDQ Work
2025-01-24 13:50:07 +01:00
Arne Morten Kvarving
f68864db8c reindent 2025-01-24 12:27:41 +01:00
Arne Morten Kvarving
8772f41e62 Transmissibility::update(): enable multithreading 2025-01-24 12:26:34 +01:00
Arne Morten Kvarving
d551d95762 Transmissibility::update: use ThreadedMap for dispersivity_
this in preparation for multithreading the loop
2025-01-24 12:17:56 +01:00
Arne Morten Kvarving
a502a86dc1 Transmissibility::update: use ThreadSafeMapBuilder for diffusivity_
this in preparation for multithreading the loop
2025-01-24 12:17:56 +01:00
Arne Morten Kvarving
23e1654ba7 Transmissibility::update: use ThreadSafeMapBuilder for thermalHalfTrans
this in preparation for multithreading the loop
2025-01-24 12:17:56 +01:00
Arne Morten Kvarving
5cbbde67d7 Transmissibility::update: use ThreadSafeMapBuilder for thermalHalfTransBoundary
this in preparation for multithreading the loop
2025-01-24 12:17:56 +01:00
Arne Morten Kvarving
da696ff0eb Transmissibility::update: use ThreadSafeMapBuilder for trans_
this in preparation for multithreading the loop
2025-01-24 12:17:56 +01:00
Arne Morten Kvarving
52a22afa3b Transmissibility::update: use ThreadSafeMapBuilder for transBoundary
this in preparation for multithreading the loop
2025-01-24 12:17:56 +01:00
Bård Skaflestad
f0c62ff223 Add Regression Test for Group Level UDQ Assignments
Uses the example model UDQ_GRP-01 from PR OPM/opm-tests#1174.
2025-01-24 11:06:30 +01:00
Bård Skaflestad
0660b62d29 Add Restart Test for ZUDL Character Limit
Uses the example model from PR OPM/opm-tests#1279 in which the
defining expression of one UDQ is exactly 128 characters long.  This
expression will overflow the character limit if we insert any new
characters like blanks or quotes.
2025-01-24 10:05:25 +01:00
Bård Skaflestad
f67cdb0c6e
Merge pull request #5891 from bska/group-udq
Chase UDQConfig::Eval() API Change
2025-01-23 18:22:36 +01:00
Bård Skaflestad
64edbff477 Chase UDQConfig::Eval() API Change
We must now pass a GroupOrder object into eval() in order to support
group name pattern matching in group level UDQ assignments.
2025-01-23 12:48:39 +01:00
Bård Skaflestad
66f4e59c16
Merge pull request #5910 from atgeirr/fix-compile-error-and-warnings
Fix compile error and warnings
2025-01-23 12:42:27 +01:00
Bård Skaflestad
d02ad0f637
Merge pull request #5909 from hnil/add_tracy
added more timing
2025-01-23 12:24:55 +01:00
Atgeirr Flø Rasmussen
439a0a9847 Add template parameter needed for clang.
Not sure if this is a gcc-ism, a clang-ism or a c++20-ism,
but as written here it should compile for all.
2025-01-23 11:59:56 +01:00
Atgeirr Flø Rasmussen
057eabcbe8 Silence warning for missing 'override'. 2025-01-23 11:59:24 +01:00
Bård Skaflestad
06904dc93f
Merge pull request #5908 from akva2/janitoring_sca_various
Janitoring: address various static analyzer issues
2025-01-23 11:50:01 +01:00
Halvor M Nilsen
f2bfa1b2ef added more timing 2025-01-23 11:28:20 +01:00
Arne Morten Kvarving
716eaa8b0a reduce scope of variables
remove unused variables
break some long lines while at it
2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
043f743cca use an explicit cast to better communicate intent
and mark some variables const while at it
2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
6d2fe4334a remove unnecessary arithmetic 2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
e1fea5469c remove some always true/false conditionals
quell static analyzer issues
2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
fe3c687eaa remove some duplicate if conditionals 2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
de986943f0 remove some unused bools
these loops are inf-loops-with-break and the bools are never used
2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
4ff851af9c WellState: replace some loops with standard algorithms
also addresses some static analyzer issues
2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
b8ce6629ef fix some header vs implementation parameter name inconsistencies 2025-01-23 10:56:03 +01:00
Arne Morten Kvarving
8f293ba5e5 add some missing initializers 2025-01-23 10:56:03 +01:00
Arne Morten Kvarving
4d2b07432c fixed: rethrow exceptions using bare throw instead of making copies 2025-01-23 10:56:03 +01:00
Arne Morten Kvarving
e108e4b8c1 use c++ casts 2025-01-23 10:56:03 +01:00