Arne Morten Kvarving
45d27f446c
make all canonicalToActiveComponentIndex variants constexpr
2025-02-03 15:27:29 +01:00
Arne Morten Kvarving
1671d060c8
fixed: use if constexpr to avoid compiler warning
...
while we are never actually here without an index,
compiler cannot know since the enum is a runtime argument
2025-02-03 14:15:06 +01:00
Halvor M Nilsen
0fd2623e05
Remove Unused FMT Header
...
Makes using the header from an installed location harder than it
needs to be.
2025-01-31 17:15:32 +01:00
Bård Skaflestad
66f4e59c16
Merge pull request #5910 from atgeirr/fix-compile-error-and-warnings
...
Fix compile error and warnings
2025-01-23 12:42:27 +01:00
Atgeirr Flø Rasmussen
057eabcbe8
Silence warning for missing 'override'.
2025-01-23 11:59:24 +01:00
Arne Morten Kvarving
e1fea5469c
remove some always true/false conditionals
...
quell static analyzer issues
2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
fe3c687eaa
remove some duplicate if conditionals
2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
8f293ba5e5
add some missing initializers
2025-01-23 10:56:03 +01:00
Arne Morten Kvarving
2760d2b09e
vcfvstencil: use if constexpr
...
this quells some static analyzer issues
2025-01-23 10:56:03 +01:00
Arne Morten Kvarving
066f27bae5
mpibuffer: change to std::is_same_v
2025-01-23 09:54:38 +01:00
Arne Morten Kvarving
fbd4e5c1d5
mpibuffer: change to std::size_t
2025-01-23 09:51:26 +01:00
Arne Morten Kvarving
73c0dafdcc
fixed: use a vector in mpibuffer
...
this was being copied and it had pointer members
2025-01-23 09:51:26 +01:00
Bård Skaflestad
0507c87e39
Merge pull request #5906 from akva2/janitoring_const_correctness
...
Janitoring: const correctness
2025-01-23 09:06:18 +01:00
Arne Morten Kvarving
c114def851
mark parameters/variables as const where appropriate
2025-01-23 07:57:44 +01:00
Arne Morten Kvarving
918b6cc594
header cleanups
2025-01-22 17:41:47 +01:00
Arne Morten Kvarving
74cfde89e0
xxxPrimaryVariables: remove ctor from Scalar
...
these were only in use for assignments to a constant.
Instead of detouring all of these assignments through a temporary,
use the base field vector assignment operator to do inplace
assignments.
2025-01-22 15:28:49 +01:00
Arne Morten Kvarving
64df3c25f4
header cleanups
2025-01-22 15:28:49 +01:00
Arne Morten Kvarving
1c537632fc
mark methods override
2025-01-21 14:41:57 +01:00
Arne Morten Kvarving
6d964c1370
mark constructors explicit
2025-01-21 14:41:17 +01:00
Svenn Tveit
96ccc8cb96
Accommodate for implemnetation of generic cubic EOS
...
Which EOS formulation to use is set in the deck and passed to the flash solver and parameter cache
2025-01-16 13:29:41 +01:00
Atgeirr Flø Rasmussen
635d7d77dd
Merge pull request #5862 from GitPaean/simplying_flash_usage
...
adapting to the interface change for PTFlash::solve()
2025-01-16 10:59:48 +01:00
Arne Morten Kvarving
f7cfa7a04b
FlowProblem: move some more code to FlowGenericProblem
...
typetag less parameter system now allows us to initialize these variables
in class that holds them.
2025-01-15 08:40:48 +01:00
Kai Bao
359915819b
changing the default FlashTolerance to be 1.e-8
...
the original value 1.e-12 is never used with the code before.
2025-01-14 12:57:21 +01:00
Kai Bao
e31b9784fd
adapting to the interface change for PTFlash::solve()
2025-01-13 10:25:05 +01:00
Atgeirr Flø Rasmussen
7a237f80fe
Refactoring update() into subfunctions.
...
Verified on local system to give identical results on all tests.
2025-01-07 15:02:54 +01:00
Atgeirr Flø Rasmussen
6df2d8ceea
Reduce size of enums to save 15 bytes per cell.
2025-01-06 10:32:10 +01:00
Antonella Ritorto
b680c13bd8
Unnecessary check if(isInterior)
2024-12-20 17:28:35 +01:00
Alf Birger Rustad
1b4cb316ff
Merge pull request #5721 from blattms/bugfix/copyright-aligned-alloc
...
Removed GPL copyright header from licensed under Boost license.
2024-11-08 13:14:17 +01:00
Markus Blatt
2c7806c6b5
Removed GPL copyright header from code licensed under Boost license.
...
One cannot just add another license when there are no substantial
creative changes and you are changing existing code only.
There is no need either as we can use code under Boost license next
to GPL.
2024-11-08 11:19:21 +01:00
Arne Morten Kvarving
d9a3dd6f77
add casts to avoid comparison to / arithmetics with enums
2024-11-06 10:38:50 +01:00
Arne Morten Kvarving
13b5e23dec
use constexpr instead of anonymous enums
...
c++-20 warns for arithmetics using enums
2024-11-06 10:38:50 +01:00
Kai Bao
ad587e77ad
output XMF ,YMF and ZMF in UNRST file.
...
currently, it looks the value for ZMF is based on XMF and YMF.
ideally, the ZMF is part of the primary varialbes, it does not need to
be calculated based on XMF and YMF.
there is some refactoring that we can do here.
2024-10-30 11:15:38 +01:00
Kai Bao
4ba1cd53d7
add EclWriter to FlowProblemComp
...
so the FlowProblemComp can output ecl style output.
it duplicates the OutputBlackoilModule and GenericOutputBlackoilModule
for compositional related output for now.
2024-10-30 11:14:18 +01:00
Kai Bao
4754f63d62
setting up logging so flowexp variants can report parsing errors
2024-09-18 16:56:30 +02:00
Arne Morten Kvarving
3ee3dc2b5f
newtonmethod: move parameters to dedicated struct with a translation unit
2024-09-16 15:17:50 +02:00
Arne Morten Kvarving
1b19fa02f4
newtonmethodparameters.hh: rename to newtonmethodparams.hpp
2024-09-16 15:17:50 +02:00
Arne Morten Kvarving
e0af58a7cf
vtktemperaturemodule: move parameters to dedicated struct with a translation unit
2024-09-16 15:17:50 +02:00
Arne Morten Kvarving
e093101d1c
vtktemperaturemodule.hh: rename to vtktemperaturemodule.hpp
2024-09-16 15:17:50 +02:00
Arne Morten Kvarving
4eb70830cf
vtkptflashmodule: move parameters to dedicated struct with a translation unit
2024-09-16 15:17:50 +02:00
Arne Morten Kvarving
29f2a35694
vtkptflashmodule.hh: rename to vtkptflashmodule.hpp
2024-09-16 15:17:50 +02:00
Arne Morten Kvarving
023328bed2
vtkprimaryvarsparams: move parameters to dedicated struct with a translation unit
2024-09-16 15:17:50 +02:00
Arne Morten Kvarving
be4026ecce
vtkprimaryvarsmodule.hh: rename to vtkprimaryvarsmodule.hpp
2024-09-16 15:17:50 +02:00
Arne Morten Kvarving
adb6438d84
vtkphasepresencemodule: move parameters to dedicated struct with a translation unit
2024-09-16 15:17:50 +02:00
Arne Morten Kvarving
08b9c78ddd
vtkphasepresencemodule.hh: rename to vtkphasepresencemodule.hpp
2024-09-16 15:17:50 +02:00
Arne Morten Kvarving
f5e2b46c37
vtkmultiphasemodule: move parameters to dedicated struct with a translation unit
2024-09-16 15:17:50 +02:00
Arne Morten Kvarving
a895678c30
vtkmultiphasemodule.hh: rename to vtkmultiphasemodule.hpp
2024-09-16 15:17:50 +02:00
Arne Morten Kvarving
924da68d02
vtkenergymodule: move parameters to dedicated struct with a translation unit
2024-09-16 15:17:50 +02:00
Arne Morten Kvarving
85bbba93fa
vtkenergymodule.hh: rename to vtkenergymodule.hpp
2024-09-16 15:17:50 +02:00
Arne Morten Kvarving
b1afd79cd9
vtkdiscretefracturemodule: move parameters to dedicated struct with a translation unit
2024-09-16 15:17:50 +02:00
Arne Morten Kvarving
ca56913816
vtkdiscretefracturemodule.hh: rename to vtkdiscretefracuremodule.hpp
2024-09-16 15:17:50 +02:00
