Bård Skaflestad
64edbff477
Chase UDQConfig::Eval() API Change
...
We must now pass a GroupOrder object into eval() in order to support
group name pattern matching in group level UDQ assignments.
2025-01-23 12:48:39 +01:00
Bård Skaflestad
66f4e59c16
Merge pull request #5910 from atgeirr/fix-compile-error-and-warnings
...
Fix compile error and warnings
2025-01-23 12:42:27 +01:00
Bård Skaflestad
d02ad0f637
Merge pull request #5909 from hnil/add_tracy
...
added more timing
2025-01-23 12:24:55 +01:00
Atgeirr Flø Rasmussen
439a0a9847
Add template parameter needed for clang.
...
Not sure if this is a gcc-ism, a clang-ism or a c++20-ism,
but as written here it should compile for all.
2025-01-23 11:59:56 +01:00
Atgeirr Flø Rasmussen
057eabcbe8
Silence warning for missing 'override'.
2025-01-23 11:59:24 +01:00
Bård Skaflestad
06904dc93f
Merge pull request #5908 from akva2/janitoring_sca_various
...
Janitoring: address various static analyzer issues
2025-01-23 11:50:01 +01:00
Halvor M Nilsen
f2bfa1b2ef
added more timing
2025-01-23 11:28:20 +01:00
Arne Morten Kvarving
716eaa8b0a
reduce scope of variables
...
remove unused variables
break some long lines while at it
2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
043f743cca
use an explicit cast to better communicate intent
...
and mark some variables const while at it
2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
6d2fe4334a
remove unnecessary arithmetic
2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
e1fea5469c
remove some always true/false conditionals
...
quell static analyzer issues
2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
fe3c687eaa
remove some duplicate if conditionals
2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
de986943f0
remove some unused bools
...
these loops are inf-loops-with-break and the bools are never used
2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
4ff851af9c
WellState: replace some loops with standard algorithms
...
also addresses some static analyzer issues
2025-01-23 11:16:32 +01:00
Arne Morten Kvarving
b8ce6629ef
fix some header vs implementation parameter name inconsistencies
2025-01-23 10:56:03 +01:00
Arne Morten Kvarving
8f293ba5e5
add some missing initializers
2025-01-23 10:56:03 +01:00
Arne Morten Kvarving
4d2b07432c
fixed: rethrow exceptions using bare throw instead of making copies
2025-01-23 10:56:03 +01:00
Arne Morten Kvarving
e108e4b8c1
use c++ casts
2025-01-23 10:56:03 +01:00
Arne Morten Kvarving
9ed93eeecc
fixed: check correct variable (copy-pasta issue)
2025-01-23 10:56:03 +01:00
Arne Morten Kvarving
98497c52e9
fixed: broken range check
2025-01-23 10:56:03 +01:00
Arne Morten Kvarving
2760d2b09e
vcfvstencil: use if constexpr
...
this quells some static analyzer issues
2025-01-23 10:56:03 +01:00
Bård Skaflestad
7b4acb0db4
Merge pull request #5907 from akva2/fix_mpibuffer
...
fixed: use a vector in mpibuffer
2025-01-23 10:49:44 +01:00
Arne Morten Kvarving
066f27bae5
mpibuffer: change to std::is_same_v
2025-01-23 09:54:38 +01:00
Arne Morten Kvarving
fbd4e5c1d5
mpibuffer: change to std::size_t
2025-01-23 09:51:26 +01:00
Arne Morten Kvarving
73c0dafdcc
fixed: use a vector in mpibuffer
...
this was being copied and it had pointer members
2025-01-23 09:51:26 +01:00
Bård Skaflestad
0507c87e39
Merge pull request #5906 from akva2/janitoring_const_correctness
...
Janitoring: const correctness
2025-01-23 09:06:18 +01:00
Antonella Ritorto
8d5d04a394
Merge pull request #5903 from aritorto/addCarfinRun
...
Add run SPE1CASE1_CARFIN.DATA
2025-01-23 08:24:25 +01:00
Arne Morten Kvarving
c114def851
mark parameters/variables as const where appropriate
2025-01-23 07:57:44 +01:00
Arne Morten Kvarving
a298496fd0
Merge pull request #5905 from akva2/fix_build_serial
...
fixed: condition on MPI_FOUND, not USE_MPI
2025-01-22 17:43:44 +01:00
Arne Morten Kvarving
918b6cc594
header cleanups
2025-01-22 17:41:47 +01:00
Arne Morten Kvarving
76c947b04c
cosmetics
2025-01-22 17:41:47 +01:00
Antonella Ritorto
21073b729e
Run SPE1CASE1_CARFIN.DATA
2025-01-22 17:21:08 +01:00
Bård Skaflestad
ab380d5dfe
Merge pull request #5904 from akva2/primaryvars_scalar_assignment
...
xxxPrimaryVariables: remove ctor from Scalar
2025-01-22 16:59:16 +01:00
Arne Morten Kvarving
6cdb905ed7
fixed: condition on MPI_FOUND, not USE_MPI
2025-01-22 15:37:15 +01:00
Arne Morten Kvarving
078249503f
changed: move NLDD BlackoilWellModel code to separate class
2025-01-22 15:33:28 +01:00
Arne Morten Kvarving
74cfde89e0
xxxPrimaryVariables: remove ctor from Scalar
...
these were only in use for assignments to a constant.
Instead of detouring all of these assignments through a temporary,
use the base field vector assignment operator to do inplace
assignments.
2025-01-22 15:28:49 +01:00
Arne Morten Kvarving
64df3c25f4
header cleanups
2025-01-22 15:28:49 +01:00
Bård Skaflestad
e288a61c59
Merge pull request #5894 from totto82/gsatprod
...
Implement gsatprod
2025-01-22 14:17:22 +01:00
Bård Skaflestad
6813f3ab54
Merge pull request #5901 from GitPaean/fixing_logical_and
...
using logical AND instead of bit-wise AND
2025-01-22 13:34:51 +01:00
Tor Harald Sandve
7b4894b600
cleanup based on review
2025-01-22 13:15:47 +01:00
Kai Bao
8b5ce37780
using logical AND instead of bit-wise AND
...
overlooking when reviewing PR#5861
2025-01-22 13:12:48 +01:00
Kai Bao
939e6f3a6c
Merge pull request #5861 from vkip/bugfix_restart_with_inactive_wells
...
Bugfix: Upon restart, do not try to restore segment info for inactive wells
2025-01-22 12:59:20 +01:00
Tor Harald Sandve
5c8a9eca5b
adapt to changes in common
2025-01-22 12:55:44 +01:00
Tor Harald Sandve
7ae7ff6ee0
Mark GSATPROD supported
2025-01-22 12:55:44 +01:00
Tor Harald Sandve
f9d6644197
add gsatprod to group rates
2025-01-22 12:55:44 +01:00
Tor Harald Sandve
fef6cfcf38
Fix parallel gsatprod
2025-01-22 12:55:44 +01:00
Tor Harald Sandve
ecc3c5557d
Dont reset subtimestep from tuning/wcycle if time step is chopped due to convergence issues
2025-01-22 12:54:24 +01:00
Bård Skaflestad
4d91d687eb
Merge pull request #5679 from vkip/skip_empty_pos_args
...
Skip empty positional arguments
2025-01-21 17:01:17 +01:00
Bård Skaflestad
bf4a6a1814
Merge pull request #5898 from akva2/janitoring_sca
...
janitoring: quell static analyzer issues
2025-01-21 15:33:38 +01:00
Arne Morten Kvarving
67d39d8d7e
header scrub
2025-01-21 14:41:58 +01:00
