Vegard Kippe
14818028f0
Handle empty or invalied OMP_NUM_THREADS by Flow default and warn if a valid value overrides --threads-per-process
2024-07-11 15:52:20 +02:00
Bård Skaflestad
758a5f0dfd
Merge pull request #5450 from blattms/feature/remove-axisCentroid-copy
...
[refactor] Remove unnecessary copy in axisCentroid and simply code.
2024-07-04 23:04:21 +02:00
Markus Blatt
0caf92c6a6
Merge pull request #5448 from atgeirr/ensure-initialized-members-bdystate
...
Ensure all members are initialized in FlowProblem::boundaryFluidState().
2024-07-04 16:43:05 +02:00
Markus Blatt
3ee2830d28
Change distanceVector_ to take the element index instead of centroid
2024-07-04 14:40:28 +02:00
Arne Morten Kvarving
fb6286d795
changed: PredeterminedTimeStepsFile parameter moved to Opm::Parameters namespace
2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
dfcf2358fe
changed: RestartTime parameter moved to Opm::Parameters namespace
2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
b4c6a1a240
changed: InitialTimeStepSize parameter moved to Opm::Parameters namespace
2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
1f967940f1
changed: EndTime parameter moved to Opm::Parameters namespace
2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
1e0f2b61b6
changed: PrintParameters parameter moved to Opm::Parameters namespace
2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
0db393fc07
changed: PrintProperties parameter moved to Opm::Parameters namespace
2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
82cd3a2e01
changed: NewtonMaxIterations parameter moved to Opm::Parameters namespace
2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
8def6b722b
changed: NewtonTargetIterations parameter moved to Opm::Parameters namespace
2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
0342566fd6
changed: NewtonMaxError parameter moved to Opm::Parameters namespace
2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
514eddc950
changed: NewtonTolerance parameter moved to Opm::Parameters namespace
2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
389ea1ef8b
changed: NewtonWriteConvergence parameter moved to Opm::Parameters namespace
2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
1a63dcdf8b
changed: NewtonVerbose parameter moved to Opm::Parameters namespace
2024-07-01 14:13:48 +02:00
Bård Skaflestad
9f8075e8a0
Merge pull request #5455 from akva2/fvbasediscretization_param_split
...
Adjust to to changes in fvbaseproperties.hh (moving of parameters to Opm::Parmeters namespace)
2024-07-01 13:22:26 +02:00
Arne Morten Kvarving
74a4ab7823
changed: EnableThermodynamicHints parameter moved to Opm::Parameters namespace
2024-06-28 15:26:30 +02:00
Arne Morten Kvarving
1f6ddb052d
changed: EnableStorageCache parameter moved to Opm::Parameters namespace
2024-06-28 15:13:13 +02:00
Arne Morten Kvarving
02f1c6c230
changed: EnableIntensiveQuantitiesCache parameter moved to Opm::Parameters namespace
2024-06-28 14:59:38 +02:00
Arne Morten Kvarving
f95ec4daa1
changed: MaxTimeStepDivisions parameter moved to Opm::Parameters namespace
2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
325b841771
changed: MinTimeStepSize parameter moved to Opm::Parameters namespace
2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
e08b6b1163
changed: MaxTimeStepSize parameter moved to Opm::Parameters namespace
2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
6a03394d5b
changed: EnableVtkOutput parameter moved to Opm::Parameters namespace
2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
b3fae7f0f9
changed: OutputDir parameter moved to Opm::Parameters namespace
2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
da4471acfa
changed: EnableGridAdaptation parameter moved to Opm::Parameters namespace
2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
afa62ee428
changed: ThreadsPerProcess parameter moved to Opm::Parameters namespace
2024-06-28 14:43:11 +02:00
Bård Skaflestad
ce7d415e4d
Merge pull request #5447 from blattms/feature/hide-comp-by-dune
...
[refactor] Use DUNE's dot product to hide code complexity.
2024-06-27 15:28:55 +02:00
Markus Blatt
d7c869d01a
[refactor] Remove unnecessary copy in axisCentroid and simply code.
...
We stored 3 copies of each cell centroid in axisCentroid. This seemed
to be a waste of memory and also made the function distanceVector_ hard
to understand.
With this change we omit this copy of information and simplify distanceVector_
2024-06-27 15:15:33 +02:00
Atgeirr Flø Rasmussen
a3839aaeb8
Ensure all members are initialized in boundaryFluidState().
...
Also restructure to loop over active phases instead of all
canonical phases.
2024-06-27 13:43:46 +02:00
Markus Blatt
f6a4d7b076
[refactor] Use DUNE's do product to hide code complexity.
...
this removes some explicit loops.
2024-06-27 13:29:55 +02:00
Bård Skaflestad
ac42250b25
Merge pull request #5402 from totto82/output_wetting_hyst
...
Output maximum/minimum saturations directly for restart hysteresis
2024-06-26 12:15:20 +02:00
Tor Harald Sandve
230656ec31
updateInitialHystParams
2024-06-25 12:55:02 +02:00
Bård Skaflestad
26cd7ab993
Move opm/core/props to opm/simulators/utils
...
The opm/core directory is no longer meaningful, and it contains only
components which might collectively be described as simulator
utilities.
2024-06-25 12:22:09 +02:00
Arne Morten Kvarving
981a5f8a14
clean up some comments
...
- simulator note was copied from the typetag dependent class (EclWriter)
- opm-output is no longer a separate module
2024-06-25 10:59:57 +02:00
Markus Blatt
363eaaa57b
Merge pull request #5434 from blattms/bugfix/do-not-count-nan-as-errors
...
[fix] Do not count experiencing nans as error in PRT file.
2024-06-20 16:18:49 +02:00
Tor Harald Sandve
a419390854
Merge pull request #5407 from totto82/fix_drsdt
...
avoid mass creation with drsdt
2024-06-20 12:14:22 +02:00
Markus Blatt
238b7b2980
[fix] Do not count experiencing nans as error in PRT file.
...
The simulation will just chop the time step and continue.
Note, that the error count in the PRT file is used by engineers to
decide whether a simulation was successfull. Hence the error count
should not be increased here.
2024-06-20 10:40:37 +02:00
Bård Skaflestad
acb124bbdc
Merge pull request #5426 from totto82/output_every_timestep
...
fix option for output every timestep
2024-06-19 12:09:34 +02:00
Bård Skaflestad
46523e7cd9
Merge pull request #5430 from atgeirr/fix-damaris-logging-parallel
...
Add and use DamarisOutput::handleError() helper.
2024-06-19 11:30:08 +02:00
Atgeirr Flø Rasmussen
2c99a84c87
Add and use DamarisOutput::handleError() helper.
...
This should improve error handling in parallel, and ensure
Damaris problems are logged properly.
2024-06-19 10:30:38 +02:00
Tor Harald Sandve
4f2311d1b2
Output maximum/minimum saturations directly for restart hysteresis
2024-06-18 10:39:19 +02:00
Tor Harald Sandve
366f3a2944
fix option for output every timestep
2024-06-14 15:03:43 +02:00
Tor Harald Sandve
151bba43a7
Merge pull request #5268 from svenn-t/tracer_dis_vap
...
Partitioning tracers
2024-06-14 09:08:12 +02:00
Svenn Tveit
87362d5037
Accumulate segment rates and minor fixes
2024-06-12 14:18:32 +02:00
David Landa Marban
80e00f4516
Fix to error in Clang: use 'template' keyword to treat 'data' ...
2024-06-11 09:31:48 +02:00
Bård Skaflestad
b0ee6b9c94
Merge pull request #5419 from GitPaean/only_trans_2
...
trying to release global transmissibility earlier to flatten the peak memory usage in the function finishInit()
2024-06-10 18:13:53 +02:00
Kai Bao
fd5e9d167f
addressing reviewing comments OPM/opm-simulators#5419
2024-06-10 16:08:44 +02:00
Kai Bao
062a98b305
restruct so that we can release the global trans earlier
...
in the funciton finishInit().
2024-06-10 16:08:44 +02:00
Svenn Tveit
84cdef1135
Fix solution tracers and well output.
...
-Only output or restart solution tracers for gas/oil tracers with DISGAS/VAPOIL enabled (no solution tracers in water phase!).
-Initial tracers (free/solution) will be set to zero initially if TBLK/TVDP is not given.
- Do not calculate mass transfer between free and solution tracers if it is not necessary.
-Calculate well rates using updated tracer concentrations
2024-06-10 14:50:56 +02:00
Markus Blatt
6921db4282
omit unnescessary function parameter for EDINCC
2024-06-10 14:50:55 +02:00
Svenn Tveit
adc36d64a5
Output rates to multisegment wells
2024-06-10 14:50:55 +02:00
Markus Blatt
fc67eaeeda
Prevent spurious warnings about NNCs when applying EDITNNC in parallel.
...
If we use transmissibilities for loadbalancing, then we calculate
transmissibilities twice. First on the global grid before
loadbalancing and then on the local grid after that. This is the
default. In this case all warnings will be shown correctly when
calculating the global transmissibilities.
If the user requests the same weights for all faces (command line
parameter --edge-weights-method=0) then the transmissibilities are only
calculated on the loadbalanced grid. Unfortunately, in this case only
rank 0 will issue warnings for his part including the false positives
mentioned below.
Due to load balancing many NNCs might be stored on another process,
but we still use all EDITNNC entries when computing transmissibilties
locally. Hence when applying EDITNNC on the loadbalanced grid we
will issue warnings for cases where there are no problems (e.g. NNC
between two overlap cells.
With this PR we will only warn when computing the transmissibilities
for the first time. For the default settings this will remove spurious
and duplicate warnings.
Not that for --edge-weights-method=0 nothing changes and we will still
see only warnings for the first rank including spurious one.
2024-06-10 14:50:55 +02:00
Svenn Tveit
db970d58d2
Changed to Scalar type.
...
Following commit 61bfea46c7
.
2024-06-10 14:48:49 +02:00
Svenn Tveit
1645559342
Fix mass exchange term.
...
Additionally, store separate well terms for free and solution tracers
2024-06-10 14:48:45 +02:00
Svenn Tveit
050ce2de3b
Fixes after rebase
2024-06-10 14:41:21 +02:00
Svenn Tveit
b00cc2c1a5
Extend tracer model to solution tracers.
...
Solve an extended linear system with free and solution tracers with mass transfer coupling term.
2024-06-10 14:41:21 +02:00
Bård Skaflestad
58edb5b9aa
Merge pull request #5417 from blattms/feature-correct-comment-parallel
...
Update wrong comment about storage of transmissibilities
2024-06-07 16:50:38 +02:00
Atgeirr Flø Rasmussen
fc906842ad
Merge pull request #5352 from jcbowden/damaris-limit-variables-v1
...
Add ability to pass multiple variables to Damaris using DamarisWriter class.
2024-06-07 15:54:59 +02:00
Markus Blatt
d80b8411b7
Fixed spelling of comments.
2024-06-07 14:58:47 +02:00
Markus Blatt
2f3c1b7310
Update wrong comment about storage of transmissibilities
...
This is a follow up of the fix in #5414 .
The comment said that the ordering of the compressed index of cells is
coherent with the cartesian index. THis is not the case in parallel
where cells in the overlap/ghost region might be ordered last (default).
2024-06-07 06:46:18 +02:00
Markus Blatt
302503e172
Merge pull request #5414 from totto82/fix_mpi_edit_trans
...
Fix modifications of TRANX/Y/Z in parallel (e.g. MULTIPLY of TRANX in EDIT)
2024-06-07 06:28:35 +02:00
Bård Skaflestad
e3bf48541f
Merge pull request #5406 from GitPaean/only_trans
...
only allocate trans_ for globalTrans_
2024-06-06 21:50:11 +02:00
Kai Bao
8f67881809
using enum class to replace boolean onlyTrans for
...
Transmissibility::update() for better readability, which is suggested by the reviewer.
2024-06-06 20:09:44 +02:00
Atgeirr Flø Rasmussen
ab4d9cb36e
Initialize double member for serialization test.
2024-06-06 15:24:20 +02:00
Tor Harald Sandve
42702e1d50
Fix mpi for MULTIPLY TRANX in EDIT
2024-06-06 12:59:41 +02:00
Atgeirr Flø Rasmussen
f06c238753
Add damping treatment to subdomain Newton iterations.
2024-06-06 12:59:22 +02:00
josh bowden
6fcec07bab
cast to remove: comparison of integer expressions of different signedness warning.
2024-06-06 10:36:25 +02:00
Kai Bao
303a677a81
only allocate trans_ for globalTrans_
...
others are not needed for globalTrans_ for now. It will help to flatten
the peak memory usage for rank 0 during a parallel running.
2024-06-05 21:35:46 +02:00
josh bowden
7fc6cc0430
Other small additions from github comments and removal of compile time logic that checks for ParaView and Python - makes code more readable and alows use of Damaris libraries with differing compiled in backends to be swapped without need for recompiling opm-simulators
2024-06-05 17:26:34 +02:00
Bård Skaflestad
4cf8a50b26
Merge pull request #5398 from atgeirr/minor-oscillation-handling-fix
...
Detect oscillation in just one phase.
2024-06-05 13:56:35 +02:00
Atgeirr Flø Rasmussen
558d888d90
Allow oscillation detection with less that two phases.
...
We should not require two phases to have oscillating residuals to
start handling it.
2024-06-05 11:50:01 +02:00
Tor Harald Sandve
8b5fced909
avoid mass creation with drsdt
2024-06-04 15:10:11 +02:00
Vegard Kippe
78cc10f620
Fix typo
2024-06-03 15:26:16 +02:00
Bård Skaflestad
a3a2b7a978
Make SummaryState Objects Aware of Undefined UDQ Value
...
This PR switches to calling the SummaryState constructor which is
aware of the value of undefined UDQs (OPM/opm-common#4052 ) directly.
While here, also sort headers, split some long lines, and prefer
initialisation lists to constructor body assignments.
2024-05-29 09:16:56 +02:00
Bård Skaflestad
6e8da2309b
Delay UDQ Assignments Until After Summary Output
...
Commit 0aaa69c6e
(PR #5330 ) was a little too eager in its effort to
handle UDQ ASSIGN operations after action processing[%]. In
particular, the assignments, which alter the internal structures of
the SummaryState and UDQState objects, would happen prior to writing
summary files. In turn, this would make it appear as if the
assignment happened too early. This commit defers UDQ assignments
triggered by action processing until FlowProblem<>::endEpisode() for
two reasons
1. The problem originally addressed in 0aaa69c6e
only presented
when the assignment was triggered on the final time step of an
episode (report step), so handling this situation here is a
more targeted approach.
2. Member function FlowProblem<>::endEpisode() is called after we
write the summary file output so any alterations to the
internal structures of the SummaryState will not be visible in
the summary output until the next time step. This is the
expected behaviour.
[%] Insufficient testing by: [at]bska.
2024-05-28 18:16:30 +02:00
Atgeirr Flø Rasmussen
6a7e1e08c0
Avoid memory leak from the *unique_ptr<X>.release() antipattern.
2024-05-28 16:49:08 +02:00
Bård Skaflestad
9841c5d21c
Merge pull request #5377 from akva2/equil_template_scalar
...
InitStateEquil: template Scalar type
2024-05-23 10:48:04 +02:00
Arne Morten Kvarving
4bef925974
InitStateEquil: use Scalar type from FluidSystem
2024-05-23 09:39:49 +02:00
Arne Morten Kvarving
4cfb7a8566
EquilibrationHelpers: template Scalar type
2024-05-23 09:38:27 +02:00
Arne Morten Kvarving
600e7ea2f7
Transmissibility: consistently use Scalar type
2024-05-23 08:42:51 +02:00
Arne Morten Kvarving
27ca3ab5f7
OutputBlackoilModule: consistently use Scalar type
2024-05-23 08:34:09 +02:00
Arne Morten Kvarving
39554ab7dd
NonLinearSolver: use Scalar type
2024-05-23 08:25:37 +02:00
Arne Morten Kvarving
cdf227bcbd
BlackoilModelParameters: consistently use Scalar
...
parameters are registered as Scalar not double
2024-05-23 08:17:45 +02:00
Arne Morten Kvarving
2205c68f0d
BlackoilModel: use Scalar type
2024-05-23 08:09:53 +02:00
Arne Morten Kvarving
aa4758ff07
BlackoilModelNldd: use Scalar type
2024-05-22 15:52:13 +02:00
Arne Morten Kvarving
61bfea46c7
GenericTracerModel: use Scalar type
2024-05-22 15:46:50 +02:00
Bård Skaflestad
0aaa69c6e0
Rerun UDQ Assignments After Action Processing
...
If an action block happens to run a UDQ ASSIGN operation and,
furthermore, happens to run at the last time step of an episode then
the "clear pending assignments" behaviour of the ScheduleState copy
constructor leads to not performing the UDQ assignment at all. This
commit works around this problem by invoking the action handler's
UDQ assignment function after processing all active action blocks.
The underlying problem has been present since at least Pull Request
OPM/opm-common#3587 which introduced the "clear pending assignments"
behaviour of ScheduleState's copy constructor.
2024-05-21 13:51:06 +02:00
Bård Skaflestad
9731a84cad
Adjust Whitespace in FlowProblem File
...
In particular, be consistent about four-space indent levels and add
braces to a number of single-statement control blocks. Add a few
blank lines for readability.
While here, also mark a number of objects as 'const'.
2024-05-21 13:51:06 +02:00
Bård Skaflestad
8a4e78e7c4
Merge pull request #5354 from akva2/various_well_helpers_template_scalar
...
Various well helpers: template Scalar type
2024-05-21 13:14:50 +02:00
josh bowden
2744614f9c
update after pull request comments; addition of OUTPUTDIR variable to Damaris XML configuration
2024-05-17 17:36:18 +02:00
Arne Morten Kvarving
b74b170d5b
fixed: build with dune-fem 2.9
2024-05-16 10:58:08 +02:00
Tor Harald Sandve
2ea6cea895
Merge pull request #5292 from gdfldm/patch-1
...
Update GMDS and GMGP definitions in GenericOutputBlackoilModule.cpp
2024-05-15 15:00:10 +02:00
Arne Morten Kvarving
ee1c531431
InitStateEquil: remove template parameter from Comm and use Parallel::Communication directly
...
in the process this quells a deprecation warning for
Dune::CollectiveCommunication usage
2024-05-15 11:20:29 +02:00
josh bowden
3630177e3e
added ability to pass through multiple variables to Damaris, with full list still defined in initDamarisXmlFile.cpp ; Also adds ability to limit the variables to be passed through using --damaris-limit-variables=<CSV list> coammand line option
2024-05-14 21:08:47 +02:00
Arne Morten Kvarving
f70c7f15f8
ActionHandler: template Scalar type
2024-05-14 16:21:55 +02:00
Bård Skaflestad
2e7a7a0c44
Merge pull request #5347 from akva2/janitoring_gcc14
...
add missing include
2024-05-13 21:27:26 +02:00
Arne Morten Kvarving
5d54d36dc4
add missing include
...
in particular fixes build with gcc14
2024-05-13 15:05:47 +02:00
Bård Skaflestad
0f67799e9c
Merge pull request #5344 from totto82/GMST
...
Add GMST and modify GMTR output the maximum trapped CO2 in the gas phase
2024-05-13 13:56:49 +02:00
Tor Harald Sandve
b42a8cbcc3
Add output of GMST/GMUS
...
Rename GMTR to GMMO as ending with TR are used for tracers
[FR]GMTR output maximum trapped CO2 in the gas phase
2024-05-13 11:24:08 +02:00
Kai Bao
5fda72d24f
removing unused releaseGlobalTransmissibility()
...
from AluGridVanguard and CpGridVanguard.
they exist is becaluse of typo in the function name. There is another
releaseGlobalTransmissibilities() function actually gets used.
2024-05-10 16:45:00 +02:00
Bård Skaflestad
a417968464
Merge pull request #5333 from GitPaean/remove_unused_updateImbnum_
...
removing unused updateImbnum_ function
2024-05-08 10:59:41 +02:00
Kai Bao
b225ec240f
removing updateKrnum_
...
which does not have effects, which was suggested by Håkon Hægland.
And also removing the following member variables from
FlowGenericProblem because they are not in use anymore.
krnumx_, krnumy_, krnumz_;
imbnumx_, imbnumy_, imbnumz_;
2024-05-08 09:41:46 +02:00
Kai Bao
79236c4927
removing unused updateImbnum_ function
2024-05-08 09:33:00 +02:00
Bård Skaflestad
cc28bbe989
Enforce Relaxed Tolerances Not Stricter Than Strict
...
Relaxed tolerances being more strict than the strict tolerances does
not make sense in our use case.
2024-05-07 15:03:18 +02:00
Bård Skaflestad
027eed16e9
Report CNV Violation Pore-Volume Fraction to INFOITER
...
This commit includes the fraction of pore-volume whose CNV targets
are violated as a new per-iteration quantity in the INFOITER file
(--output-extra-convergence-info=iteration), with the column header
"CnvErrPvFrac". We collect the values which are already calculated
in
BlackoilModel<>::getReservoirConvergence()
and store these as a pair of numerator and denominator in the
ConvergenceReport class. Note that we need both the numerator and
the denominator in order to aggregate contributions from multiple
ranks.
While here, also make a few more objects 'const' and calculate
column widths directly instead of the maximum number of characters
in writeConvergenceHeader().
2024-05-06 11:31:47 +02:00
Bård Skaflestad
f01635dcf2
Merge pull request #5331 from totto82/fix_restart_co2
...
Bugfix: initialize the input temperature in restart run without temperature in the restart file
2024-05-06 11:19:18 +02:00
Bård Skaflestad
26c59ce5cb
Merge pull request #5329 from vkip/input_skip_mode
...
Add parameter InputSkipMode to parameterise SKIP100 and SKIP300
2024-05-06 10:56:38 +02:00
Tor Harald Sandve
c6c447dc94
initialize the input temperature in restart run without temperature in the restart file
2024-05-06 10:21:42 +02:00
Bård Skaflestad
1e9943bfe6
Accumulate CNV Pore-Volume Sum for Interior Cells Only
...
The 'interiorBorder' category is *probably* equivalent to the
'interior' category for codimension zero elements, but it's better
to be safe than sorry. We don't want to accumulate pore-volume
contributions twice.
2024-05-03 14:19:00 +02:00
Bård Skaflestad
226e90f8e1
Merge pull request #5324 from daavid00/fixMass
...
Bug fix massGas in place
2024-05-03 09:41:14 +02:00
Vegard Kippe
b68a55a9b9
Add parameter InputSkipMode to parameterise the behvaviour of the SKIP100 and SKIP300 keywords
2024-05-03 09:28:14 +02:00
Atgeirr Flø Rasmussen
f0855f4f48
Merge pull request #5293 from totto82/fixInitGW
...
Fix gas-water initialization with transision zone
2024-05-02 15:57:13 +02:00
Håkon Hægland
a1b7d4b5dd
Allow Python bindings to setup MPI
...
Allows the Python bindings to control whether MPI_Init() and
MPI_Finalize() will be called when creating an OPM::Main object.
2024-05-02 11:14:07 +02:00
David Landa Marban
955cdbf02f
Bug fix massGas in place
2024-04-30 11:51:16 +02:00
Atgeirr Flø Rasmussen
e767b6145f
Avoid getting parameters in hot path.
2024-04-26 16:46:27 +02:00
Arne Morten Kvarving
f0e7f8842b
BlackoilWellModelGeneric: template Scalar type
2024-04-23 11:33:33 +02:00
Bård Skaflestad
450bfd04fb
Merge pull request #5297 from akva2/fix_rstconv_mpich
...
fixed: do not send and recv from same buffer
2024-04-19 23:30:37 +02:00
Arne Morten Kvarving
70c9e5345d
fixed: do not send and recv from same buffer
...
even though it's perfectly fine to do so in this case, mpich
will error out with an error if send and recv buffer is
the same
2024-04-19 20:10:47 +02:00
Tor Harald Sandve
af2e08d5aa
Also fix gas-oil initialization with transision zone
2024-04-19 10:12:14 +02:00
Tor Harald Sandve
575bc813dd
Fix gas-water initialization with transision zone
2024-04-19 08:39:24 +02:00
Matthew Goodfield
6ed2d95929
Update GMDS and GMGP definitions in GenericOutputBlackoilModule.cpp
...
Should GMDS be CO2 dissolved in water phase and GMGP be CO2 in gas phase (rather than the other way around)?
2024-04-17 12:31:10 +01:00
Arne Morten Kvarving
be57843296
WellState: template Scalar type
2024-04-17 11:12:40 +02:00
Arne Morten Kvarving
0aacefeeec
adjust to Parameters::isSet change
2024-04-15 08:12:05 +02:00
David Landa Marban
9671792106
summary for immobile free-phase at saturations for which the nonwetting relative permeability equals zero
2024-04-12 15:31:22 +02:00
Bård Skaflestad
ac9d6eaa34
Prepare for Including Region Level Quantities in Field Level UDQs
...
Meet the new UDQConfig::eval() API requirement by adding a matcher
factory for region-level summary vectors.
2024-04-08 09:04:22 +02:00
Bård Skaflestad
10d2f52cd2
Add Procedure for Calculating Basic FIP Region Statistics
...
This commit implements the parallel version of
EclipseState::computeFipRegionStatistics()
which computes a FIPRegionStatistics object for the current run's
fluid-in-place regions. The object construction uses an MPI-aware
reduction process to compute the maximum region IDs across all MPI
ranks.
While here, also unconditionally form the statistics object as part
of the EclWriter's constructor to ensure that all ranks participate
in the process. The initial approach of constructing the object on
first use is not robust in parallel. We may however wish to compute
these statistics only when needed. If so, that will be the subject
of follow-up work.
2024-04-05 17:06:13 +02:00
Arne Morten Kvarving
0161d69660
adjust to removal of EWOMS_GET_PARAM
2024-04-05 14:02:28 +02:00
Arne Morten Kvarving
b8284fea9c
adjust to Parameters::hideParam change
2024-04-05 12:56:38 +02:00
Arne Morten Kvarving
6fba1a95c9
adjust to removal of EWOMS_REGISTER_PARAM
2024-04-05 12:24:48 +02:00
Arne Morten Kvarving
fdab87d336
Merge pull request #5255 from BigDataAccelerate/fix_dep_rocm_ocl
...
Bug fix: remove dependencies for rocm & cuda on opencl to run block Jacobi ILU
2024-04-05 12:02:30 +02:00
Arne Morten Kvarving
21bc4c7f0d
adjust to EWOMS_HIDE_PARAM macro removal
2024-04-04 08:18:19 +02:00
Bård Skaflestad
3334726871
Merge pull request #5270 from akva2/adjust_ewoms_param_is_set
...
adjust to EWOMS_PARAM_IS_SET macro removal
2024-04-03 21:47:52 +02:00
Arne Morten Kvarving
46c3402eba
adjust to EWOMS_PARAM_IS_SET macro removal
2024-04-03 19:54:45 +02:00
Arne Morten Kvarving
b4d2189bd2
adjust to EWOMS_END_PARAM_REGISTRATION macro removal
2024-04-03 16:18:39 +02:00
Bård Skaflestad
1799b6ee07
Switch to Using Declared Maximum Region IDs From Common
...
The declaredMaxRegionID() function is now available in OPM-Common.
2024-03-22 21:24:11 +01:00
Bård Skaflestad
785b96f6f3
Distribute SummaryConfig Objects With eclBroadcast
...
Suggested by [at]akva2.
While here, also switch to using type deduction instead of explicit
template arguments for the eclBroadcast overloads.
2024-03-22 16:53:51 +01:00
Bård Skaflestad
8e9cb4b249
Defer SummaryConfig Initialisation
...
In the current approach, the full list of summary vectors,
especially those that are defined at the region level, is not known
until we've processed all UDQ and/or ACTIONX definitions. As a
quick solution to this, switch to using the 'SummaryConfig' object
that's defined in the EclipseIO container instead of the object that
gets constructed when reading the input files.
It is likely that we will have to rethink and refactor this
construction process later.
2024-03-22 16:53:51 +01:00
Antonella Ritorto
5e1a37e497
Simulation partially supported for CpGrid with LGRs
2024-03-20 08:48:09 +01:00
Razvan Nane
0fcad4b0fc
Bug fix: remove dep rocm & cuda on opencl for blockJacobi ILU
2024-03-13 16:47:55 +01:00
Arne Morten Kvarving
696f9cd875
Merge pull request #5228 from akva2/simplify_template_params
...
Simplify template params
2024-03-08 17:03:03 +01:00
Arne Morten Kvarving
958f33fbfc
GenericProblem: remove unnecessary Scalar template parameter
...
use the Scalar type from the FluidSystem
2024-03-08 16:23:49 +01:00
Arne Morten Kvarving
5972b3c88d
MixingRateControls: remove unnecessary Scalar template parameter
...
use the Scalar type from the FluidSystem
2024-03-08 16:23:47 +01:00
Arne Morten Kvarving
2c35cb9659
GenericOutputBlackoilModule: remove unnecessary Scalar template parameter
...
use the Scalar type from the FluidSystem
2024-03-08 16:23:39 +01:00
Bård Skaflestad
6a43099511
Merge pull request #5249 from atgeirr/nldd-add-missing-convergence-metrics
...
Add missing convergence metrics to domain convergence report.
2024-03-08 15:39:16 +01:00
Arne Morten Kvarving
32e1a86f4f
OutputBlackoilModule: rename ebosResid to modelResid
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
638e5006e0
FlowGenericProblem: remove ebos banner
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
52fb89b66e
PyFluidState: rename ebos_simulator to simulator
...
and align ref/ptr with variable type
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
2a91fb4c2f
remove unused ebos/eclnewtonmethod.hh
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
fb7c4f6fd2
move ebos/eclproblem.hh to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
6f5d53b20b
move ebos/eclgenericproblem.[hh|cc] to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
15339fe02f
move ebos/eclproblem_properties.hh to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
7b49bcb09e
rename EclBaseProblem to FlowBaseProblem
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
57905c1069
move ebos/ecltransmissibility[_impl].[hh|cc] to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
9facaaf816
ebos/damariswriter: move to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
76ccaf45ef
ebos/damaris_properties.hh: move to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
1362143e48
move ebos/eclgenericvanguard.[hh|cc] to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
6949abbf0d
move ebos/eclbasevanguard.hh to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
9fe969378d
move ebos/eclgenericcpgridvanguard.[hh|cc] to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
04ed17ebd0
move ebos/eclcpgridvanguard.hh to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
bc2dd1110e
move ebos/eclfluxmodule.hh to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
2d604e12a7
move ebos/eclequilinitializer.hh to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
d717d96590
move ebos/eclthresholdpressure.hh to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
f6475f8c1e
move ebos/eclgenericthresholdpressure[_impl].[hh|cc] to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
e6eac2039b
move ebos/vtkecltracermodule.hh to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
9d256bc233
move ebos/ecltracermodel.hh to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
3a3881e8d9
move ebos/eclgenerictracermodel[_impl].[hh|cc] to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
a01e1bd902
move ebos/eclsolutioncontainers.[hh|cc] to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
eb90588fa9
move ebos/eclmixingratecontrols.[hh|cc] to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
ddb7c65f97
move ebos/eclwriter.hh to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
8d667301cc
move ebos/eclgenericwriter[_impl].[hh|cc] to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
e7094558ef
move ebos/eclpolyhedralgridvanguard.hh to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
e168066003
move ebos/FIBlackOilModel.hpp to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
c9b3de16f1
move ebos/femcpgridcompat.hh to opm/simulators/flow
2024-03-08 12:39:48 +01:00
Arne Morten Kvarving
388c6c72f7
Flow: drop ebos from simulator object filenames
2024-03-08 12:39:48 +01:00
Atgeirr Flø Rasmussen
8e60fecb85
Add missing convergence metrics to domain convergence report.
2024-03-08 10:37:20 +01:00
Markus Blatt
f04f4c5765
Merge pull request #5239 from akva2/move_flow_utilities_dedicated_file
...
changed: rename FlowMain.cpp to FlowUtils.cpp
2024-03-07 17:35:59 +01:00
Kai Bao
75f38ca726
Merge pull request #5178 from akva2/baseaquifermodel_move
...
move ebos/eclbaseaquifermodel.hh to opm/simulators/flow
2024-03-06 12:47:51 +01:00
Kai Bao
aa2fa12598
Merge pull request #5167 from akva2/drop_ebos_simulator_params
...
Rename ebos_simulator parameters to simulator
2024-03-06 11:48:03 +01:00
Kai Bao
5f2c9192d0
Merge pull request #5177 from akva2/move_collect_iorank
...
ebos/collecttoiorank: move to opm/simulators/flow
2024-03-06 11:44:46 +01:00
Arne Morten Kvarving
3475da7d8c
Rename ebos_simulator members/parameters to simulator
2024-03-06 10:53:00 +01:00
Arne Morten Kvarving
d5748b6c55
Drop ebos in function names
2024-03-06 10:13:01 +01:00
Arne Morten Kvarving
233d4c90ac
ebos/collecttoiorank: move to opm/simulators/flow
2024-03-06 09:30:21 +01:00
Arne Morten Kvarving
8d033f94de
move ebos/eclbaseaquifermodel.hh to opm/simulators/flow
2024-03-06 09:17:19 +01:00
Arne Morten Kvarving
fdb285c03a
changed: rename FlowMain.cpp to FlowUtils.cpp
...
and add a dedicated header.
this way we don't need to pull in FlowMain.hpp for the prototypes,
avoiding pulling in the entire simulator machinery just to build
some simple utility functions.
2024-03-06 07:57:25 +01:00
Kai Bao
9f13a25ebc
Merge pull request #5175 from akva2/move_alugrid
...
Move AluGrid files from ebos to opm/simulators/flow
2024-03-06 00:02:12 +01:00
Kai Bao
ed9876a5c4
Merge pull request #5185 from akva2/move_outputblackoilmodule
...
Move BlackoilOutputModule from ebos to opm/simulators/flow
2024-03-05 23:31:44 +01:00
Markus Blatt
2cd490b601
[Fix] Correct handling of NEXTSTEP in ACTIONX
...
Previously, the step size would only have used for the first time step
of the next report step (at least of --enable-tuning=true was used).
2024-03-05 13:59:24 +01:00
Håkon Hægland
67bcc491ff
Remove unused variables
2024-03-05 09:22:15 +01:00
Håkon Hægland
66eb6e1625
use the elements() range generator
2024-03-05 08:53:54 +01:00
Arne Morten Kvarving
b6cbf513bc
move ebos/ecloutputblackoilmodule.hh to opm/simulators/flow
2024-03-04 13:09:48 +01:00
Arne Morten Kvarving
41319eab7d
move ebos/eclgenericoutputblackoilmodule.[hh|cc] to opm/simulators/flow
2024-03-04 13:03:42 +01:00
Håkon Hægland
757c67f284
Return vectors by value
...
Return vectors by value instead of unique pointers to arrays.
2024-03-01 14:22:37 +01:00
Håkon Hægland
55aab60549
Get primary variables and fluid state from Python
...
Added methods to Python module opm.simulators.BlackOilSimulator to
access primary variables and fluid state variables.
2024-03-01 14:22:35 +01:00
Bård Skaflestad
d1d22668ea
Add Utility for Region-Based Phase-Filled Averages
...
The initial use case is calculating the phase-filled pore-volume
weighted average of the fluid mass densities per PVT region. This
value goes into calculating depth-corrected per-cell phase pressure
values such as the BPPO and BPPG summary vectors.
This class manages a single linear array which separately tracks the
averages' numerators and denominators as running sums per region and
region set. We pick this data structure to simplify the cross-rank
reduction needed in MPI parallel runs. Client code is expected to
add individual per-cell and per-phase contributions using the
addCell() member function and then call the accumulateParallel()
member to affect the cross-rank reduction. The averages will then
be available through the fieldValue() and value() member functions.
As a further view towards the initial use case, we track two
different types of average per phase--one for the phase-filled
volume and one for the pore-volume filled volume. The latter is the
average we would get for the case of the phase saturation being one
throughout the region. This alternative value is the fallback
option for the case of the phase saturation being identically zero
throughout the region.
2024-02-28 12:08:24 +01:00
Arne Morten Kvarving
0039c1f25f
move ebos/eclalugridvanguard.hh to opm/simulators/flow
2024-02-23 15:27:53 +01:00
Arne Morten Kvarving
f95c114716
move ebos/alucartesianindexmapper.hh to opm/simulators/flow
2024-02-23 15:27:28 +01:00
Arne Morten Kvarving
3087950c35
Merge pull request #5181 from akva2/move_gradient_calculator
...
move ebos/ecldummygradientcalculator.hh to opm/simulators/flow
2024-02-23 15:24:44 +01:00
Arne Morten Kvarving
6b0dbfdf2d
rename EclAquiferModel property to AquiferModel
2024-02-23 10:25:16 +01:00
Arne Morten Kvarving
991f89816e
rename EclWellModel property to WellModel
2024-02-23 10:24:53 +01:00