Bård Skaflestad
9c744190eb
Merge pull request #5411 from bska/claim-basic-wtmult-support
...
Enable WTMULT as an Input Operation
2024-06-06 14:53:07 +02:00
Bård Skaflestad
bc48a2e955
Merge pull request #5342 from atgeirr/nldd-domain-solves-newton-damping
...
Add Newton update damping when domain solution oscillates.
2024-06-06 14:52:25 +02:00
Bård Skaflestad
e876fa86e9
Merge pull request #5409 from bska/collect-well-limits-for-smry-output
...
Collect Well Level Control Limits/Targets for Summary Output
2024-06-06 14:51:22 +02:00
Tor Harald Sandve
42702e1d50
Fix mpi for MULTIPLY TRANX in EDIT
2024-06-06 12:59:41 +02:00
Atgeirr Flø Rasmussen
f06c238753
Add damping treatment to subdomain Newton iterations.
2024-06-06 12:59:22 +02:00
josh bowden
6fcec07bab
cast to remove: comparison of integer expressions of different signedness warning.
2024-06-06 10:36:25 +02:00
Bård Skaflestad
3074c0d9fd
Enable WTMULT as an Input Operation
...
Basic support for this keyword was added in commit
OPM/opm-common@5e3e20c552
and this commit enables running models which use that basic support.
Advanced uses, such as including user-defined arguments for the
multipliers, will still be rejected at the input level.
2024-06-06 09:14:01 +02:00
Bård Skaflestad
151de07fa7
Collect Well Level Control Limits/Targets for Summary Output
...
This commit adds a new stage to the wellData() report function,
assignWellTargets(), which collects the numerical values of the
currently active limits/targets for summary file output purposes.
It is important that we collect these values strictly before we
start mutating the SummaryState object lest user-defined arguments
in keywords like WCONPROD be evaluated seemingly too soon.
Furthermore, it is faster to collect these values on the simulator
side and send them to the I/O rank for file output than to defer the
full calculation to the I/O rank.
2024-06-06 09:13:57 +02:00
Tor Harald Sandve
25f6c0a1bd
Merge pull request #5405 from svenn-t/ezrokhi
...
Support for CNAMES
2024-06-06 08:44:27 +02:00
Kai Bao
303a677a81
only allocate trans_ for globalTrans_
...
others are not needed for globalTrans_ for now. It will help to flatten
the peak memory usage for rank 0 during a parallel running.
2024-06-05 21:35:46 +02:00
josh bowden
7fc6cc0430
Other small additions from github comments and removal of compile time logic that checks for ParaView and Python - makes code more readable and alows use of Damaris libraries with differing compiled in backends to be swapped without need for recompiling opm-simulators
2024-06-05 17:26:34 +02:00
Bård Skaflestad
4cf8a50b26
Merge pull request #5398 from atgeirr/minor-oscillation-handling-fix
...
Detect oscillation in just one phase.
2024-06-05 13:56:35 +02:00
Tobias Meyer Andersen
9b2f41ad96
Add option to split the matrix into diagonal,
...
strictly lower and stricly upper part.
Add tests checking that the result matches
the CPU dilu implementation.
2024-06-05 13:35:54 +02:00
Atgeirr Flø Rasmussen
558d888d90
Allow oscillation detection with less that two phases.
...
We should not require two phases to have oscillating residuals to
start handling it.
2024-06-05 11:50:01 +02:00
Kai Bao
904cb7e2c4
Merge pull request #5395 from steink/consistent_vfp_interpolation
...
Small fixes related to thp-control/vfp-extrapolation
2024-06-04 15:15:41 +02:00
Tor Harald Sandve
8b5fced909
avoid mass creation with drsdt
2024-06-04 15:10:11 +02:00
Svenn Tveit
912cd45182
Support for CNAMES needed with CO2STORE
2024-06-03 20:40:26 +02:00
Arne Morten Kvarving
b6d3a83955
Merge pull request #5403 from vkip/bflowj_typo
...
Fix typo
2024-06-03 16:37:06 +02:00
Vegard Kippe
78cc10f620
Fix typo
2024-06-03 15:26:16 +02:00
Arne Morten Kvarving
d32c8c2d90
fixed: linking of some cuda tests with shared libraries
...
need to link against the cudart library
2024-06-03 08:50:46 +02:00
Stein Krogstad
6318335d76
Update test_vfpproperties
2024-05-31 14:11:10 +02:00
Stein Krogstad
37c771cb5f
fix bug and attempt to make code clearer
2024-05-31 14:11:10 +02:00
Stein Krogstad
d32d4419a9
fix double -> Scalar
2024-05-31 14:11:10 +02:00
Stein Krogstad
aa8516c085
Respect "global" switching logic also in local solves
2024-05-31 14:11:10 +02:00
Stein Krogstad
008fd268c5
fix bug
2024-05-31 14:11:10 +02:00
Stein Krogstad
c5f7d02bf7
Make thp-func constistent with bhp-func and add some damage prevention logic for severe extrapolation
2024-05-31 14:11:10 +02:00
Arne Morten Kvarving
59aee6c56c
Merge pull request #5400 from BigDataAccelerate/fix_rocsparsewells
...
fix compile rocsparseWellContributions
2024-05-31 13:50:11 +02:00
Razvan Nane
988d3821cd
fix compile rocsparseWellContrib
2024-05-31 11:55:53 +02:00
Arne Morten Kvarving
c92d80e0e8
Merge pull request #5399 from daavid00/fixMacOS
...
[FIX]: Build issue if OpenMP is not present
2024-05-31 09:56:39 +02:00
David Landa Marban
a6ed584ae2
[FIX]: Build issue if OpenMP is not present
2024-05-31 09:00:57 +02:00
Arne Morten Kvarving
bcbac79486
Merge pull request #5380 from akva2/linalg_template_scalar
...
LinAlg classes: template Scalar type
2024-05-31 08:40:11 +02:00
Bård Skaflestad
8b17c18ead
Merge pull request #5397 from GitPaean/renaming_calcRates
...
renaming calcRates to calcResvCoeff, and calcInjRates to calcInjResvCoeff.
2024-05-30 08:45:38 +02:00
Kai Bao
e968da28bb
renaming calcRates to calcResvCoeff
...
and calcInjRates to calcInjResvCoeff.
2024-05-29 22:29:12 +02:00
Bård Skaflestad
808035c9e8
Merge pull request #5396 from bska/activate-udq-undef-test
...
Add Regression Test for Undefined UDQ Variables
2024-05-29 16:03:41 +02:00
Bård Skaflestad
d0ea690cfa
Add Regression Test for Undefined UDQ Variables
...
Undefined UDQs get the value in UDQPARAM(3). The UDQ-01 test model
triggers an action block if and only if we implement that behaviour.
2024-05-29 13:30:43 +02:00
Bård Skaflestad
4df6880f91
Merge pull request #5334 from bska/udq-undef-smrystate-objects
...
Make SummaryState Objects Aware of Undefined UDQ Value
2024-05-29 09:49:41 +02:00
Bård Skaflestad
a3a2b7a978
Make SummaryState Objects Aware of Undefined UDQ Value
...
This PR switches to calling the SummaryState constructor which is
aware of the value of undefined UDQs (OPM/opm-common#4052 ) directly.
While here, also sort headers, split some long lines, and prefer
initialisation lists to constructor body assignments.
2024-05-29 09:16:56 +02:00
Bård Skaflestad
091f758b5a
Merge pull request #5379 from bska/delay-udq-asgn-until-after-smry-output
...
Delay UDQ Assignments Until After Summary Output
2024-05-29 09:13:30 +02:00
Bård Skaflestad
6e8da2309b
Delay UDQ Assignments Until After Summary Output
...
Commit 0aaa69c6e
(PR #5330 ) was a little too eager in its effort to
handle UDQ ASSIGN operations after action processing[%]. In
particular, the assignments, which alter the internal structures of
the SummaryState and UDQState objects, would happen prior to writing
summary files. In turn, this would make it appear as if the
assignment happened too early. This commit defers UDQ assignments
triggered by action processing until FlowProblem<>::endEpisode() for
two reasons
1. The problem originally addressed in 0aaa69c6e
only presented
when the assignment was triggered on the final time step of an
episode (report step), so handling this situation here is a
more targeted approach.
2. Member function FlowProblem<>::endEpisode() is called after we
write the summary file output so any alterations to the
internal structures of the SummaryState will not be visible in
the summary output until the next time step. This is the
expected behaviour.
[%] Insufficient testing by: [at]bska.
2024-05-28 18:16:30 +02:00
Bård Skaflestad
03e8c7ecdc
Merge pull request #5394 from atgeirr/avoid-memory-leak
...
Avoid memory leak from the *unique_ptr<X>.release() antipattern.
2024-05-28 18:15:01 +02:00
Bård Skaflestad
947033705d
Merge pull request #5391 from GitPaean/using_USE_DAMARIS_LIB
...
only trying to link darmaris when requested
2024-05-28 17:09:22 +02:00
Atgeirr Flø Rasmussen
6a7e1e08c0
Avoid memory leak from the *unique_ptr<X>.release() antipattern.
2024-05-28 16:49:08 +02:00
Bård Skaflestad
a16ef8b1c2
Merge pull request #5393 from atgeirr/avoid-out-of-scope-temporary
...
Bugfix: Avoid possible use of out-of-scope temporary.
2024-05-28 16:31:30 +02:00
Kai Bao
481c4830b5
only trying to link darmaris when requested
2024-05-28 16:16:19 +02:00
Atgeirr Flø Rasmussen
0fe76f6011
Bugfix: Avoid possible use of out-of-scope temporary.
...
Since std::clamp returns a reference we must be careful to not capture
the return value by reference, when there is a temporary among the input
parameters.
For the second change (adding the explicit Scalar return type to a lambda)
this is strictly speaking not necessary, as the lambda's return type is not
a reference, but that is obscure so the change is just done as to clarify.
2024-05-28 16:01:48 +02:00
Bård Skaflestad
8199342ce9
Merge pull request #5232 from steink/check_zero_target_from_group
...
When checking for zero target rates, also check wells under group control where required
2024-05-27 22:09:26 +02:00
Bård Skaflestad
c7c72f0ddb
Merge pull request #5389 from GitPaean/stablize_PYACTION_WCONPROD
...
limiting max time step to 10 days for PYACTION_WCONPROD
2024-05-27 17:01:10 +02:00
Kai Bao
0f9633b198
limiting max time step to 10 days for PYACTION_WCONPROD
...
to make the regression checking more stable.
2024-05-27 14:19:04 +02:00
Bård Skaflestad
2bb47476cb
Merge pull request #5365 from lisajulia/feature/pyAction-insert-kw-WECON-WTEST
...
Add pyaction/PYACTION_WTEST_INSERT_KW.DATA to pyactionComparisons.cma…
2024-05-27 10:45:15 +02:00
Bård Skaflestad
7175a74879
Merge pull request #5345 from lisajulia/feature/pyAction-insert-kw-GRUPTREE-WGRUPCON-WELSPECS
...
Add pyaction/PYACTION_GRUPTREE_INSERT_KW.DATA to pyactionComparisons.…
2024-05-27 10:44:37 +02:00