Arne Morten Kvarving
8111d2eaa0
move EclWriter parameters to TypeTag-free parameter system
2024-08-16 13:22:15 +02:00
Arne Morten Kvarving
414f313d2a
move FlowProblem parameters to TypeTag-free parameter system
2024-08-16 13:20:06 +02:00
Arne Morten Kvarving
fdcc9a0fb2
fixed: EnableDebuggingChecks is a property, not a parameter
2024-08-16 13:20:06 +02:00
Arne Morten Kvarving
9141f2c2d5
move Damaris parameters to TypeTag-free parameter system
2024-08-16 13:20:06 +02:00
Arne Morten Kvarving
94c30a74b8
move NonLinearSolver parameters to TypeTag-free parameter system
2024-08-16 13:20:06 +02:00
Arne Morten Kvarving
dd1bc8d75b
move FlowBaseVanguard parameters to TypeTag-free parameter system
2024-08-16 13:20:06 +02:00
Arne Morten Kvarving
bfe6f47d58
move FlowMain parameters to TypeTag-free parameter system
2024-08-16 13:20:06 +02:00
Arne Morten Kvarving
3716ee664d
move BlackoilModel parameters to TypeTag-free parameter system
2024-08-16 13:20:04 +02:00
Arne Morten Kvarving
febb359951
move VtkTracerModule parameters to TypeTag-free parameter system
2024-08-16 13:17:56 +02:00
Arne Morten Kvarving
aab40a32e2
move EnableTerminalOutput parameter to TypeTag-free parameter system
2024-08-16 13:17:56 +02:00
Tor Harald Sandve
0371cd5342
Change defaults
...
Use implicit IPR as default
Allow for switching of control during local well solves as default
2024-08-16 10:16:04 +02:00
Tor Harald Sandve
d7331ca3ae
use -1 as defult min-strict-iter
2024-08-16 10:16:04 +02:00
Tor Harald Sandve
36a58445b4
use 10-7 as default mass balance tolerance
2024-08-16 10:16:04 +02:00
Bård Skaflestad
9c1239a63f
Merge pull request #5529 from akva2/typetag_free_params2
...
Move parameters to typetag free parameter system: Batch 3
2024-08-14 14:44:27 +02:00
Bård Skaflestad
366a9de26f
Merge pull request #5530 from totto82/renameMIMtoMTR
...
rename GMIM to GMTR
2024-08-14 13:57:43 +02:00
Markus Blatt
ac232197dc
Merge pull request #5510 from lisajulia/fix/COMPDAT-NLDD-parallel
...
Fix/compdat nldd parallel
2024-08-14 11:18:28 +02:00
Tor Harald Sandve
42500f41bb
rename GMIM to GMTR
2024-08-14 09:48:25 +02:00
Arne Morten Kvarving
0a662e8b21
EnableGravity moved to TypeTag-free parameter system
2024-08-14 09:16:47 +02:00
Arne Morten Kvarving
8fb6fb8aa3
VtkBlackoilModule parameters moved to TypeTag-free parameter system
2024-08-14 08:58:16 +02:00
Arne Morten Kvarving
73a559312d
VtkTemperatureModule parameters moved to TypeTag-free parameter system
2024-08-14 08:52:00 +02:00
Arne Morten Kvarving
0d59aeef6e
VtkPrimaryVars parameters moved to TypeTag-free parameter system
2024-08-14 08:40:45 +02:00
Lisa Julia Nebel
87a46d7b01
Fix NLDD solver for parallel runs with the COMPDAT keyword inside an ACTIONX
2024-08-14 08:31:37 +02:00
Arne Morten Kvarving
84e6b0183b
VtkCompositionModule parameters moved to TypeTag-free parameter system
2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
48321e857e
VtkDiffusionModule parameters moved to TypeTag-free parameter system
2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
eb37499b17
VtkMultiphaseModule parameters moved to TypeTag-free parameter system
2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
64557a136d
NewtonMaxIterations moved to TypeTag-free parameter system
2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
643efb7108
NewtonTargetIterations moved to TypeTag-free parameter system
2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
0bbcb09480
NewtonMaxError moved to TypeTag-free parameter system
2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
0195f8f113
NewtonTolerance moved to TypeTag-free parameter system
2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
6280602201
NewtonWriteConvergence moved to TypeTag-free parameter system
2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
b81c00292b
NewtonVerbose moved to TypeTag-free parameter system
2024-08-13 20:13:28 +02:00
Arne Morten Kvarving
53730ce5cf
EnableThermodynamicHints moved to TypeTag-free parameter system
2024-08-13 14:30:50 +02:00
Arne Morten Kvarving
08b227f7e3
EnableStorageCache moved to TypeTag-free parameter system
2024-08-13 14:03:02 +02:00
Arne Morten Kvarving
77f0cda5d4
EnableIntensiveQuantityCache moved to TypeTag-free parameter system
2024-08-13 13:38:52 +02:00
Arne Morten Kvarving
d5d9bca291
MaxTimeStepDivisions moved to TypeTag-free parameter system
2024-08-13 12:31:02 +02:00
Arne Morten Kvarving
3e53ba2d42
MinTimeStepSize moved to TypeTag-free parameter system
2024-08-13 12:02:42 +02:00
Arne Morten Kvarving
bff4774f84
MaxTimeStepSize moved to TypeTag-free parameter system
2024-08-13 11:38:05 +02:00
Arne Morten Kvarving
fd012efac8
EnableVtkOutput moved to TypeTag-free parameter system
2024-08-13 10:30:50 +02:00
Arne Morten Kvarving
18a18a64c7
OutputDir moved to TypeTag-free parameter system
2024-08-12 15:51:19 +02:00
Arne Morten Kvarving
e5bedd3b47
EnableGridAdaptation moved to TypeTag-free parameter system
2024-08-12 15:28:58 +02:00
Arne Morten Kvarving
9e11888ccb
ThreadsPerProcess moved to TypeTag-free parameter system
2024-08-12 14:48:56 +02:00
Arne Morten Kvarving
a20cb10572
InitialTimeStepSize moved to TypeTag-free parameter system
2024-08-12 13:56:36 +02:00
Arne Morten Kvarving
3e8929b04f
EndTime moved to TypeTag-free parameter system
2024-08-12 13:45:31 +02:00
Arne Morten Kvarving
91a0fd79a9
RestartTime moved to TypeTag-free parameter system
2024-08-12 13:32:22 +02:00
Arne Morten Kvarving
2f8c91222f
PrintParameters moved to TypeTag-free parameter system
2024-08-12 13:24:44 +02:00
Arne Morten Kvarving
c80219c85f
PredeterminedTimeStepsFile moved to TypeTag-free parameter system
2024-08-12 13:14:46 +02:00
Bård Skaflestad
27c498f75a
Merge pull request #5511 from akva2/typetag_free_param_system
...
Support type-tag free parameter system
2024-08-09 18:02:26 +02:00
Arne Morten Kvarving
9204ff95a2
Merge pull request #5499 from daavid00/vtkDryRun
...
Write vtk (if enabled) for dry runs
2024-08-09 16:57:37 +02:00
David Landa Marban
d4890d18f7
Write vtk (if enabled) for dry runs
2024-08-09 15:29:32 +02:00
Arne Morten Kvarving
554a261c7f
adapt to ParameterSystem printValues change
2024-08-09 10:56:08 +02:00
Arne Morten Kvarving
139e64ea2e
adapt to ParameterSystem printUnused change
2024-08-09 10:56:08 +02:00
Arne Morten Kvarving
bb83dea71c
adapt to ParameterSystem endRegistration change
2024-08-09 10:56:08 +02:00
Arne Morten Kvarving
e1bcd00a36
adapt to ParameterSystem typetag removal
2024-08-09 10:56:07 +02:00
Tor Harald Sandve
0a63fc8e24
Move modification of density to convectiveMixingModule
2024-08-09 10:53:38 +02:00
Trine Mykkeltvedt
f10c44279f
adressed minor comments by reviewer, added enableConvectiveMixing flag to drsdtcon, fixed indentation and bug in lastRs for gas/water
2024-08-09 10:51:19 +02:00
Trine Mykkeltvedt
ab2bd924db
extending drsdtcon with regimes, and option for GAS/WATER
2024-08-09 10:48:00 +02:00
Bård Skaflestad
ad595fed5e
Merge pull request #5506 from akva2/move_params_to_parameters
...
Move parameters to Opm::Parameters namespace
2024-08-09 09:16:10 +02:00
Kai Bao
3d794d2d80
using std::from_chars instead of std::stoi
2024-08-08 16:12:17 +02:00
Kai Bao
52da2c9dfe
avoiding unnecessary exception from std::stoi("")
...
in FlowMain.hpp
2024-08-08 15:46:31 +02:00
Markus Blatt
a6006b0c93
Merge pull request #5505 from lisajulia/fix/COMPDAT-NLDD
...
Fix the usage of the COMPDAT keyword in an ACTIONX for the NLDD solver for sequential runs
2024-08-08 15:35:00 +02:00
Bård Skaflestad
a336f0df90
Merge pull request #5514 from akva2/remove_print_properties
...
Remove support for the print-properties parameter
2024-08-08 10:14:48 +02:00
Lisa Julia Nebel
f6a06f2639
Change the type of the argument possibleFutureConnections from a pointer to a const reference
2024-08-08 09:19:32 +02:00
Arne Morten Kvarving
60e69fc5ff
print-properties parameter has been removed
2024-08-07 11:47:20 +02:00
Kai Bao
2cb471356e
Merge pull request #5504 from GitPaean/avoiding_unnecessary_exception
...
avoiding exception from std::stoi("")
2024-08-07 10:36:45 +02:00
Lisa Julia Nebel
9a97a8d658
Make test on one process pass by taking the possible future connections into account when creating the sparsity pattern of the jacobian and when creating the partitions for the solver
2024-08-06 16:07:01 +02:00
Tobias Meyer Andersen
b905b5ec33
correct comment
2024-08-06 15:26:25 +02:00
Arne Morten Kvarving
a65ddff8f6
changed: BlackoilModel parameters moved to Opm::Parameters namespace
2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
b69439aa1f
changed: EclWriter parameters moved to Opm::Parameters namespace
2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
917fdbedfd
changed: FlowProblem parameters moved to Opm::Parameters namespace
2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
2a52cf8134
changed: Damaris parameters moved to Opm::Parameters namespace
2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
d75b91aaba
changed: SimulatorFullyImplicitBlackoil parameters moved to Opm::Parameters namespace
2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
466e26d330
changed: FlowMain parameters moved to Opm::Parameters namespace
2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
4fc1487a9d
changed: FlowBaseVanguard parameters moved to Opm::Parameters namespace
2024-08-06 09:50:02 +02:00
Arne Morten Kvarving
7aeaf6f216
changed: VtkTracerModule parameters moved to Opm::Parameters namespace
2024-08-06 07:38:14 +02:00
Arne Morten Kvarving
f9016b02ef
changed: NonlinearSolver parameters moved to Opm::Parameters namespace
2024-08-06 07:31:57 +02:00
Arne Morten Kvarving
00d902d79f
changed: OutputBlackoilModule parameters moved to Opm::Parameters namespace
2024-08-06 07:25:35 +02:00
Arne Morten Kvarving
6f7fcb5872
changed: EclTimeStepping parameters moved to Opm::Parameters namespace
2024-08-06 07:05:08 +02:00
Lisa Julia Nebel
8cd53ecea7
Change type of possibleFutureConnections to std::unordered_map<std::string, std::set<int>>
...
Now it contains the global ids of the perforated cells for each well instead of the coordinates ijk
2024-08-05 19:31:54 +02:00
Kai Bao
7803c55a88
avoiding exception from std::stoi("")
...
when not setting OMP_NUM_THREADS in the environment.
2024-08-05 11:48:54 +02:00
Arne Morten Kvarving
f251370a52
changed: EnableGravity parameter moved to Opm::Parameters namespace
2024-08-02 09:04:08 +02:00
Atgeirr Flø Rasmussen
c26271f774
Merge pull request #5493 from akva2/move_vtk_params_to_params
...
Move vtk parameters to Opm::Parameters namespace
2024-08-01 13:01:51 +02:00
Arne Morten Kvarving
c8a3729199
changed: VtkWriteTemperature parameter moved to Opm::Parameters namespace
2024-07-30 13:29:31 +02:00
Arne Morten Kvarving
ec01d7694b
changed: VtkPrimaryVarsModule parameters moved to Opm::Parameters namespace
2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
825540691c
changed: VtkCompositionModule parameters moved to Opm::Parameters namespace
2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
1759d37f89
changed: VtkBlackoilModule parameters moved to Opm::Parameters namespace
2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
22794f83d1
changed: VtkDiffusionModule parameters moved to Opm::Parameters namespace
2024-07-30 13:12:54 +02:00
Arne Morten Kvarving
58bb7da544
changed: VtkMultiPhaseModule parameters moved to Opm::Parameters namespace
2024-07-30 13:12:54 +02:00
Lisa Julia Nebel
efb18d0027
Add possible future connections to the grid methods that handle the well connections
2024-07-29 09:59:52 +02:00
David Landa Marban
8320a9abdf
Output support for RSWSAT and RVWSAT
2024-07-17 13:00:38 +02:00
Markus Blatt
6e74fea547
Merge pull request #5477 from lisajulia/feature/metis-support
...
Add the metis partitioner as a command line option as well
2024-07-17 07:32:39 +02:00
Lisa Julia Nebel
653cb28bc2
Add the metis partitioner as a command line option as well
2024-07-16 17:39:28 +02:00
Lisa Julia Nebel
e2126ae817
Use the failure flag of the tasklet runner to detect a failure while writing output and throw an error if that happens
2024-07-15 08:51:25 +02:00
Vegard Kippe
a078eaacd3
Removing trailing 'p'
2024-07-11 18:15:16 +02:00
Vegard Kippe
dd08952967
Update after move of ThreadsPerProcess from Properties to Parameters
2024-07-11 15:55:34 +02:00
Vegard Kippe
14818028f0
Handle empty or invalied OMP_NUM_THREADS by Flow default and warn if a valid value overrides --threads-per-process
2024-07-11 15:52:20 +02:00
Bård Skaflestad
758a5f0dfd
Merge pull request #5450 from blattms/feature/remove-axisCentroid-copy
...
[refactor] Remove unnecessary copy in axisCentroid and simply code.
2024-07-04 23:04:21 +02:00
Markus Blatt
0caf92c6a6
Merge pull request #5448 from atgeirr/ensure-initialized-members-bdystate
...
Ensure all members are initialized in FlowProblem::boundaryFluidState().
2024-07-04 16:43:05 +02:00
Markus Blatt
3ee2830d28
Change distanceVector_ to take the element index instead of centroid
2024-07-04 14:40:28 +02:00
Arne Morten Kvarving
fb6286d795
changed: PredeterminedTimeStepsFile parameter moved to Opm::Parameters namespace
2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
dfcf2358fe
changed: RestartTime parameter moved to Opm::Parameters namespace
2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
b4c6a1a240
changed: InitialTimeStepSize parameter moved to Opm::Parameters namespace
2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
1f967940f1
changed: EndTime parameter moved to Opm::Parameters namespace
2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
1e0f2b61b6
changed: PrintParameters parameter moved to Opm::Parameters namespace
2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
0db393fc07
changed: PrintProperties parameter moved to Opm::Parameters namespace
2024-07-01 17:52:10 +02:00
Arne Morten Kvarving
82cd3a2e01
changed: NewtonMaxIterations parameter moved to Opm::Parameters namespace
2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
8def6b722b
changed: NewtonTargetIterations parameter moved to Opm::Parameters namespace
2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
0342566fd6
changed: NewtonMaxError parameter moved to Opm::Parameters namespace
2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
514eddc950
changed: NewtonTolerance parameter moved to Opm::Parameters namespace
2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
389ea1ef8b
changed: NewtonWriteConvergence parameter moved to Opm::Parameters namespace
2024-07-01 14:13:48 +02:00
Arne Morten Kvarving
1a63dcdf8b
changed: NewtonVerbose parameter moved to Opm::Parameters namespace
2024-07-01 14:13:48 +02:00
Bård Skaflestad
9f8075e8a0
Merge pull request #5455 from akva2/fvbasediscretization_param_split
...
Adjust to to changes in fvbaseproperties.hh (moving of parameters to Opm::Parmeters namespace)
2024-07-01 13:22:26 +02:00
Arne Morten Kvarving
74a4ab7823
changed: EnableThermodynamicHints parameter moved to Opm::Parameters namespace
2024-06-28 15:26:30 +02:00
Arne Morten Kvarving
1f6ddb052d
changed: EnableStorageCache parameter moved to Opm::Parameters namespace
2024-06-28 15:13:13 +02:00
Arne Morten Kvarving
02f1c6c230
changed: EnableIntensiveQuantitiesCache parameter moved to Opm::Parameters namespace
2024-06-28 14:59:38 +02:00
Arne Morten Kvarving
f95ec4daa1
changed: MaxTimeStepDivisions parameter moved to Opm::Parameters namespace
2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
325b841771
changed: MinTimeStepSize parameter moved to Opm::Parameters namespace
2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
e08b6b1163
changed: MaxTimeStepSize parameter moved to Opm::Parameters namespace
2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
6a03394d5b
changed: EnableVtkOutput parameter moved to Opm::Parameters namespace
2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
b3fae7f0f9
changed: OutputDir parameter moved to Opm::Parameters namespace
2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
da4471acfa
changed: EnableGridAdaptation parameter moved to Opm::Parameters namespace
2024-06-28 14:43:11 +02:00
Arne Morten Kvarving
afa62ee428
changed: ThreadsPerProcess parameter moved to Opm::Parameters namespace
2024-06-28 14:43:11 +02:00
Bård Skaflestad
ce7d415e4d
Merge pull request #5447 from blattms/feature/hide-comp-by-dune
...
[refactor] Use DUNE's dot product to hide code complexity.
2024-06-27 15:28:55 +02:00
Markus Blatt
d7c869d01a
[refactor] Remove unnecessary copy in axisCentroid and simply code.
...
We stored 3 copies of each cell centroid in axisCentroid. This seemed
to be a waste of memory and also made the function distanceVector_ hard
to understand.
With this change we omit this copy of information and simplify distanceVector_
2024-06-27 15:15:33 +02:00
Atgeirr Flø Rasmussen
a3839aaeb8
Ensure all members are initialized in boundaryFluidState().
...
Also restructure to loop over active phases instead of all
canonical phases.
2024-06-27 13:43:46 +02:00
Markus Blatt
f6a4d7b076
[refactor] Use DUNE's do product to hide code complexity.
...
this removes some explicit loops.
2024-06-27 13:29:55 +02:00
Bård Skaflestad
ac42250b25
Merge pull request #5402 from totto82/output_wetting_hyst
...
Output maximum/minimum saturations directly for restart hysteresis
2024-06-26 12:15:20 +02:00
Tor Harald Sandve
230656ec31
updateInitialHystParams
2024-06-25 12:55:02 +02:00
Bård Skaflestad
26cd7ab993
Move opm/core/props to opm/simulators/utils
...
The opm/core directory is no longer meaningful, and it contains only
components which might collectively be described as simulator
utilities.
2024-06-25 12:22:09 +02:00
Arne Morten Kvarving
981a5f8a14
clean up some comments
...
- simulator note was copied from the typetag dependent class (EclWriter)
- opm-output is no longer a separate module
2024-06-25 10:59:57 +02:00
Markus Blatt
363eaaa57b
Merge pull request #5434 from blattms/bugfix/do-not-count-nan-as-errors
...
[fix] Do not count experiencing nans as error in PRT file.
2024-06-20 16:18:49 +02:00
Tor Harald Sandve
a419390854
Merge pull request #5407 from totto82/fix_drsdt
...
avoid mass creation with drsdt
2024-06-20 12:14:22 +02:00
Markus Blatt
238b7b2980
[fix] Do not count experiencing nans as error in PRT file.
...
The simulation will just chop the time step and continue.
Note, that the error count in the PRT file is used by engineers to
decide whether a simulation was successfull. Hence the error count
should not be increased here.
2024-06-20 10:40:37 +02:00
Bård Skaflestad
acb124bbdc
Merge pull request #5426 from totto82/output_every_timestep
...
fix option for output every timestep
2024-06-19 12:09:34 +02:00
Bård Skaflestad
46523e7cd9
Merge pull request #5430 from atgeirr/fix-damaris-logging-parallel
...
Add and use DamarisOutput::handleError() helper.
2024-06-19 11:30:08 +02:00
Atgeirr Flø Rasmussen
2c99a84c87
Add and use DamarisOutput::handleError() helper.
...
This should improve error handling in parallel, and ensure
Damaris problems are logged properly.
2024-06-19 10:30:38 +02:00
Tor Harald Sandve
4f2311d1b2
Output maximum/minimum saturations directly for restart hysteresis
2024-06-18 10:39:19 +02:00
Tor Harald Sandve
366f3a2944
fix option for output every timestep
2024-06-14 15:03:43 +02:00
Tor Harald Sandve
151bba43a7
Merge pull request #5268 from svenn-t/tracer_dis_vap
...
Partitioning tracers
2024-06-14 09:08:12 +02:00
Svenn Tveit
87362d5037
Accumulate segment rates and minor fixes
2024-06-12 14:18:32 +02:00
David Landa Marban
80e00f4516
Fix to error in Clang: use 'template' keyword to treat 'data' ...
2024-06-11 09:31:48 +02:00
Bård Skaflestad
b0ee6b9c94
Merge pull request #5419 from GitPaean/only_trans_2
...
trying to release global transmissibility earlier to flatten the peak memory usage in the function finishInit()
2024-06-10 18:13:53 +02:00
Kai Bao
fd5e9d167f
addressing reviewing comments OPM/opm-simulators#5419
2024-06-10 16:08:44 +02:00
Kai Bao
062a98b305
restruct so that we can release the global trans earlier
...
in the funciton finishInit().
2024-06-10 16:08:44 +02:00
Svenn Tveit
84cdef1135
Fix solution tracers and well output.
...
-Only output or restart solution tracers for gas/oil tracers with DISGAS/VAPOIL enabled (no solution tracers in water phase!).
-Initial tracers (free/solution) will be set to zero initially if TBLK/TVDP is not given.
- Do not calculate mass transfer between free and solution tracers if it is not necessary.
-Calculate well rates using updated tracer concentrations
2024-06-10 14:50:56 +02:00
Markus Blatt
6921db4282
omit unnescessary function parameter for EDINCC
2024-06-10 14:50:55 +02:00
Svenn Tveit
adc36d64a5
Output rates to multisegment wells
2024-06-10 14:50:55 +02:00
Markus Blatt
fc67eaeeda
Prevent spurious warnings about NNCs when applying EDITNNC in parallel.
...
If we use transmissibilities for loadbalancing, then we calculate
transmissibilities twice. First on the global grid before
loadbalancing and then on the local grid after that. This is the
default. In this case all warnings will be shown correctly when
calculating the global transmissibilities.
If the user requests the same weights for all faces (command line
parameter --edge-weights-method=0) then the transmissibilities are only
calculated on the loadbalanced grid. Unfortunately, in this case only
rank 0 will issue warnings for his part including the false positives
mentioned below.
Due to load balancing many NNCs might be stored on another process,
but we still use all EDITNNC entries when computing transmissibilties
locally. Hence when applying EDITNNC on the loadbalanced grid we
will issue warnings for cases where there are no problems (e.g. NNC
between two overlap cells.
With this PR we will only warn when computing the transmissibilities
for the first time. For the default settings this will remove spurious
and duplicate warnings.
Not that for --edge-weights-method=0 nothing changes and we will still
see only warnings for the first rank including spurious one.
2024-06-10 14:50:55 +02:00
Svenn Tveit
db970d58d2
Changed to Scalar type.
...
Following commit 61bfea46c7
2024-06-10 14:48:49 +02:00
Svenn Tveit
1645559342
Fix mass exchange term.
...
Additionally, store separate well terms for free and solution tracers
2024-06-10 14:48:45 +02:00
Svenn Tveit
050ce2de3b
Fixes after rebase
2024-06-10 14:41:21 +02:00
