2016-07-19 11:19:05 -05:00
|
|
|
<?php
|
2019-10-05 10:26:10 -05:00
|
|
|
|
2017-10-12 03:13:20 -05:00
|
|
|
declare(strict_types=1);
|
|
|
|
|
2016-07-19 11:19:05 -05:00
|
|
|
namespace ShlinkioTest\Shlink\Rest\Middleware;
|
|
|
|
|
2020-01-01 14:11:53 -06:00
|
|
|
use Laminas\Diactoros\Response;
|
|
|
|
use Laminas\Diactoros\ServerRequest;
|
2022-10-23 15:47:34 -05:00
|
|
|
use PHPUnit\Framework\MockObject\MockObject;
|
2017-03-24 14:34:18 -05:00
|
|
|
use PHPUnit\Framework\TestCase;
|
2018-03-26 12:02:41 -05:00
|
|
|
use Psr\Http\Server\RequestHandlerInterface;
|
2016-07-19 11:19:05 -05:00
|
|
|
use Shlinkio\Shlink\Rest\Middleware\CrossDomainMiddleware;
|
2019-05-05 02:45:35 -05:00
|
|
|
|
2016-07-19 11:19:05 -05:00
|
|
|
class CrossDomainMiddlewareTest extends TestCase
|
|
|
|
{
|
2019-12-29 15:48:40 -06:00
|
|
|
private CrossDomainMiddleware $middleware;
|
2022-10-24 12:53:13 -05:00
|
|
|
private MockObject & RequestHandlerInterface $handler;
|
2016-07-19 11:19:05 -05:00
|
|
|
|
2022-09-11 05:02:49 -05:00
|
|
|
protected function setUp(): void
|
2016-07-19 11:19:05 -05:00
|
|
|
{
|
2020-12-31 06:28:06 -06:00
|
|
|
$this->middleware = new CrossDomainMiddleware(['max_age' => 1000]);
|
2022-10-23 15:47:34 -05:00
|
|
|
$this->handler = $this->createMock(RequestHandlerInterface::class);
|
2016-07-19 11:19:05 -05:00
|
|
|
}
|
|
|
|
|
2019-02-17 13:28:34 -06:00
|
|
|
/** @test */
|
2019-05-05 02:45:35 -05:00
|
|
|
public function nonCrossDomainRequestsAreNotAffected(): void
|
2016-07-19 11:19:05 -05:00
|
|
|
{
|
2020-01-11 13:36:17 -06:00
|
|
|
$originalResponse = (new Response())->withStatus(404);
|
2022-10-23 15:47:34 -05:00
|
|
|
$this->handler->expects($this->once())->method('handle')->willReturn($originalResponse);
|
2017-03-25 03:44:34 -05:00
|
|
|
|
2022-10-23 15:47:34 -05:00
|
|
|
$response = $this->middleware->process(new ServerRequest(), $this->handler);
|
2016-07-19 13:20:18 -05:00
|
|
|
$headers = $response->getHeaders();
|
2019-12-01 03:47:56 -06:00
|
|
|
|
2020-10-03 17:35:14 -05:00
|
|
|
self::assertSame($originalResponse, $response);
|
|
|
|
self::assertEquals(404, $response->getStatusCode());
|
|
|
|
self::assertArrayNotHasKey('Access-Control-Allow-Origin', $headers);
|
|
|
|
self::assertArrayNotHasKey('Access-Control-Allow-Methods', $headers);
|
|
|
|
self::assertArrayNotHasKey('Access-Control-Max-Age', $headers);
|
|
|
|
self::assertArrayNotHasKey('Access-Control-Allow-Headers', $headers);
|
2016-07-19 13:20:18 -05:00
|
|
|
}
|
|
|
|
|
2019-02-17 13:28:34 -06:00
|
|
|
/** @test */
|
2019-05-05 02:45:35 -05:00
|
|
|
public function anyRequestIncludesTheAllowAccessHeader(): void
|
2016-07-19 13:20:18 -05:00
|
|
|
{
|
|
|
|
$originalResponse = new Response();
|
2022-10-23 15:47:34 -05:00
|
|
|
$this->handler->expects($this->once())->method('handle')->willReturn($originalResponse);
|
2017-03-25 03:44:34 -05:00
|
|
|
|
2022-10-23 15:47:34 -05:00
|
|
|
$response = $this->middleware->process((new ServerRequest())->withHeader('Origin', 'local'), $this->handler);
|
2020-10-03 17:35:14 -05:00
|
|
|
self::assertNotSame($originalResponse, $response);
|
2016-07-19 11:19:05 -05:00
|
|
|
|
|
|
|
$headers = $response->getHeaders();
|
2019-12-01 03:47:56 -06:00
|
|
|
|
2021-01-24 02:22:46 -06:00
|
|
|
self::assertEquals('*', $response->getHeaderLine('Access-Control-Allow-Origin'));
|
2020-10-03 17:35:14 -05:00
|
|
|
self::assertArrayNotHasKey('Access-Control-Allow-Methods', $headers);
|
|
|
|
self::assertArrayNotHasKey('Access-Control-Max-Age', $headers);
|
|
|
|
self::assertArrayNotHasKey('Access-Control-Allow-Headers', $headers);
|
2016-07-19 11:19:05 -05:00
|
|
|
}
|
|
|
|
|
2019-02-17 13:28:34 -06:00
|
|
|
/** @test */
|
2019-05-05 02:45:35 -05:00
|
|
|
public function optionsRequestIncludesMoreHeaders(): void
|
2016-07-19 11:19:05 -05:00
|
|
|
{
|
2016-07-19 13:20:18 -05:00
|
|
|
$originalResponse = new Response();
|
2019-12-01 03:47:56 -06:00
|
|
|
$request = (new ServerRequest())
|
|
|
|
->withMethod('OPTIONS')
|
|
|
|
->withHeader('Origin', 'local')
|
|
|
|
->withHeader('Access-Control-Request-Headers', 'foo, bar, baz');
|
2022-10-23 15:47:34 -05:00
|
|
|
$this->handler->expects($this->once())->method('handle')->willReturn($originalResponse);
|
2016-07-19 11:19:05 -05:00
|
|
|
|
2022-10-23 15:47:34 -05:00
|
|
|
$response = $this->middleware->process($request, $this->handler);
|
2020-10-03 17:35:14 -05:00
|
|
|
self::assertNotSame($originalResponse, $response);
|
2016-07-19 11:19:05 -05:00
|
|
|
|
|
|
|
$headers = $response->getHeaders();
|
2019-12-01 03:47:56 -06:00
|
|
|
|
2021-01-24 02:22:46 -06:00
|
|
|
self::assertEquals('*', $response->getHeaderLine('Access-Control-Allow-Origin'));
|
2020-10-03 17:35:14 -05:00
|
|
|
self::assertArrayHasKey('Access-Control-Allow-Methods', $headers);
|
|
|
|
self::assertEquals('1000', $response->getHeaderLine('Access-Control-Max-Age'));
|
|
|
|
self::assertEquals('foo, bar, baz', $response->getHeaderLine('Access-Control-Allow-Headers'));
|
|
|
|
self::assertEquals(204, $response->getStatusCode());
|
2016-07-19 11:19:05 -05:00
|
|
|
}
|
2019-05-05 02:45:35 -05:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @test
|
|
|
|
* @dataProvider provideRouteResults
|
|
|
|
*/
|
|
|
|
public function optionsRequestParsesRouteMatchToDetermineAllowedMethods(
|
2021-01-24 06:49:57 -06:00
|
|
|
?string $allowHeader,
|
2021-05-23 05:31:10 -05:00
|
|
|
string $expectedAllowedMethods,
|
2019-05-05 02:45:35 -05:00
|
|
|
): void {
|
|
|
|
$originalResponse = new Response();
|
2021-01-24 06:49:57 -06:00
|
|
|
if ($allowHeader !== null) {
|
|
|
|
$originalResponse = $originalResponse->withHeader('Allow', $allowHeader);
|
|
|
|
}
|
|
|
|
$request = (new ServerRequest())->withHeader('Origin', 'local')
|
|
|
|
->withMethod('OPTIONS');
|
2022-10-23 15:47:34 -05:00
|
|
|
$this->handler->expects($this->once())->method('handle')->willReturn($originalResponse);
|
2019-05-05 02:45:35 -05:00
|
|
|
|
2022-10-23 15:47:34 -05:00
|
|
|
$response = $this->middleware->process($request, $this->handler);
|
2019-05-05 02:45:35 -05:00
|
|
|
|
2020-10-03 17:35:14 -05:00
|
|
|
self::assertEquals($response->getHeaderLine('Access-Control-Allow-Methods'), $expectedAllowedMethods);
|
|
|
|
self::assertEquals(204, $response->getStatusCode());
|
2019-05-05 02:45:35 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
public function provideRouteResults(): iterable
|
|
|
|
{
|
2021-01-24 06:49:57 -06:00
|
|
|
yield 'no allow header in response' => [null, 'GET,POST,PUT,PATCH,DELETE'];
|
|
|
|
yield 'allow header in response' => ['POST,GET', 'POST,GET'];
|
|
|
|
yield 'also allow header in response' => ['DELETE,PATCH,PUT', 'DELETE,PATCH,PUT'];
|
2019-05-05 02:45:35 -05:00
|
|
|
}
|
2020-01-11 13:36:17 -06:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @test
|
|
|
|
* @dataProvider provideMethods
|
|
|
|
*/
|
|
|
|
public function expectedStatusCodeIsReturnDependingOnRequestMethod(
|
|
|
|
string $method,
|
|
|
|
int $status,
|
2021-05-23 05:31:10 -05:00
|
|
|
int $expectedStatus,
|
2020-01-11 13:36:17 -06:00
|
|
|
): void {
|
|
|
|
$originalResponse = (new Response())->withStatus($status);
|
|
|
|
$request = (new ServerRequest())->withMethod($method)
|
|
|
|
->withHeader('Origin', 'local');
|
2022-10-23 15:47:34 -05:00
|
|
|
$this->handler->expects($this->once())->method('handle')->willReturn($originalResponse);
|
2020-01-11 13:36:17 -06:00
|
|
|
|
2022-10-23 15:47:34 -05:00
|
|
|
$response = $this->middleware->process($request, $this->handler);
|
2020-01-11 13:36:17 -06:00
|
|
|
|
2020-10-03 17:35:14 -05:00
|
|
|
self::assertEquals($expectedStatus, $response->getStatusCode());
|
2020-01-11 13:36:17 -06:00
|
|
|
}
|
|
|
|
|
|
|
|
public function provideMethods(): iterable
|
|
|
|
{
|
|
|
|
yield 'POST 200' => ['POST', 200, 200];
|
|
|
|
yield 'POST 400' => ['POST', 400, 400];
|
|
|
|
yield 'POST 500' => ['POST', 500, 500];
|
|
|
|
yield 'GET 200' => ['GET', 200, 200];
|
|
|
|
yield 'GET 400' => ['GET', 400, 400];
|
|
|
|
yield 'GET 500' => ['GET', 500, 500];
|
|
|
|
yield 'PATCH 200' => ['PATCH', 200, 200];
|
|
|
|
yield 'PATCH 400' => ['PATCH', 400, 400];
|
|
|
|
yield 'PATCH 500' => ['PATCH', 500, 500];
|
|
|
|
yield 'DELETE 200' => ['DELETE', 200, 200];
|
|
|
|
yield 'DELETE 400' => ['DELETE', 400, 400];
|
|
|
|
yield 'DELETE 500' => ['DELETE', 500, 500];
|
|
|
|
yield 'OPTIONS 200' => ['OPTIONS', 200, 204];
|
|
|
|
yield 'OPTIONS 400' => ['OPTIONS', 400, 204];
|
|
|
|
yield 'OPTIONS 500' => ['OPTIONS', 500, 204];
|
|
|
|
}
|
2016-07-19 11:19:05 -05:00
|
|
|
}
|