2016-04-17 06:42:52 -05:00
|
|
|
<?php
|
2017-10-12 03:13:20 -05:00
|
|
|
declare(strict_types=1);
|
|
|
|
|
2016-07-19 11:01:39 -05:00
|
|
|
namespace ShlinkioTest\Shlink\Core\Service;
|
2016-04-17 06:42:52 -05:00
|
|
|
|
2017-10-21 10:18:57 -05:00
|
|
|
use Cocur\Slugify\SlugifyInterface;
|
2016-08-08 03:02:52 -05:00
|
|
|
use Doctrine\Common\Cache\ArrayCache;
|
|
|
|
use Doctrine\Common\Cache\Cache;
|
2016-04-17 06:42:52 -05:00
|
|
|
use Doctrine\Common\Persistence\ObjectRepository;
|
|
|
|
use Doctrine\DBAL\Connection;
|
|
|
|
use Doctrine\ORM\EntityManagerInterface;
|
|
|
|
use Doctrine\ORM\ORMException;
|
|
|
|
use GuzzleHttp\ClientInterface;
|
|
|
|
use GuzzleHttp\Exception\ClientException;
|
|
|
|
use GuzzleHttp\Psr7\Request;
|
2017-03-24 14:34:18 -05:00
|
|
|
use PHPUnit\Framework\TestCase;
|
2016-04-17 06:42:52 -05:00
|
|
|
use Prophecy\Argument;
|
2017-10-21 10:18:57 -05:00
|
|
|
use Prophecy\Prophecy\MethodProphecy;
|
2016-04-17 06:42:52 -05:00
|
|
|
use Prophecy\Prophecy\ObjectProphecy;
|
2016-07-19 11:01:39 -05:00
|
|
|
use Shlinkio\Shlink\Core\Entity\ShortUrl;
|
2017-10-21 10:18:57 -05:00
|
|
|
use Shlinkio\Shlink\Core\Exception\NonUniqueSlugException;
|
2017-10-21 04:58:20 -05:00
|
|
|
use Shlinkio\Shlink\Core\Repository\ShortUrlRepositoryInterface;
|
2016-07-19 11:01:39 -05:00
|
|
|
use Shlinkio\Shlink\Core\Service\UrlShortener;
|
2016-04-17 06:42:52 -05:00
|
|
|
use Zend\Diactoros\Uri;
|
|
|
|
|
|
|
|
class UrlShortenerTest extends TestCase
|
|
|
|
{
|
|
|
|
/**
|
|
|
|
* @var UrlShortener
|
|
|
|
*/
|
|
|
|
protected $urlShortener;
|
|
|
|
/**
|
|
|
|
* @var ObjectProphecy
|
|
|
|
*/
|
|
|
|
protected $em;
|
|
|
|
/**
|
|
|
|
* @var ObjectProphecy
|
|
|
|
*/
|
|
|
|
protected $httpClient;
|
2016-08-08 03:02:52 -05:00
|
|
|
/**
|
|
|
|
* @var Cache
|
|
|
|
*/
|
|
|
|
protected $cache;
|
2017-10-21 10:18:57 -05:00
|
|
|
/**
|
|
|
|
* @var ObjectProphecy
|
|
|
|
*/
|
|
|
|
protected $slugger;
|
2016-04-17 06:42:52 -05:00
|
|
|
|
|
|
|
public function setUp()
|
|
|
|
{
|
|
|
|
$this->httpClient = $this->prophesize(ClientInterface::class);
|
|
|
|
|
|
|
|
$this->em = $this->prophesize(EntityManagerInterface::class);
|
|
|
|
$conn = $this->prophesize(Connection::class);
|
|
|
|
$conn->isTransactionActive()->willReturn(false);
|
|
|
|
$this->em->getConnection()->willReturn($conn->reveal());
|
|
|
|
$this->em->flush()->willReturn(null);
|
|
|
|
$this->em->commit()->willReturn(null);
|
|
|
|
$this->em->beginTransaction()->willReturn(null);
|
|
|
|
$this->em->persist(Argument::any())->will(function ($arguments) {
|
|
|
|
/** @var ShortUrl $shortUrl */
|
|
|
|
$shortUrl = $arguments[0];
|
|
|
|
$shortUrl->setId(10);
|
|
|
|
});
|
|
|
|
$repo = $this->prophesize(ObjectRepository::class);
|
|
|
|
$repo->findOneBy(Argument::any())->willReturn(null);
|
|
|
|
$this->em->getRepository(ShortUrl::class)->willReturn($repo->reveal());
|
|
|
|
|
2016-08-08 03:02:52 -05:00
|
|
|
$this->cache = new ArrayCache();
|
2017-10-21 10:18:57 -05:00
|
|
|
$this->slugger = $this->prophesize(SlugifyInterface::class);
|
2016-08-08 03:02:52 -05:00
|
|
|
|
2017-10-17 04:03:12 -05:00
|
|
|
$this->setUrlShortener(false);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
2017-10-17 04:44:30 -05:00
|
|
|
* @param bool $urlValidationEnabled
|
2017-10-17 04:03:12 -05:00
|
|
|
*/
|
2017-10-17 04:44:30 -05:00
|
|
|
public function setUrlShortener($urlValidationEnabled)
|
2017-10-17 04:03:12 -05:00
|
|
|
{
|
2017-10-21 10:18:57 -05:00
|
|
|
$this->urlShortener = new UrlShortener(
|
|
|
|
$this->httpClient->reveal(),
|
|
|
|
$this->em->reveal(),
|
|
|
|
$this->cache,
|
2017-10-17 04:44:30 -05:00
|
|
|
$urlValidationEnabled,
|
2017-10-21 10:18:57 -05:00
|
|
|
UrlShortener::DEFAULT_CHARS,
|
|
|
|
$this->slugger->reveal()
|
|
|
|
);
|
2016-04-17 06:42:52 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function urlIsProperlyShortened()
|
|
|
|
{
|
2016-05-01 04:24:00 -05:00
|
|
|
// 10 -> 12C1c
|
2016-04-17 06:42:52 -05:00
|
|
|
$shortCode = $this->urlShortener->urlToShortCode(new Uri('http://foobar.com/12345/hello?foo=bar'));
|
2016-05-01 04:24:00 -05:00
|
|
|
$this->assertEquals('12C1c', $shortCode);
|
2016-04-17 06:42:52 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @test
|
2017-12-30 14:35:26 -06:00
|
|
|
* @expectedException \Shlinkio\Shlink\Core\Exception\RuntimeException
|
2016-04-17 06:42:52 -05:00
|
|
|
*/
|
|
|
|
public function exceptionIsThrownWhenOrmThrowsException()
|
|
|
|
{
|
|
|
|
$conn = $this->prophesize(Connection::class);
|
|
|
|
$conn->isTransactionActive()->willReturn(true);
|
|
|
|
$this->em->getConnection()->willReturn($conn->reveal());
|
|
|
|
$this->em->rollback()->shouldBeCalledTimes(1);
|
|
|
|
$this->em->close()->shouldBeCalledTimes(1);
|
|
|
|
|
|
|
|
$this->em->flush()->willThrow(new ORMException());
|
|
|
|
$this->urlShortener->urlToShortCode(new Uri('http://foobar.com/12345/hello?foo=bar'));
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @test
|
2016-07-19 11:05:06 -05:00
|
|
|
* @expectedException \Shlinkio\Shlink\Core\Exception\InvalidUrlException
|
2016-04-17 06:42:52 -05:00
|
|
|
*/
|
|
|
|
public function exceptionIsThrownWhenUrlDoesNotExist()
|
|
|
|
{
|
2017-10-17 04:03:12 -05:00
|
|
|
$this->setUrlShortener(true);
|
|
|
|
|
2016-04-17 06:42:52 -05:00
|
|
|
$this->httpClient->request(Argument::cetera())->willThrow(
|
|
|
|
new ClientException('', $this->prophesize(Request::class)->reveal())
|
|
|
|
);
|
|
|
|
$this->urlShortener->urlToShortCode(new Uri('http://foobar.com/12345/hello?foo=bar'));
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function whenShortUrlExistsItsShortcodeIsReturned()
|
|
|
|
{
|
|
|
|
$shortUrl = new ShortUrl();
|
|
|
|
$shortUrl->setShortCode('expected_shortcode');
|
|
|
|
$repo = $this->prophesize(ObjectRepository::class);
|
|
|
|
$repo->findOneBy(Argument::any())->willReturn($shortUrl);
|
|
|
|
$this->em->getRepository(ShortUrl::class)->willReturn($repo->reveal());
|
|
|
|
|
|
|
|
$shortCode = $this->urlShortener->urlToShortCode(new Uri('http://foobar.com/12345/hello?foo=bar'));
|
|
|
|
$this->assertEquals($shortUrl->getShortCode(), $shortCode);
|
|
|
|
}
|
|
|
|
|
2017-10-21 10:18:57 -05:00
|
|
|
/**
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function whenCustomSlugIsProvidedItIsUsed()
|
|
|
|
{
|
|
|
|
/** @var MethodProphecy $slugify */
|
|
|
|
$slugify = $this->slugger->slugify('custom-slug')->willReturnArgument();
|
|
|
|
|
|
|
|
$this->urlShortener->urlToShortCode(
|
|
|
|
new Uri('http://foobar.com/12345/hello?foo=bar'),
|
|
|
|
[],
|
|
|
|
null,
|
|
|
|
null,
|
|
|
|
'custom-slug'
|
|
|
|
);
|
|
|
|
|
|
|
|
$slugify->shouldHaveBeenCalledTimes(1);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function exceptionIsThrownWhenNonUniqueSlugIsProvided()
|
|
|
|
{
|
|
|
|
/** @var MethodProphecy $slugify */
|
|
|
|
$slugify = $this->slugger->slugify('custom-slug')->willReturnArgument();
|
|
|
|
|
|
|
|
$repo = $this->prophesize(ShortUrlRepositoryInterface::class);
|
|
|
|
/** @var MethodProphecy $findBySlug */
|
|
|
|
$findBySlug = $repo->findOneBy(['shortCode' => 'custom-slug'])->willReturn(new ShortUrl());
|
|
|
|
$repo->findOneBy(Argument::cetera())->willReturn(null);
|
|
|
|
/** @var MethodProphecy $getRepo */
|
|
|
|
$getRepo = $this->em->getRepository(ShortUrl::class)->willReturn($repo->reveal());
|
|
|
|
|
|
|
|
$slugify->shouldBeCalledTimes(1);
|
|
|
|
$findBySlug->shouldBeCalledTimes(1);
|
|
|
|
$getRepo->shouldBeCalled();
|
|
|
|
$this->expectException(NonUniqueSlugException::class);
|
|
|
|
|
|
|
|
$this->urlShortener->urlToShortCode(
|
|
|
|
new Uri('http://foobar.com/12345/hello?foo=bar'),
|
|
|
|
[],
|
|
|
|
null,
|
|
|
|
null,
|
|
|
|
'custom-slug'
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
2016-04-17 06:42:52 -05:00
|
|
|
/**
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function shortCodeIsProperlyParsed()
|
|
|
|
{
|
2016-05-01 04:24:00 -05:00
|
|
|
// 12C1c -> 10
|
2016-08-08 03:02:52 -05:00
|
|
|
$shortCode = '12C1c';
|
2016-04-17 06:42:52 -05:00
|
|
|
$shortUrl = new ShortUrl();
|
2016-08-08 03:02:52 -05:00
|
|
|
$shortUrl->setShortCode($shortCode)
|
2016-04-17 06:42:52 -05:00
|
|
|
->setOriginalUrl('expected_url');
|
|
|
|
|
2017-10-21 04:58:20 -05:00
|
|
|
$repo = $this->prophesize(ShortUrlRepositoryInterface::class);
|
|
|
|
$repo->findOneByShortCode($shortCode)->willReturn($shortUrl);
|
2016-04-17 06:42:52 -05:00
|
|
|
$this->em->getRepository(ShortUrl::class)->willReturn($repo->reveal());
|
|
|
|
|
2016-08-09 06:32:33 -05:00
|
|
|
$this->assertFalse($this->cache->contains($shortCode . '_longUrl'));
|
2016-08-08 03:02:52 -05:00
|
|
|
$url = $this->urlShortener->shortCodeToUrl($shortCode);
|
2016-04-17 06:42:52 -05:00
|
|
|
$this->assertEquals($shortUrl->getOriginalUrl(), $url);
|
2016-08-09 06:32:33 -05:00
|
|
|
$this->assertTrue($this->cache->contains($shortCode . '_longUrl'));
|
2016-04-17 06:42:52 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @test
|
2016-07-19 11:05:06 -05:00
|
|
|
* @expectedException \Shlinkio\Shlink\Core\Exception\InvalidShortCodeException
|
2016-04-17 06:42:52 -05:00
|
|
|
*/
|
|
|
|
public function invalidCharSetThrowsException()
|
|
|
|
{
|
|
|
|
$this->urlShortener->shortCodeToUrl('&/(');
|
|
|
|
}
|
2016-08-08 03:02:52 -05:00
|
|
|
|
|
|
|
/**
|
|
|
|
* @test
|
|
|
|
*/
|
|
|
|
public function cachedShortCodeDoesNotHitDatabase()
|
|
|
|
{
|
|
|
|
$shortCode = '12C1c';
|
|
|
|
$expectedUrl = 'expected_url';
|
2016-08-09 06:32:33 -05:00
|
|
|
$this->cache->save($shortCode . '_longUrl', $expectedUrl);
|
2016-08-08 03:02:52 -05:00
|
|
|
$this->em->getRepository(ShortUrl::class)->willReturn(null)->shouldBeCalledTimes(0);
|
|
|
|
|
|
|
|
$url = $this->urlShortener->shortCodeToUrl($shortCode);
|
|
|
|
$this->assertEquals($expectedUrl, $url);
|
|
|
|
}
|
2016-04-17 06:42:52 -05:00
|
|
|
}
|