2021-07-15 10:43:29 -05:00
|
|
|
<?php
|
|
|
|
|
|
|
|
declare(strict_types=1);
|
|
|
|
|
|
|
|
namespace ShlinkioTest\Shlink\Core\Visit;
|
|
|
|
|
|
|
|
use Fig\Http\Message\RequestMethodInterface;
|
|
|
|
use Laminas\Diactoros\ServerRequestFactory;
|
|
|
|
use Mezzio\Router\Middleware\ImplicitHeadMiddleware;
|
|
|
|
use PHPUnit\Framework\TestCase;
|
|
|
|
use Prophecy\Argument;
|
|
|
|
use Prophecy\PhpUnit\ProphecyTrait;
|
|
|
|
use Prophecy\Prophecy\ObjectProphecy;
|
|
|
|
use Psr\Http\Message\ServerRequestInterface;
|
2021-10-10 15:00:22 -05:00
|
|
|
use Shlinkio\Shlink\Common\Middleware\IpAddressMiddlewareFactory;
|
2021-07-15 10:43:29 -05:00
|
|
|
use Shlinkio\Shlink\Core\Entity\ShortUrl;
|
|
|
|
use Shlinkio\Shlink\Core\ErrorHandler\Model\NotFoundType;
|
|
|
|
use Shlinkio\Shlink\Core\Options\TrackingOptions;
|
2022-09-23 11:05:17 -05:00
|
|
|
use Shlinkio\Shlink\Core\Visit\Model\Visitor;
|
2021-07-15 10:43:29 -05:00
|
|
|
use Shlinkio\Shlink\Core\Visit\RequestTracker;
|
|
|
|
use Shlinkio\Shlink\Core\Visit\VisitsTrackerInterface;
|
|
|
|
|
|
|
|
class RequestTrackerTest extends TestCase
|
|
|
|
{
|
|
|
|
use ProphecyTrait;
|
|
|
|
|
|
|
|
private const LONG_URL = 'https://domain.com/foo/bar?some=thing';
|
|
|
|
|
|
|
|
private RequestTracker $requestTracker;
|
|
|
|
private ObjectProphecy $visitsTracker;
|
|
|
|
private ObjectProphecy $notFoundType;
|
|
|
|
private ServerRequestInterface $request;
|
|
|
|
|
|
|
|
protected function setUp(): void
|
|
|
|
{
|
|
|
|
$this->notFoundType = $this->prophesize(NotFoundType::class);
|
|
|
|
$this->visitsTracker = $this->prophesize(VisitsTrackerInterface::class);
|
|
|
|
|
|
|
|
$this->requestTracker = new RequestTracker(
|
|
|
|
$this->visitsTracker->reveal(),
|
2022-09-17 05:57:04 -05:00
|
|
|
new TrackingOptions(
|
|
|
|
disableTrackParam: 'foobar',
|
|
|
|
disableTrackingFrom: ['80.90.100.110', '192.168.10.0/24', '1.2.*.*'],
|
|
|
|
),
|
2021-07-15 10:43:29 -05:00
|
|
|
);
|
|
|
|
|
|
|
|
$this->request = ServerRequestFactory::fromGlobals()->withAttribute(
|
|
|
|
NotFoundType::class,
|
|
|
|
$this->notFoundType->reveal(),
|
|
|
|
);
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @test
|
|
|
|
* @dataProvider provideNonTrackingRequests
|
|
|
|
*/
|
|
|
|
public function trackingIsDisabledWhenRequestDoesNotMeetConditions(ServerRequestInterface $request): void
|
|
|
|
{
|
|
|
|
$shortUrl = ShortUrl::withLongUrl(self::LONG_URL);
|
|
|
|
|
|
|
|
$this->requestTracker->trackIfApplicable($shortUrl, $request);
|
|
|
|
|
|
|
|
$this->visitsTracker->track(Argument::cetera())->shouldNotHaveBeenCalled();
|
|
|
|
}
|
|
|
|
|
|
|
|
public function provideNonTrackingRequests(): iterable
|
|
|
|
{
|
|
|
|
yield 'forwarded from head' => [ServerRequestFactory::fromGlobals()->withAttribute(
|
|
|
|
ImplicitHeadMiddleware::FORWARDED_HTTP_METHOD_ATTRIBUTE,
|
|
|
|
RequestMethodInterface::METHOD_HEAD,
|
|
|
|
)];
|
|
|
|
yield 'disable track param' => [ServerRequestFactory::fromGlobals()->withQueryParams(['foobar' => 'foo'])];
|
|
|
|
yield 'disable track param as null' => [
|
|
|
|
ServerRequestFactory::fromGlobals()->withQueryParams(['foobar' => null]),
|
|
|
|
];
|
2021-10-10 15:00:22 -05:00
|
|
|
yield 'exact remote address' => [ServerRequestFactory::fromGlobals()->withAttribute(
|
|
|
|
IpAddressMiddlewareFactory::REQUEST_ATTR,
|
|
|
|
'80.90.100.110',
|
|
|
|
)];
|
|
|
|
yield 'matching wildcard remote address' => [ServerRequestFactory::fromGlobals()->withAttribute(
|
|
|
|
IpAddressMiddlewareFactory::REQUEST_ATTR,
|
|
|
|
'1.2.3.4',
|
|
|
|
)];
|
|
|
|
yield 'matching CIDR block remote address' => [ServerRequestFactory::fromGlobals()->withAttribute(
|
|
|
|
IpAddressMiddlewareFactory::REQUEST_ATTR,
|
|
|
|
'192.168.10.100',
|
|
|
|
)];
|
2021-07-15 10:43:29 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
/** @test */
|
|
|
|
public function trackingHappensOverShortUrlsWhenRequestMeetsConditions(): void
|
|
|
|
{
|
|
|
|
$shortUrl = ShortUrl::withLongUrl(self::LONG_URL);
|
|
|
|
|
|
|
|
$this->requestTracker->trackIfApplicable($shortUrl, $this->request);
|
|
|
|
|
|
|
|
$this->visitsTracker->track($shortUrl, Argument::type(Visitor::class))->shouldHaveBeenCalledOnce();
|
|
|
|
}
|
|
|
|
|
|
|
|
/** @test */
|
|
|
|
public function baseUrlErrorIsTracked(): void
|
|
|
|
{
|
|
|
|
$isBaseUrl = $this->notFoundType->isBaseUrl()->willReturn(true);
|
|
|
|
$isRegularNotFound = $this->notFoundType->isRegularNotFound()->willReturn(false);
|
|
|
|
$isInvalidShortUrl = $this->notFoundType->isInvalidShortUrl()->willReturn(false);
|
|
|
|
|
|
|
|
$this->requestTracker->trackNotFoundIfApplicable($this->request);
|
|
|
|
|
|
|
|
$isBaseUrl->shouldHaveBeenCalledOnce();
|
|
|
|
$isRegularNotFound->shouldNotHaveBeenCalled();
|
|
|
|
$isInvalidShortUrl->shouldNotHaveBeenCalled();
|
|
|
|
$this->visitsTracker->trackBaseUrlVisit(Argument::type(Visitor::class))->shouldHaveBeenCalledOnce();
|
|
|
|
$this->visitsTracker->trackRegularNotFoundVisit(Argument::type(Visitor::class))->shouldNotHaveBeenCalled();
|
|
|
|
$this->visitsTracker->trackInvalidShortUrlVisit(Argument::type(Visitor::class))->shouldNotHaveBeenCalled();
|
|
|
|
}
|
|
|
|
|
|
|
|
/** @test */
|
|
|
|
public function regularNotFoundErrorIsTracked(): void
|
|
|
|
{
|
|
|
|
$isBaseUrl = $this->notFoundType->isBaseUrl()->willReturn(false);
|
|
|
|
$isRegularNotFound = $this->notFoundType->isRegularNotFound()->willReturn(true);
|
|
|
|
$isInvalidShortUrl = $this->notFoundType->isInvalidShortUrl()->willReturn(false);
|
|
|
|
|
|
|
|
$this->requestTracker->trackNotFoundIfApplicable($this->request);
|
|
|
|
|
|
|
|
$isBaseUrl->shouldHaveBeenCalledOnce();
|
|
|
|
$isRegularNotFound->shouldHaveBeenCalledOnce();
|
|
|
|
$isInvalidShortUrl->shouldNotHaveBeenCalled();
|
|
|
|
$this->visitsTracker->trackBaseUrlVisit(Argument::type(Visitor::class))->shouldNotHaveBeenCalled();
|
|
|
|
$this->visitsTracker->trackRegularNotFoundVisit(Argument::type(Visitor::class))->shouldHaveBeenCalledOnce();
|
|
|
|
$this->visitsTracker->trackInvalidShortUrlVisit(Argument::type(Visitor::class))->shouldNotHaveBeenCalled();
|
|
|
|
}
|
|
|
|
|
|
|
|
/** @test */
|
|
|
|
public function invalidShortUrlErrorIsTracked(): void
|
|
|
|
{
|
|
|
|
$isBaseUrl = $this->notFoundType->isBaseUrl()->willReturn(false);
|
|
|
|
$isRegularNotFound = $this->notFoundType->isRegularNotFound()->willReturn(false);
|
|
|
|
$isInvalidShortUrl = $this->notFoundType->isInvalidShortUrl()->willReturn(true);
|
|
|
|
|
|
|
|
$this->requestTracker->trackNotFoundIfApplicable($this->request);
|
|
|
|
|
|
|
|
$isBaseUrl->shouldHaveBeenCalledOnce();
|
|
|
|
$isRegularNotFound->shouldHaveBeenCalledOnce();
|
|
|
|
$isInvalidShortUrl->shouldHaveBeenCalledOnce();
|
|
|
|
$this->visitsTracker->trackBaseUrlVisit(Argument::type(Visitor::class))->shouldNotHaveBeenCalled();
|
|
|
|
$this->visitsTracker->trackRegularNotFoundVisit(Argument::type(Visitor::class))->shouldNotHaveBeenCalled();
|
|
|
|
$this->visitsTracker->trackInvalidShortUrlVisit(Argument::type(Visitor::class))->shouldHaveBeenCalledOnce();
|
|
|
|
}
|
|
|
|
|
|
|
|
/**
|
|
|
|
* @test
|
|
|
|
* @dataProvider provideNonTrackingRequests
|
|
|
|
*/
|
|
|
|
public function notFoundIsNotTrackedIfRequestDoesNotMeetConditions(ServerRequestInterface $request): void
|
|
|
|
{
|
|
|
|
$this->requestTracker->trackNotFoundIfApplicable($request);
|
|
|
|
|
|
|
|
$this->visitsTracker->trackBaseUrlVisit(Argument::cetera())->shouldNotHaveBeenCalled();
|
|
|
|
$this->visitsTracker->trackRegularNotFoundVisit(Argument::cetera())->shouldNotHaveBeenCalled();
|
|
|
|
$this->visitsTracker->trackInvalidShortUrlVisit(Argument::cetera())->shouldNotHaveBeenCalled();
|
|
|
|
}
|
|
|
|
}
|