diff --git a/CHANGELOG.md b/CHANGELOG.md index 7575178b..4f821b7d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,6 +4,23 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](https://keepachangelog.com), and this project adheres to [Semantic Versioning](https://semver.org). +## [Unreleased] +### Added +* *Nothing* + +### Changed +* Run RoadRunner in docker with `exec` to ensure signals are properly handled. + +### Deprecated +* *Nothing* + +### Removed +* *Nothing* + +### Fixed +* *Nothing* + + ## [4.2.3] - 2024-10-17 ### Added * *Nothing* diff --git a/data/infra/roadrunner.Dockerfile b/data/infra/roadrunner.Dockerfile index 33768eda..006aea91 100644 --- a/data/infra/roadrunner.Dockerfile +++ b/data/infra/roadrunner.Dockerfile @@ -72,5 +72,5 @@ CMD \ if [[ ! -d "./vendor" ]]; then /usr/local/bin/composer install ; fi && \ # Download roadrunner binary if [[ ! -f "./bin/rr" ]]; then ./vendor/bin/rr get --no-interaction --no-config --location bin/ && chmod +x bin/rr ; fi && \ - # This forces the app to be started every second until the exit code is 0 - until ./bin/rr serve -c config/roadrunner/.rr.dev.yml; do sleep 1 ; done + # Run with `exec` so that signals are properly handled + exec ./bin/rr serve -c config/roadrunner/.rr.dev.yml diff --git a/docker/docker-entrypoint.sh b/docker/docker-entrypoint.sh index e2cce68f..e1acd118 100644 --- a/docker/docker-entrypoint.sh +++ b/docker/docker-entrypoint.sh @@ -26,5 +26,6 @@ fi php vendor/bin/shlink-installer init ${flags} if [ "$SHLINK_RUNTIME" = 'rr' ]; then - ./bin/rr serve -c config/roadrunner/.rr.yml + # Run with `exec` so that signals are properly handled + exec ./bin/rr serve -c config/roadrunner/.rr.yml fi