OilfieldToolsNet/shlink
4
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Improved public API in Tag entity, avoiding anemic model

Browse Source
This commit is contained in:
Alejandro Celaya
2018-10-28 14:38:43 +01:00
parent f7ceeff05a
commit 084b1169d7
11 changed files with 23 additions and 25 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
module/CLI/src/Command/Tag/ListTagsCommand.php
View File

@@ -53,7 +53,7 @@ class ListTagsCommand extends Command
}
return array_map(function (Tag $tag) {
return [$tag->getName()];
return [(string) $tag];
}, $tags);
}
}

4
module/CLI/test/Command/Tag/ListTagsCommandTest.php
View File

@@ -61,8 +61,8 @@ class ListTagsCommandTest extends TestCase
{
/** @var MethodProphecy $listTags */
$listTags = $this->tagService->listTags()->willReturn([
(new Tag())->setName('foo'),
(new Tag())->setName('bar'),
new Tag('foo'),
new Tag('bar'),
]);
$this->commandTester->execute([]);

2
module/CLI/test/Command/Tag/RenameTagCommandTest.php
View File

@@ -68,7 +68,7 @@ class RenameTagCommandTest extends TestCase
$oldName = 'foo';
$newName = 'bar';
/** @var MethodProphecy $renameTag */
$renameTag = $this->tagService->renameTag($oldName, $newName)->willReturn(new Tag());
$renameTag = $this->tagService->renameTag($oldName, $newName)->willReturn(new Tag($newName));
$this->commandTester->execute([
'oldName' => $oldName,