OilfieldToolsNet/shlink
4
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2026-07-29 23:58:04 -05:00
Code Issues Packages Projects Releases Wiki Activity

Migrated ShortUrlTitleResolutionHelperTest to use PHPUnit mocks

Browse Source
This commit is contained in:
Alejandro Celaya
2022-10-23 17:38:04 +02:00
parent 5aaf50d68e
commit 162e913cc4
1 changed files with 13 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files
module/Core/test/ShortUrl/Helper/ShortUrlTitleResolutionHelperTest.php
+13 -12
View File
@@ -4,24 +4,21 @@ declare(strict_types=1);
namespace ShlinkioTest\Shlink\Core\ShortUrl\Helper; namespace ShlinkioTest\Shlink\Core\ShortUrl\Helper;
use PHPUnit\Framework\MockObject\MockObject;
use PHPUnit\Framework\TestCase; use PHPUnit\Framework\TestCase;
use Prophecy\PhpUnit\ProphecyTrait;
use Prophecy\Prophecy\ObjectProphecy;
use Shlinkio\Shlink\Core\ShortUrl\Helper\ShortUrlTitleResolutionHelper; use Shlinkio\Shlink\Core\ShortUrl\Helper\ShortUrlTitleResolutionHelper;
use Shlinkio\Shlink\Core\ShortUrl\Model\ShortUrlCreation; use Shlinkio\Shlink\Core\ShortUrl\Model\ShortUrlCreation;
use Shlinkio\Shlink\Core\Util\UrlValidatorInterface; use Shlinkio\Shlink\Core\Util\UrlValidatorInterface;
class ShortUrlTitleResolutionHelperTest extends TestCase class ShortUrlTitleResolutionHelperTest extends TestCase
{ {
use ProphecyTrait;
private ShortUrlTitleResolutionHelper $helper; private ShortUrlTitleResolutionHelper $helper;
private ObjectProphecy $urlValidator; private MockObject $urlValidator;
protected function setUp(): void protected function setUp(): void
{ {
$this->urlValidator = $this->prophesize(UrlValidatorInterface::class); $this->urlValidator = $this->createMock(UrlValidatorInterface::class);
$this->helper = new ShortUrlTitleResolutionHelper($this->urlValidator->reveal()); $this->helper = new ShortUrlTitleResolutionHelper($this->urlValidator);
} }
/** /**
@@ -31,14 +28,18 @@ class ShortUrlTitleResolutionHelperTest extends TestCase
public function urlIsProperlyShortened(?string $title, int $validateWithTitleCallsNum, int $validateCallsNum): void public function urlIsProperlyShortened(?string $title, int $validateWithTitleCallsNum, int $validateCallsNum): void
{ {
$longUrl = 'http://foobar.com/12345/hello?foo=bar'; $longUrl = 'http://foobar.com/12345/hello?foo=bar';
$this->urlValidator->expects($this->exactly($validateWithTitleCallsNum))->method('validateUrlWithTitle')->with(
$this->equalTo($longUrl),
$this->isFalse(),
);
$this->urlValidator->expects($this->exactly($validateCallsNum))->method('validateUrl')->with(
$this->equalTo($longUrl),
$this->isFalse(),
);
$this->helper->processTitleAndValidateUrl( $this->helper->processTitleAndValidateUrl(
ShortUrlCreation::fromRawData(['longUrl' => $longUrl, 'title' => $title]), ShortUrlCreation::fromRawData(['longUrl' => $longUrl, 'title' => $title]),
); );
$this->urlValidator->validateUrlWithTitle($longUrl, false)->shouldHaveBeenCalledTimes(
$validateWithTitleCallsNum,
);
$this->urlValidator->validateUrl($longUrl, false)->shouldHaveBeenCalledTimes($validateCallsNum);
} }
public function provideTitles(): iterable public function provideTitles(): iterable