Added more stricter types for mocks

This commit is contained in:
Alejandro Celaya
2022-10-24 19:59:03 +02:00
parent 51f243995a
commit 1650499a38
18 changed files with 35 additions and 34 deletions

View File

@@ -17,8 +17,8 @@ use Shlinkio\Shlink\IpGeolocation\Model\Location;
class LocateUnlocatedVisitsTest extends TestCase
{
private LocateUnlocatedVisits $listener;
private MockObject $locator;
private MockObject $visitToLocation;
private MockObject & VisitLocatorInterface $locator;
private MockObject & VisitToLocationHelperInterface $visitToLocation;
protected function setUp(): void
{

View File

@@ -22,10 +22,10 @@ use Throwable;
class NotifyVisitToRedisTest extends TestCase
{
private MockObject $helper;
private MockObject $updatesGenerator;
private MockObject $em;
private MockObject $logger;
private MockObject & PublishingHelperInterface $helper;
private MockObject & PublishingUpdatesGeneratorInterface $updatesGenerator;
private MockObject & EntityManagerInterface $em;
private MockObject & LoggerInterface $logger;
protected function setUp(): void
{

View File

@@ -23,8 +23,8 @@ use function sprintf;
class DeleteShortUrlServiceTest extends TestCase
{
private MockObject $em;
private MockObject $urlResolver;
private MockObject & EntityManagerInterface $em;
private MockObject & ShortUrlResolverInterface $urlResolver;
private string $shortCode;
protected function setUp(): void

View File

@@ -16,8 +16,8 @@ use Shlinkio\Shlink\Core\ShortUrl\Repository\ShortUrlRepository;
class ShortCodeUniquenessHelperTest extends TestCase
{
private ShortCodeUniquenessHelper $helper;
private MockObject $em;
private MockObject $shortUrl;
private MockObject & EntityManagerInterface $em;
private MockObject & ShortUrl $shortUrl;
protected function setUp(): void
{

View File

@@ -19,7 +19,7 @@ use function Functional\const_function;
class TrimTrailingSlashMiddlewareTest extends TestCase
{
private MockObject $requestHandler;
private MockObject & RequestHandlerInterface $requestHandler;
protected function setUp(): void
{

View File

@@ -28,8 +28,8 @@ class ShortUrlResolverTest extends TestCase
use ApiKeyHelpersTrait;
private ShortUrlResolver $urlResolver;
private MockObject $em;
private MockObject $repo;
private MockObject & EntityManagerInterface $em;
private MockObject & ShortUrlRepositoryInterface $repo;
protected function setUp(): void
{

View File

@@ -27,9 +27,9 @@ class ShortUrlServiceTest extends TestCase
use ApiKeyHelpersTrait;
private ShortUrlService $service;
private MockObject $em;
private MockObject $urlResolver;
private MockObject $titleResolutionHelper;
private MockObject & EntityManagerInterface $em;
private MockObject & ShortUrlResolverInterface $urlResolver;
private MockObject & ShortUrlTitleResolutionHelperInterface $titleResolutionHelper;
protected function setUp(): void
{

View File

@@ -21,9 +21,9 @@ use Shlinkio\Shlink\Core\ShortUrl\UrlShortener;
class UrlShortenerTest extends TestCase
{
private UrlShortener $urlShortener;
private MockObject $em;
private MockObject $titleResolutionHelper;
private MockObject $shortCodeHelper;
private MockObject & EntityManager $em;
private MockObject & ShortUrlTitleResolutionHelperInterface $titleResolutionHelper;
private MockObject & ShortCodeUniquenessHelperInterface $shortCodeHelper;
protected function setUp(): void
{

View File

@@ -17,7 +17,7 @@ use Shlinkio\Shlink\IpGeolocation\Resolver\IpLocationResolverInterface;
class VisitToLocationHelperTest extends TestCase
{
private VisitToLocationHelper $helper;
private MockObject $ipLocationResolver;
private MockObject & IpLocationResolverInterface $ipLocationResolver;
protected function setUp(): void
{