OilfieldToolsNet/shlink
4
0
Fork 0
mirror of https://github.com/shlinkio/shlink.git synced 2025-02-25 18:45:27 -06:00
Code Issues Packages Projects Releases Wiki Activity

Print warning when trying to create short URL from CLI on openswoole in verbose mode

Browse Source
This commit is contained in:
Alejandro Celaya
2023-04-12 18:30:02 +02:00
parent f078d95588
commit 399c56a097
4 changed files with 67 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
module/Core/test/ShortUrl/UrlShortenerTest.php
View File

@@ -6,6 +6,7 @@ namespace ShlinkioTest\Shlink\Core\ShortUrl;
use Cake\Chronos\Chronos;
use Doctrine\ORM\EntityManager;
use Laminas\ServiceManager\Exception\ServiceNotFoundException;
use PHPUnit\Framework\Attributes\DataProvider;
use PHPUnit\Framework\Attributes\Test;
use PHPUnit\Framework\MockObject\MockObject;
@@ -26,6 +27,7 @@ class UrlShortenerTest extends TestCase
private MockObject & EntityManager $em;
private MockObject & ShortUrlTitleResolutionHelperInterface $titleResolutionHelper;
private MockObject & ShortCodeUniquenessHelperInterface $shortCodeHelper;
private MockObject & EventDispatcherInterface $dispatcher;
protected function setUp(): void
{
@@ -39,17 +41,19 @@ class UrlShortenerTest extends TestCase
fn (callable $callback) => $callback(),
);
$this->dispatcher = $this->createMock(EventDispatcherInterface::class);
$this->urlShortener = new UrlShortener(
$this->titleResolutionHelper,
$this->em,
new SimpleShortUrlRelationResolver(),
$this->shortCodeHelper,
$this->createMock(EventDispatcherInterface::class),
$this->dispatcher,
);
}
#[Test]
public function urlIsProperlyShortened(): void
#[Test, DataProvider('provideDispatchBehavior')]
public function urlIsProperlyShortened(bool $expectDispatchError, callable $dispatchBehavior): void
{
$longUrl = 'http://foobar.com/12345/hello?foo=bar';
$meta = ShortUrlCreation::fromRawData(['longUrl' => $longUrl]);
@@ -57,10 +61,24 @@ class UrlShortenerTest extends TestCase
$meta,
)->willReturnArgument(0);
$this->shortCodeHelper->method('ensureShortCodeUniqueness')->willReturn(true);
$this->dispatcher->expects($this->once())->method('dispatch')->willReturnCallback($dispatchBehavior);
$result = $this->urlShortener->shorten($meta);
$thereIsError = false;
$result->onEventDispatchingError(function () use (&$thereIsError) {
$thereIsError = true;
});
self::assertEquals($longUrl, $result->shortUrl->getLongUrl());
self::assertEquals($expectDispatchError, $thereIsError);
}
public static function provideDispatchBehavior(): iterable
{
yield 'no dispatch error' => [false, static function (): void {}];
yield 'dispatch error' => [true, static function (): void {
throw new ServiceNotFoundException();
}];
}
#[Test]